----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/ -----------------------------------------------------------
Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description ------- We need to refresh mLoadedValue after a save, otherwise the value is stale. I'm doing this by adding back the read() call in KCoreConfigSkeleton::save (which is what kdelibs did). Another option would be adding lots of mLoadedValue = mReference; in all the ::writeConfig, but that seems much more prone. I've also refactored the tests so they can be run independently now just fine. Diffs ----- autotests/kconfigskeletontest.h c54c7b0 autotests/kconfigskeletontest.cpp f401b9f src/core/kcoreconfigskeleton.cpp e4255a6 Diff: https://git.reviewboard.kde.org/r/121838/diff/ Testing ------- My tests now pass. Thanks, Albert Astals Cid
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
