----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121471/#review73086 -----------------------------------------------------------
Just like we have KFileWidget for an embeddable file-selection-widget, we could very well have a KDirSelectWidget for an embeddable dir-selection-widget. The code is currently in frameworkintegration/src/platformtheme/kdirselectdialog.cpp (and duplicated in kdelibs4support). I think it would be a valid solution to extract a widget out of it and put it in kio/src/filewidgets. The design should match KFileWidget as much as possible. - David Faure On Dec. 17, 2014, 11:58 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121471/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 11:58 a.m.) > > > Review request for KDE Frameworks, Bhushan Shah, David Faure, Lukáš Tinkl, > and Laurent Montel. > > > Repository: ark > > > Description > ------- > > I ported KDirSelectDialog to QFileDialog to get rid of kdelibs4support in > ExtractionDialog, but I run into one problem. This dialog needs to add > additional config widget, this is possible with using setExtension(widget) or > directly accessing layout and adding this widget directly to the layout. > Problem is that both options work only when I don't use native file dialog, > not mentioning that setExtension() is obsoleted and accesing directly to > layout of QFileDialog relies on knowning internal implementation in Qt so if > they change it, i.e they switch to another layout then QGridLayout, then it > will be broken again. I also tried to implement own QFileDialog using > KFileWidget, but problem is that KFileWidget works only for files and I need > to select a directory. You can set option to display just directories, but > selecting directories is unfortunately ignored. I'm open to a better > solution, but I've spent quite a lot of time trying to find it, but > unfortunately without any succe ss. > > > Diffs > ----- > > app/batchextract.cpp 9480e99 > kerfuffle/extractiondialog.h 5907403 > kerfuffle/extractiondialog.cpp f602861 > part/part.cpp 82d6f9c > > Diff: https://git.reviewboard.kde.org/r/121471/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
