Re: Review Request 121461: Fix for bug 341773 and minor changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121461/ --- (Updated Dec. 13, 2014, 1:06 a.m.) Review request for KDE Frameworks and

Re: plasma-framework now getting early CI feedback on changes within Gerrit

On Tuesday, 9 December 2014 19:44:19 CEST, Jan Kundrát wrote: I've activated CI checking for changes proposed to plasma-framework (kio is waiting for a review of two patches which improve test stability). KIO is now getting this, too. Sorry for the mail noise associated with re-checks. With

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

El Divendres, 12 de desembre de 2014, a les 15:31:03, Gregor Mi va escriure: > > On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: > > > Seriously ! this is abusing review board. Silent consent ? > > > At the very least one should deprecate the part of the API that allow > > > apps to set

Fwd: wrong branch: [kwidgetsaddons/removeicon1] src: Remove top right icon from KPageView

Hi, I accidently pushed to the wrong branch so a new branch was created. I pushed also to master but I cannot delete the wrong branch myself: remote: FATAL: D refs/heads/removeicon1 kwidgetsaddons gregormi DENIED by fallthru Or can I? Gregor Forwarded Message Subject: [kwi

Re: Review Request 121461: Fix for bug 341773 and minor changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121461/#review71892 --- A unittest for ".foo" is missing, now that you're special-casi

Fwd: [Kde-pim] KDE PIM IRC Meeting, vol. 2

Forwarding to the kde-frameworks mailing list as well, as they might be interested on the frameworks+kdepimlibs part. Cheers! Aleix -- Forwarded message -- From: Daniel Vrátil Date: Fri, Dec 12, 2014 at 2:27 PM Subject: [Kde-pim] KDE PIM IRC Meeting, vol. 2 To: kdepim Summary:

Re: Review Request 121448: Introduce ECMAddAppIcon.

On Dic. 11, 2014, 1:02 p.m., Ralf Habacker wrote: > > Regarding patterns, why not just using a list of the icons we need? > > patterns+cmake have weird effects... > > Would it be possible to include a test? It's reasonably easy to create ecm > > tests nowadays and very useful afterwards. You'll

Review Request 121471: Port KDirSelectDialog to QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121471/ --- Review request for KDE Frameworks and Bhushan Shah. Repository: ark Des

Re: Review Request 121459: Fixed data type for _KDE_NET_WM_BLUR_BEHIND_REGION

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121459/ --- (Updated Dec. 12, 2014, 4:03 p.m.) Status -- This change has been ma

Re: Review Request 121459: Fixed data type for _KDE_NET_WM_BLUR_BEHIND_REGION

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121459/#review71877 --- Ship it! using long should have been wrong itfp, since it's o

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

> On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: > > Seriously ! this is abusing review board. Silent consent ? > > At the very least one should deprecate the part of the API that allow apps > > to set the icon, since it is not honoured. > > I would honestly recommand to revert this

Re: Review Request 121461: Fix for bug 341773 and minor changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121461/ --- (Updated Dec. 12, 2014, 9 p.m.) Review request for KDE Frameworks and Dav

Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121400/#review71865 --- This needs a unit test comparing generated output with what yo

Re: Review Request 121448: Introduce ECMAddAppIcon.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review71863 --- The assumptions this funciton makes about the form of the argu

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

> On Nov. 9, 2014, 9:52 p.m., Alexander Richardson wrote: > > When I originally got KF5 to compile on windows I seem to remember having > > to do this a few times manually as well. > > > > Would it make sense to add the macro to KCoreAddons? KDEPimLibs also depends on this macro in several pla

Re: Review Request 121448: Introduce ECMAddAppIcon.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Dez. 12, 2014, 2:34 nachm.) Review request for Extra Cmake Modul

Re: Review Request 121448: Introduce ECMAddAppIcon.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review71859 --- modules/ECMAddAppIcon.cmake

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

> On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: > > Seriously ! this is abusing review board. Silent consent ? > > At the very least one should deprecate the part of the API that allow apps > > to set the icon, since it is not honoured. > > I would honestly recommand to revert this

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

On Wed, Sep 17, 2014 at 11:47 AM, Martin Gräßlin wrote: > Hi all, > > I just prepared moving kglobalacceld from plasma-workspace into kglobalaccel. > You can find the code in my personal clone of kglobalaccel at [1] in branch > master. > > The following steps were performed so far: > * filter-bran

Re: Review Request 121461: Fix for bug 341773 and minor changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121461/#review71854 --- src/core/global.cpp

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

On Fri, Oct 3, 2014 at 1:16 PM, Alex Merry wrote: > > On 2014-09-17 10:47, Martin Gräßlin wrote: > >> Hi all, >> >> I just prepared moving kglobalacceld from plasma-workspace into >> kglobalaccel. >> You can find the code in my personal clone of kglobalaccel at [1] in >> branch >> master. >> >> Th

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

> On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: > > Seriously ! this is abusing review board. Silent consent ? > > At the very least one should deprecate the part of the API that allow apps > > to set the icon, since it is not honoured. > > I would honestly recommand to revert this

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

> On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: > > Seriously ! this is abusing review board. Silent consent ? > > At the very least one should deprecate the part of the API that allow apps > > to set the icon, since it is not honoured. > > I would honestly recommand to revert this

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/#review71849 --- Seriously ! this is abusing review board. Silent consent ? At

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/ --- (Updated Dec. 12, 2014, 11:04 a.m.) Status -- This change has been m

Review Request 121461: Fix for bug 341773 and minor changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121461/ --- Review request for KDE Frameworks and David Faure. Bugs: 341773 https

Re: Review Request 121459: Fixed data type for _KDE_NET_WM_BLUR_BEHIND_REGION

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121459/#review71846 --- That looks very reasonable to me. +1 - Martin Gräßlin On De

Re: Review Request 121448: Introduce ECMAddAppIcon.

> On Dez. 11, 2014, 5:02 nachm., Aleix Pol Gonzalez wrote: > > modules/ECMAddAppIcon.cmake, line 36 > > > > > > I wouldn't take WINCE into account, its support hasn't been ported into > > kf5. > > > > Al

Review Request 121459: Fixed data type for _KDE_NET_WM_BLUR_BEHIND_REGION

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121459/ --- Review request for KDE Frameworks and kwin. Repository: kwin Descriptio