----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/#review71849 -----------------------------------------------------------
Seriously ! this is abusing review board. Silent consent ? At the very least one should deprecate the part of the API that allow apps to set the icon, since it is not honoured. I would honestly recommand to revert this commit. - Hugo Pereira Da Costa On Dec. 12, 2014, 11:04 a.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121379/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 11:04 a.m.) > > > Review request for KDE Frameworks, Christoph Feck and Dominik Haumann. > > > Repository: kwidgetsaddons > > > Description > ------- > > As mentioned in [KPageView/KTitleWidget: Remove top right > icon](https://forum.kde.org/viewtopic.php?f=285&t=123837) the top-right icon > serves no visible purpose and can even be a distraction. This patch removes > the code that adds the icon. > > > Diffs > ----- > > src/kpageview.cpp 69d1bf9a20549b74557f3fdf9a7057cb74258cb1 > > Diff: https://git.reviewboard.kde.org/r/121379/diff/ > > > Testing > ------- > > Screenshots: > http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_1before.png (before patch) > http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_2after.png (after) > http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_1before.png (before patch) > http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_2after.png (after) > > > Thanks, > > Gregor Mi > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
