----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121459/#review71846 -----------------------------------------------------------
That looks very reasonable to me. +1 - Martin Gräßlin On Dec. 12, 2014, 11:22 a.m., Hugo Pereira Da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121459/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 11:22 a.m.) > > > Review request for KDE Frameworks and kwin. > > > Repository: kwin > > > Description > ------- > > Somehow (although I do not know the details), the change from X calls to xcb > (or similarily XA_CARDINAL to XCB_ATOM_CARDINAL) involves a conversion from > unsigned int to uint32_t. > As a consequence one must change the data type and cast accordingly, so that > 'valid' blur regions passed from Qt4/KDE4 applications and that where > properly honored by kwin@kde4 are still working for kwin@kf5 > > thanks > > > Diffs > ----- > > effects/blur/blur.cpp 29852de > > Diff: https://git.reviewboard.kde.org/r/121459/diff/ > > > Testing > ------- > > yes > > BLUR_BEHIND_REGIONS that were honored with kde4 and not any more with kf5, > are again ... > > I have no clue whether this impacts plasma@kf5 > (it could well be that there the property was fixed 'the other way around', > by casting from unsigned long to uint_32 when setting the property, via XCB. > This however would break when running against kwin@kde4) > > > Thanks, > > Hugo Pereira Da Costa > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
