Re: Review Request 120508: Port kio_trash_win to KF5

2014-10-05 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120508/ --- (Updated Oct. 5, 2014, 11:22 p.m.) Status -- This change has been ma

Re: Review Request 120508: Port kio_trash_win to KF5

2014-10-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120508/#review67976 --- The port looks legit to me. +1 - Aleix Pol Gonzalez On Oct

Re: Review Request 120508: Port kio_trash_win to KF5

2014-10-05 Thread Mark Gaiser
> On okt 5, 2014, 9:19 p.m., Mark Gaiser wrote: > > Could you port the listEntry calls as well? The current port will give > > warnings about that. > > > > All calls with: > > listEntry( entry, false ); > > > > can be replaced with: > > listEntry( entry ); > > > > All calls with: > > listEntr

Re: Review Request 120508: Port kio_trash_win to KF5

2014-10-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120508/#review67974 --- Could you port the listEntry calls as well? The current port w

Review Request 120508: Port kio_trash_win to KF5

2014-10-05 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120508/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-05 Thread Albert Astals Cid
> On oct. 5, 2014, 5:58 p.m., Christoph Feck wrote: > > Sorry for chiming in late, just noticed the commit. > > > > Any reason why the resource is checked first, not last? > > > > If the programmer decides to use the resource, the "locateAll" effectively > > turns into a "locateNone". Not real

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-05 Thread Christoph Cullmann
> On Oct. 5, 2014, 5:58 p.m., Christoph Feck wrote: > > Sorry for chiming in late, just noticed the commit. > > > > Any reason why the resource is checked first, not last? > > > > If the programmer decides to use the resource, the "locateAll" effectively > > turns into a "locateNone". Not real

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-05 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120099/ --- (Updated Oct. 5, 2014, 5:32 p.m.) Status -- This change has been mar

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120099/#review67966 --- Sorry for chiming in late, just noticed the commit. Any reaso

Re: changelog for KF 5.3

2014-10-05 Thread Dominik Haumann
On Sunday 05 October 2014 11:59:59 Christoph Cullmann wrote: > > Here's what I wrote from the changes in git (the CHANGELOG keyword isn't > > used enough yet...) > > > > Please tell me about anything I missed. > > > > I am especially unsure about KTextEditor (so many changes!), KService (I > > gu

Re: changelog for KF 5.3

2014-10-05 Thread Christoph Cullmann
> Here's what I wrote from the changes in git (the CHANGELOG keyword isn't used > enough yet...) > > Please tell me about anything I missed. > > I am especially unsure about KTextEditor (so many changes!), KService (I > guess > a better description of the KPluginInfo changes could be useful) > an

Build failed in Jenkins: kdelibs4support_master_qt5 #282

2014-10-05 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 3563 lines...] -- Installing: