----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120508/#review67976 -----------------------------------------------------------
The port looks legit to me. +1 - Aleix Pol Gonzalez On Oct. 5, 2014, 7:35 p.m., Nicolás Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120508/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2014, 7:35 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Ported the Windows implementation of kio_trash to KF5/Qt5. > > > Diffs > ----- > > src/ioslaves/trash/kio_trash_win.h 5a08427 > src/ioslaves/trash/kio_trash_win.cpp 624318b > > Diff: https://git.reviewboard.kde.org/r/120508/diff/ > > > Testing > ------- > > It builds, MSVC2013. Haven't tested if it works (the unit test still doesn't > build). > > > Thanks, > > Nicolás Alvarez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
