> On okt 5, 2014, 9:19 p.m., Mark Gaiser wrote: > > Could you port the listEntry calls as well? The current port will give > > warnings about that. > > > > All calls with: > > listEntry( entry, false ); > > > > can be replaced with: > > listEntry( entry ); > > > > All calls with: > > listEntry( entry, true ); <-- note the "true" > > > > can be removed.
On a second thought, nevermind this. I will take care of it. I'm porting all of kde-runtime away from this deprecated method now anyway (i won't touch kio_trash_win yet since i don't like merge conflicts, i will once your change is merged in). - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120508/#review67974 ----------------------------------------------------------- On okt 5, 2014, 7:35 p.m., Nicolás Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120508/ > ----------------------------------------------------------- > > (Updated okt 5, 2014, 7:35 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Ported the Windows implementation of kio_trash to KF5/Qt5. > > > Diffs > ----- > > src/ioslaves/trash/kio_trash_win.h 5a08427 > src/ioslaves/trash/kio_trash_win.cpp 624318b > > Diff: https://git.reviewboard.kde.org/r/120508/diff/ > > > Testing > ------- > > It builds, MSVC2013. Haven't tested if it works (the unit test still doesn't > build). > > > Thanks, > > Nicolás Alvarez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
