Re: Review Request 119349: typo in signal names ( upowermanager )

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119349/ --- (Updated July 18, 2014, 8:31 a.m.) Review request for KDE Frameworks and

Re: Web Shortcuts KCM

On Friday 18 July 2014 00:37:02 Kevin Ottens wrote: > On Thursday 17 July 2014 10:37:45 David Faure wrote: > > On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > > > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > > > (

Re: Web Shortcuts KCM

On Thursday 17 July 2014 10:37:45 David Faure wrote: > On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > > (ie at most a > > > > > > > > widget would be enough for the a

OSX/CI system: prison fails to build on branch master

While trying to build kdepimlibs' dependency prison on OSX I got tons of error messages like this: --- ... Scanning dependencies of target prison [ 25%] [ 31%] [ 37%] [ 43%] [ 50%] [ 56%] Building CXX object lib/prison/CMakeFiles/prison.dir/abstractbarcode.cpp.o Building CXX object lib/prison/CMa

Re: KXMLGUI and KParts

Luca Beltrame wrote: > - Or instead the code loading the KPart needs to be adjusted? Just FYI: the issue was in Konsole, which did not set a component name. This was fixed in g88ffcc8 in Konsole (frameworks branch). -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79

KXMLGUI and KParts

Hello, while testing out Yakuake (frameworks) I noticed that it would not display the context menu. Konsole had a similar issue, but that was fixed by adjusting the calls that loaded the XML file (this occurred after the port to KXMLGUI_INSTALL_DIR). However this did not occur with Yakuake,

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 17, 2014, 8:17 p.m.) Review request for KDE Frameworks and

Jenkins build is back to stable : kdelibs_stable #1153

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119345: Port away from deprecated QUrl API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119345/#review62618 --- Ship it! Ship It! - Jeremy Whiting On July 17, 2014, 11:56

I want to build kmail under win32 with KF5

Is there any pre-build environment for this? Or its too complicated to install the dependence apps and libs -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/ma

Jenkins build became unstable: kdelibs_stable #1152

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Review Request 119345: Port away from deprecated QUrl API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119345/ --- Review request for KDE Frameworks. Repository: attica Description -

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review62607 --- Unless I'm missing something, this approach seems to defeat th

Re: Review Request 119343: Do not leak toolbox items

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119343/ --- (Updated July 17, 2014, 4:49 p.m.) Status -- This change has been ma

Re: Review Request 119341: Do not leak containment actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119341/ --- (Updated July 17, 2014, 4:49 p.m.) Status -- This change has been ma

Re: Review Request 119343: Do not leak toolbox items

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119343/#review62602 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 17, 2014, 4

Review Request 119343: Do not leak toolbox items

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119343/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119341: Do not leak containment actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119341/#review62594 --- Ship it! Ship It! - Marco Martin On Lug. 17, 2014, 3:29 p.

Review Request 119341: Do not leak containment actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119341/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

> On July 17, 2014, 3:42 p.m., Martin Gräßlin wrote: > > would it be possible to add a unit test for it? I know it's not easy as it > > depends on the window manager, but Openbox which is used on the CI system > > is quite decent. > > Martin Klapetek wrote: > I may try > > Christoph Feck

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

> On July 17, 2014, 1:42 p.m., Martin Gräßlin wrote: > > would it be possible to add a unit test for it? I know it's not easy as it > > depends on the window manager, but Openbox which is used on the CI system > > is quite decent. > > Martin Klapetek wrote: > I may try Please add/close bu

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 1:42 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 434 > > > > > > How is this whole branch "simpler" ? > > > > We end up doing widths and sizes

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 1:42 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 204 > > > > > > Just no. to me, or that or stays as is in master now. Again, the timer can be disabled

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 1:42 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 434 > > > > > > How is this whole branch "simpler" ? > > > > We end up doing widths and sizes

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 1:42 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 434 > > > > > > How is this whole branch "simpler" ? > > > > We end up doing widths and sizes

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 1:42 p.m., David Edmundson wrote: > > >the important differences are two, that are imo 100% necessary to maintain > > >a pixel perfect rendering (sacrificing that is a regression simply not > > >acceptable in any case, even for non default themes, ever). At the same > > >ti

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

> On July 17, 2014, 3:42 p.m., Martin Gräßlin wrote: > > would it be possible to add a unit test for it? I know it's not easy as it > > depends on the window manager, but Openbox which is used on the CI system > > is quite decent. I may try - Martin

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119337/#review62576 --- would it be possible to add a unit test for it? I know it's no

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review62575 --- >the important differences are two, that are imo 100% necessar

Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119337/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 17, 2014, 12:47 p.m.) Review request for KDE Frameworks and

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 17, 2014, 12:13 p.m.) Review request for KDE Frameworks and

Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119323: fix auth race condition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 17, 2014, 11:23 a.m.) Review request for KDE Frameworks, Hr

Review Request 119335: Use CMAKE_INSTALL_FULL_LIBEXECDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119335/ --- Review request for KDE Frameworks. Repository: kcrash Description -

Review Request 119331: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119331/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 119329: return invalid for packages with Hidden=true in the metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119329/ --- (Updated July 17, 2014, 10:32 a.m.) Status -- This change has been m

Re: Review Request 119325: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

> On July 17, 2014, 10:42 a.m., David Faure wrote: > > Looks good to me. Please grep for more uses of LIBEXEC_INSTALL_DIR in other > > frameworks though, they might have the same issue? looks like there are a few more frameworks with this case. will be opening reviews for them during the day.

Re: Review Request 119325: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119325/ --- (Updated July 17, 2014, 10:25 a.m.) Status -- This change has been m

Re: Review Request 119329: return invalid for packages with Hidden=true in the metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119329/#review62561 --- Ship it! The reasoning is that it makes it easier for downstr

Review Request 119329: return invalid for packages with Hidden=true in the metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119329/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119300/ --- (Updated July 17, 2014, 9:40 a.m.) Status -- This change has been di

Re: Review Request 119325: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119325/#review62556 --- Ship it! Looks good to me. Please grep for more uses of LIBEX

Re: Web Shortcuts KCM

On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > (ie at most a > > > > > > widget would be enough for the app related settings, we should talk to > > > the > > > underlying

Re: Review Request 119321: kio-extras: Install KIO and KDED modules into correct folders

> On July 16, 2014, 8:21 p.m., Alexander Richardson wrote: > > The kioslaves part seems to be more or less like my patch here: > > https://git.reviewboard.kde.org/r/119081/ , just without the renaming of > > the output file. OOoops, sorry, I didn't check for previous reviews. And also assigne

Re: Review Request 119321: kio-extras: Install KIO and KDED modules into correct folders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119321/ --- (Updated July 17, 2014, 10:15 a.m.) Status -- This change has been d