----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119325/#review62556 -----------------------------------------------------------
Ship it! Looks good to me. Please grep for more uses of LIBEXEC_INSTALL_DIR in other frameworks though, they might have the same issue? - David Faure On July 16, 2014, 7:29 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119325/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 7:29 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdesu > > > Description > ------- > > This resolves the problem of passing relative vs. absolute > KF5_LIBEXEC_INSTALL_DIR/LIBEXEC_INSTALL_DIR. > ATM kdesu does not even work due to that (suprocess.cpp change) > > > Diffs > ----- > > src/client.cpp f207122 > src/config-kdesu.h.cmake 992503d > src/kdesud/CMakeLists.txt 45b6aa2 > src/suprocess.cpp 5c30f65 > > Diff: https://git.reviewboard.kde.org/r/119325/diff/ > > > Testing > ------- > > builds, and kdesu works > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
