Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #231

2014-04-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #231

2014-04-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kio_master_qt5 #143

2014-04-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116037: change entities to reflect new branding

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/#review54830 --- This review has been submitted with commit b981a3f02700c19772

Re: Review Request 116037: change entities to reflect new branding

2014-04-01 Thread T.C. Hollingsworth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/ --- (Updated April 1, 2014, 11:43 p.m.) Status -- This change has been m

Re: Review Request 117316: Bump source-incompatible KDE4 TODO to KF6

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/#review54829 --- This review has been submitted with commit a606adb2537d9a63eb

Re: Review Request 117316: Bump source-incompatible KDE4 TODO to KF6

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/ --- (Updated April 1, 2014, 11:35 p.m.) Status -- This change has been m

Re: Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/#review54828 --- This review has been submitted with commit 3e868952e963604e2d

Re: Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/ --- (Updated April 1, 2014, 11:34 p.m.) Status -- This change has been m

Re: Review Request 117314: Improve kross console app i18n

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/#review54827 --- This review has been submitted with commit 2b510f9873a8eaafa5

Re: Review Request 117314: Improve kross console app i18n

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/ --- (Updated April 1, 2014, 11:33 p.m.) Status -- This change has been m

Review Request 117320: Update the kbuildsycoca5 man page

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117320/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Re: Review Request 117316: Bump source-incompatible KDE4 TODO to KF6

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/#review54826 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 1

Re: Review Request 117318: Move methods from KCompletionPrivate to KCompletionMatchesWrapper

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117318/#review54825 --- Ship it! Looks good to me, and you're the maintainer after al

Re: Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/#review54824 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 1

Re: Review Request 117314: Improve kross console app i18n

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/#review54823 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 9

Re: Translation support in Qt-translation-based frameworks

2014-04-01 Thread Albert Astals Cid
El Dimarts, 1 d'abril de 2014, a les 01:07:37, Aurélien Gâteau va escriure: > [sinp] > > > > To test translations: > > > > > > 1. Generate a .pot file by following those instructions: > > > http://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Sy > > > stem s#Testing_your_Messages

Review Request 117318: Move methods from KCompletionPrivate to KCompletionMatchesWrapper

2014-04-01 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117318/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Review Request 117317: Improve the KAbstractFileItemActionPlugin apidox

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117317/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 117316: Bump source-incompatible KDE4 TODO to KF6

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/ --- Review request for KDE Frameworks. Repository: kparts Description -

Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kse

Review Request 117314: Improve kross console app i18n

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kro

Review Request 117313: Deprecate ThumbCreatorV2 and improve ThumbCreator apidox

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117313/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/ --- (Updated April 1, 2014, 9:37 p.m.) Status -- This change has been ma

Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/#review54821 --- This review has been submitted with commit d1e542627f907c9512

Build failed in Jenkins: kio_master_qt5 #142

2014-04-01 Thread KDE CI System
See Changes: [aiacovitti] Fix setting "ssl_was_in_use" metadata. -- [...truncated 558 lines...] [ 18%] Automatic moc for target udsentrytest Scanning dependencies of target listdirtest_automoc Generatin

Jenkins build is back to normal : kjs_master_qt5 #33

2014-04-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()

2014-04-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/#review54816 --- Ship it! On the other hand, Qt hopefully won't remove the foc

Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()

2014-04-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/#review54813 --- Probably should only try to set the focus if the widget is goi

Re: Review Request 117304: Remove clipboard data re-fetching line and its comment

2014-04-01 Thread Alex Merry
> On April 1, 2014, 4:58 p.m., David Faure wrote: > > src/widgets/paste.cpp, line 156 > > > > > > the event loop is here. Ah, nested event loops, cause of so many issues :-) As far as I can tell, the xcb platfo

Re: Review Request 117274: Fix i18n in kross

2014-04-01 Thread Aleix Pol
On Tue, Apr 1, 2014 at 6:02 PM, Alex Merry wrote: >This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117274/ > This change has been marked as submitted. > Review request for KDE Frameworks. > By Alex Merry. > > *Updated April 1, 2014, 4:02 p.m

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-04-01 Thread Christoph Cullmann
> > I've no idea if this will actually end up the case, but won't KF 5.1 > > end up depending on Qt 5.3? > > ie. this problem is going to come up again once KF 5.0 is released. > Looking at the qt list, it might be, that they reconsider to merge all gits > into one again > which will make tracking

Re: Review Request 117304: Remove clipboard data re-fetching line and its comment

2014-04-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/#review54807 --- src/widgets/paste.cpp

Re: Review Request 117304: Remove clipboard data re-fetching line and its comment

2014-04-01 Thread Alex Merry
> On April 1, 2014, 4:28 p.m., David Faure wrote: > > How can you know that it wasn't true? The timer was inside Qt itself. This > > is about dropping non-URI data onto a file manager and getting the popup > > "how do you want to name the resulting file (to save this data)", and by > > the tim

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-04-01 Thread Christoph Cullmann
> On Tue, Apr 1, 2014 at 9:23 PM, Dominik Haumann wrote: > > On Monday, March 31, 2014 23:24:09 Albert Astals Cid wrote: > >> El Dilluns, 31 de març de 2014, a les 22:34:21, Dominik Haumann va > >> escriure: > >> > On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: > >> > > On Mon, Mar 31, 2014

Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4

2014-04-01 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/#review54802 --- submitted in https://git.reviewboard.kde.org/r/117208/ - Hrvo

Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4

2014-04-01 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/ --- (Updated April 1, 2014, 4:31 p.m.) Status -- This change has been di

Re: Review Request 117304: Remove clipboard data re-fetching line and its comment

2014-04-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/#review54803 --- How can you know that it wasn't true? The timer was inside Qt

Re: Review Request 117274: Fix i18n in kross

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54797 --- This review has been submitted with commit e7c842103077a647c8

Re: Review Request 117274: Fix i18n in kross

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 4:02 p.m.) Status -- This change has been ma

Re: Review Request 117274: Fix i18n in kross

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54796 --- This review has been submitted with commit b17149e7a97003d69e

Re: Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/#review54798 --- This review has been submitted with commit 99055b3b04cd173271

Review Request 117304: Remove clipboard data re-fetching line and its comment

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/ --- (Updated April 1, 2014, 4:04 p.m.) Status -- This change has been ma

Re: Review Request 117274: Fix i18n in kross

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54795 --- This review has been submitted with commit f81033ed266791ac2d

Re: Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/#review54792 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 3

Re: Review Request 117297: Move settings from kde-runtime/doc/api to kapidox

2014-04-01 Thread Aleix Pol Gonzalez
> On April 1, 2014, 2:53 p.m., Aurélien Gâteau wrote: > > src/Doxyfile.local, line 9 > > > > > > This is enabled by default already: > > http://www.stack.nl/~dimitri/doxygen/manual/config.html#cfg_sort_member_docs

Re: Review Request 117274: Fix i18n in kross

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54789 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 2

Powerdevil docbooks in kde-workspace/plasma-desktop/doc/kcontrol/

2014-04-01 Thread Burkhard Lück
Hi, kde-workspace/plasma-desktop/doc/kcontrol/ (master) has still a subdir powerdevil, this afaik belongs to extragear/base/powerdevil/doc/kcontrol, but I have no idea how to move it properly between different git repos. Btw I'd like to start fixing docbook related issues inside the new kde- wo

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #230

2014-04-01 Thread KDE CI System
See Changes: [notmart] fix css -- [...truncated 564 lines...] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/kded_platformstatu

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #230

2014-04-01 Thread KDE CI System
See Changes: [notmart] fix css -- [...truncated 566 lines...] [ 24%] Generating moc_tooltipdialog.cpp Generating moc_corebindingsplugin.cpp Generating moc_da

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #229

2014-04-01 Thread KDE CI System
See Changes: [notmart] text areas use textViewColor -- [...truncated 566 lines...] Generating moc_datasource.cpp Generating moc_framesvgitem.cpp Generating

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #229

2014-04-01 Thread KDE CI System
See Changes: [notmart] text areas use textViewColor -- [...truncated 566 lines...] Generating moc_corebindingsplugin.cpp Generating moc_datamodel.cpp Generat

Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/ --- Review request for KDE Frameworks. Repository: kio Description ---

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #228

2014-04-01 Thread KDE CI System
See Changes: [notmart] icons on buttons readable on dark themes -- [...truncated 566 lines...] Generating moc_framesvgitem.cpp Generating moc_iconitem.cpp

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #228

2014-04-01 Thread KDE CI System
See Changes: [notmart] icons on buttons readable on dark themes -- [...truncated 566 lines...] Generating moc_corebindingsplugin.cpp Generating moc_datamodel

Re: Review Request 117297: Move settings from kde-runtime/doc/api to kapidox

2014-04-01 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117297/#review54783 --- src/Doxyfile.local

Re: Review Request 117274: Fix i18n in kross

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 2:40 p.m.) Review request for KDE Frameworks. S

Re: Review Request 117274: Resurrect the KAboutData for the kross console

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 2:40 p.m.) Review request for KDE Frameworks. C

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #227

2014-04-01 Thread KDE CI System
See Changes: [notmart] add a script to fix the definition in the svg -- [...truncated 566 lines...] Generating moc_windowthumbnail.cpp [ 21%] Built target

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #227

2014-04-01 Thread KDE CI System
See Changes: [notmart] add a script to fix the definition in the svg -- [...truncated 569 lines...] Generating widget.moc

Re: Review Request 117283: Fix i18n in kbuildsycoca5

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/#review54781 --- This review has been submitted with commit 5e74d463e9222685e1

Re: Review Request 117283: Fix i18n in kbuildsycoca5

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/ --- (Updated April 1, 2014, 2:35 p.m.) Status -- This change has been ma

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #226

2014-04-01 Thread KDE CI System
See Changes: [notmart] use buttonBackground color in the css -- [...truncated 584 lines...] Linking CXX shared library libplatformcomponentsplugin.so [ 23%

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #226

2014-04-01 Thread KDE CI System
See Changes: [notmart] use buttonBackground color in the css -- [...truncated 574 lines...] Generating moc_tooltip.cpp Generating moc_units.cpp Generating mo

KF5 Update Meeting Minutes 2014-w14

2014-04-01 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 14 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, apol, notmart, Riddell, tosky and myself. * afiestas will push the branch with removed interfaces; * he's first making sure n

Review Request 117297: Move settings from kde-runtime/doc/api to kapidox

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117297/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: Review Request 117268: Deprecate the RESTORE macro

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117268/#review54780 --- This review has been submitted with commit 2b9dbeb1d3e43d7c9a

Re: Review Request 117268: Deprecate the RESTORE macro

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117268/ --- (Updated April 1, 2014, 2:22 p.m.) Status -- This change has been ma

Re: Review Request 117268: Deprecate the RESTORE macro

2014-04-01 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117268/#review54779 --- Ship it! Makes sense to me. You might want to wrap it in a "#

Re: Translation support in Qt-translation-based frameworks

2014-04-01 Thread Burkhard Lück
Am Montag, 31. März 2014, 07:30:29 schrieb Aurélien Gâteau: > > I just committed the necessary build system changes to enable all > Qt-translation-based frameworks to build, install and load their > translations. > Thanks, I see still some problems: solid: solid5 ok, solid-hardware work in progr

Re: Review Request 117296: ecm_create_qm_from_po_files: do not replace "-" with "_" in .po files

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/#review54778 --- This review has been submitted with commit ddd33b850bb5191745

Re: Review Request 117296: ecm_create_qm_from_po_files: do not replace "-" with "_" in .po files

2014-04-01 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/ --- (Updated April 1, 2014, 1:38 p.m.) Status -- This change has been ma

Re: Review Request 116568: Fixes to PIC image format handler

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/ --- (Updated April 1, 2014, 1:27 p.m.) Status -- This change has been di

Re: I broke kwin

2014-04-01 Thread Aleix Pol
On Tue, Apr 1, 2014 at 3:04 PM, Martin Klapetek wrote: > On Tue, Apr 1, 2014 at 3:01 PM, David Faure wrote: > >> but I can't fix it? ;) >> >> I removed a very old obsolete method from kwindowsystem, then I noticed >> kwin >> was still using it, but I can't push the fix? >> > > Kwin was splitted i

Re: Review Request 117296: ecm_create_qm_from_po_files: do not replace "-" with "_" in .po files

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/#review54776 --- Ship it! Ship It! - Alex Merry On April 1, 2014, 1:16 p.m.

Review Request 117296: ecm_create_qm_from_po_files: do not replace "-" with "_" in .po files

2014-04-01 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: I broke kwin

2014-04-01 Thread Luigi Toscano
On Tuesday 01 of April 2014 15:01:20 David Faure wrote: > but I can't fix it? ;) > > I removed a very old obsolete method from kwindowsystem, then I noticed kwin > was still using it, but I can't push the fix? > > [...] > To g...@git.kde.org:kde-workspace > ! [remote rejected] master -> master (

Re: I broke kwin

2014-04-01 Thread Martin Klapetek
On Tue, Apr 1, 2014 at 3:01 PM, David Faure wrote: > but I can't fix it? ;) > > I removed a very old obsolete method from kwindowsystem, then I noticed > kwin > was still using it, but I can't push the fix? > Kwin was splitted into its own new repository, kde:kwin, the fix should be pushed there

I broke kwin

2014-04-01 Thread David Faure
but I can't fix it? ;) I removed a very old obsolete method from kwindowsystem, then I noticed kwin was still using it, but I can't push the fix? Counting objects: 31, done. Delta compression using up to 8 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 400 bytes | 0

Re: Review Request 117283: Fix i18n in kbuildsycoca5

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/#review54772 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 1

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-01 Thread Aleix Pol Gonzalez
> On April 1, 2014, 10:55 a.m., Aleix Pol Gonzalez wrote: > > I think it's fine that you add the other one if you prefer people to use > > setters, but please don't deprecate the old one. There's little reason for > > doing so, it's very old API and it has always worked as is. > > Alex Merry w

Build failed in Jenkins: kjs_master_qt5 #32

2014-04-01 Thread KDE CI System
See Changes: [vonreth] fixed mingw build -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Re: Review Request 117278: Remove KDE4 TODO

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/#review54761 --- This review has been submitted with commit 2acc257caa5af66822

Re: Review Request 117278: Remove KDE4 TODO

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/ --- (Updated April 1, 2014, 11:22 a.m.) Status -- This change has been m

Review Request 117283: Fix i18n in kbuildsycoca5

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-01 Thread Alex Merry
> On April 1, 2014, 10:55 a.m., Aleix Pol Gonzalez wrote: > > I think it's fine that you add the other one if you prefer people to use > > setters, but please don't deprecate the old one. There's little reason for > > doing so, it's very old API and it has always worked as is. The reason for d

Re: Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54758 --- Well, still it sounds a good idea to note that it's from a mai

Re: Review Request 117278: Remove KDE4 TODO

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/#review54757 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 1

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review54756 --- I think it's fine that you add the other one if you prefer peo

Re: Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData

2014-04-01 Thread Alex Merry
> On April 1, 2014, 10:47 a.m., Aleix Pol Gonzalez wrote: > > src/console/main.cpp, line 130 > > > > > > You might want to keep the context with, i18nc, no? It wasn't a very useful context, I don't think, and wa

Re: Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54753 --- src/console/main.cpp

Review Request 117278: Remove KDE4 TODO

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ --- (Updated April 1, 2014, 10:09 a.m.) Review request for KDE Frameworks, Da

Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/#review54751 --- This review has been submitted with commit f606255894e9c9eca7

Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/ --- (Updated April 1, 2014, 9:44 a.m.) Status -- This change has been ma

Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/ --- (Updated April 1, 2014, 9:44 a.m.) Status -- This change has been ma

Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/#review54752 --- This review has been submitted with commit 8402305be5e3fb4fef

Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-04-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/#review54745 --- Ship it! Thanks. - Christoph Feck On April 1, 2014, 12:25

  1   2   >