> On April 1, 2014, 10:47 a.m., Aleix Pol Gonzalez wrote: > > src/console/main.cpp, line 130 > > <https://git.reviewboard.kde.org/r/117274/diff/1/?file=262151#file262151line130> > > > > You might want to keep the context with, i18nc, no?
It wasn't a very useful context, I don't think, and was probably only there because QCoreApplication::translate() requires it. I could put in a more helpful context if you think that's useful, though (like "command line argument"). - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54753 ----------------------------------------------------------- On April 1, 2014, 1:17 a.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117274/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 1:17 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kross > > > Description > ------- > > Resurrect the KAboutData for the kross console > > > Use i18n() instead of QCoreApplication::translate() in console app > > This was probably from copy-pasted command-line parsing code; everything > else in this framework uses KI18n. > > Use the correct translation catalog in the console application > > > Diffs > ----- > > CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 > src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 > src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef > > Diff: https://git.reviewboard.kde.org/r/117274/diff/ > > > Testing > ------- > > Ran kf5kross --help. Not investigated how to test the translation stuff. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
