----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/ -----------------------------------------------------------
(Updated April 1, 2014, 9:37 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description ------- KDatePicker: override changeEvent() instead of setEnabled() As the comment noted, setEnabled() is not virtual. Also, there was no need to separately enabled/disable the individual components, when they are children of the KDatePicker widget. Instead, we override changeEvent() and use it to focus the table (as before). This also extends the kdatepicktest to temporarily disable the picker. Diffs ----- src/kdatepicker.h 855aeb01ff457394cfbcff57845a57a9eae0a103 src/kdatepicker.cpp 345ee2d97632647789e6762e5e155e75802c2191 tests/kdatepicktest.cpp 5f29110f2335bb110b3470007a59f9cb8b6bcfee Diff: https://git.reviewboard.kde.org/r/117277/diff/ Testing ------- Builds. Tests pass. Played around with kdatepicktest; behaviour seems unchanged. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
