Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. > > Christoph Feck wrote: > Locally, I get this error: > > AUTOMOC: error: process for > /lo

Re: Review Request 113805: Do not change the build types available with cmake

> On Nov. 12, 2013, 4:24 p.m., Alexander Neundorf wrote: > > IMO the patch as it is is not good. > > > > Several things: > > 1) This file, is not mandatory at all with KDE frameworks. > > You can build applications using KDE frameworks libraries without it. You > > (the developer of the applica

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. > > Christoph Feck wrote: > Locally, I get this error: > > AUTOMOC: error: process for > /lo

Jenkins build became unstable: kdelibs_frameworks_qt5 #1683

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43784 --- This review has been submitted with commit 7ec8cf76bad0f16a294

Re: Review Request 113329: Adapt KSystemTimeZones to new KTimeZoned signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113329/#review43786 --- This review has been submitted with commit 7ec8cf76bad0f16a294

Re: Review Request 113329: Adapt KSystemTimeZones to new KTimeZoned signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113329/ --- (Updated Nov. 15, 2013, 10:10 p.m.) Status -- This change has been ma

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

> On Nov. 15, 2013, 10:09 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 7ec8cf76bad0f16a2947eb6d5986af436a3bdc69 by Martin Klapetek to branch > > frameworks. Erm, sorry, wrong review number in the commit. - Martin --

Re: Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113883/ --- (Updated Nov. 15, 2013, 9:10 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview

> On Nov. 15, 2013, 1:32 p.m., Aleix Pol Gonzalez wrote: > > Why do you need to drop the version? In similar cases we've been bumping to > > 5... > > Kevin Ottens wrote: > Yeah I'm surprised as well... OTOH that's a regular library, we don't > mention the version name for those (unlike for

Re: Review Request 113882: Make constructors in KMediaPlayer explicit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113882/#review43777 --- This review has been submitted with commit b89eb64156007b3cdf5

Re: Review Request 113881: Standardise d-pointer classes of kmediaplayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113881/#review43776 --- This review has been submitted with commit 805ce7a14f533350985

Re: Review Request 113882: Make constructors in KMediaPlayer explicit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113882/ --- (Updated Nov. 15, 2013, 9:03 p.m.) Status -- This change has been mar

Re: Review Request 113881: Standardise d-pointer classes of kmediaplayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113881/ --- (Updated Nov. 15, 2013, 9:03 p.m.) Status -- This change has been mar

Re: Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview

> On Nov. 15, 2013, 12:32 p.m., Aleix Pol Gonzalez wrote: > > Why do you need to drop the version? In similar cases we've been bumping to > > 5... > > Kevin Ottens wrote: > Yeah I'm surprised as well... OTOH that's a regular library, we don't > mention the version name for those (unlike fo

Re: Wrapping up about KI18n and UIC

> [: Aleix Pol :] > I have been going through the list looking for what we should we do when > it comes to .ui file generation and i18n. I am confused by that too. Stephen's projected solution seems to me more elegant in principle, but I couldn't quite get if (when) it would be able to do all that

Re: Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview

> On Nov. 15, 2013, 12:32 p.m., Aleix Pol Gonzalez wrote: > > Why do you need to drop the version? In similar cases we've been bumping to > > 5... > > Kevin Ottens wrote: > Yeah I'm surprised as well... OTOH that's a regular library, we don't > mention the version name for those (unlike fo

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

> On Nov. 15, 2013, 7:42 p.m., Kevin Ottens wrote: > > tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 124 > > > > > > Would make sense to change the lambda so that you'd pass 16 and 24 > > instead. It fee

Re: New Runtime Organization

On Friday 15 November 2013 11:40:09 Jonathan Riddell wrote: > I've completed the wiki page for runtime organisation with a list of > everything in kde-runtime. There's quite a few dusty corners here. > https://community.kde.org/Frameworks/Epics/New_Runtime_Organization > > This page duplicates som

Re: RFC Rules for installation of header files

On Friday 15 November 2013 15:01:03 Nicolás Alvarez wrote: > Would they be in a separate directory such as 'kde4support'? In a > case-insensitive file system you can't have both /usr/include/KF5/kio and > /usr/include/KF5/KIO... Yes, definitely what I had in mind. Regards. -- Kévin Ottens, http:/

Re: Review Request 113863: Remove WINCE specific cmake code paths

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/#review43763 --- tier3/kinit/src/kdeinit/CMakeLists.txt

Re: Review Request 113887: Deprecate KDE4_* KAuth macros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113887/#review43762 --- Looks fine to me, but I'd rather have a second pair of eyes loo

Re: Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview

> On Nov. 15, 2013, 12:32 p.m., Aleix Pol Gonzalez wrote: > > Why do you need to drop the version? In similar cases we've been bumping to > > 5... Yeah I'm surprised as well... OTOH that's a regular library, we don't mention the version name for those (unlike for executables like kded) - Kev

Re: Review Request 113881: Standardise d-pointer classes of kmediaplayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113881/#review43758 --- Ship it! Ship It! - Kevin Ottens On Nov. 15, 2013, 12:20 p.

Re: Review Request 113882: Make constructors in KMediaPlayer explicit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113882/#review43760 --- Ship it! Ship It! - Kevin Ottens On Nov. 15, 2013, 12:21 p.

Re: Review Request 113860: Improve dependency specification in karchive

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113860/#review43756 --- Ship it! Ship It! - Kevin Ottens On Nov. 14, 2013, 2:37 p.m

Re: Review Request 113862: Improve dependency specification in kcodecs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113862/#review43757 --- Ship it! Ship It! - Kevin Ottens On Nov. 14, 2013, 3:01 p.m

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/#review43755 --- Ship it! I propose a couple tiny improvements. Do what you wan

Re: Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

> On Nov. 11, 2013, 5:45 p.m., David Faure wrote: > > Thanks for implementing that. Indeed the TODO didn't mean adding a method > > to QApplication, but it was about the member that was there in qt4, and > > that is now in QXcbConnection. > > > > The optional dependency on QtGui breaks the rul

New Runtime Organization

I've completed the wiki page for runtime organisation with a list of everything in kde-runtime. There's quite a few dusty corners here. https://community.kde.org/Frameworks/Epics/New_Runtime_Organization This page duplicates some of http://community.kde.org/Plasma/PW2Todo Please have a look ov

Re: KDE workspace users

Looks like this duplicates some of http://community.kde.org/Plasma/PW2Todo I'll merge them together sometime Jonathan On Thu, Nov 14, 2013 at 06:50:35PM +, Jonathan Riddell wrote: > > With KDE Frameworks taking shape and sceenshots of Plasma 2 starting > to appear it's worth looking at what

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

> On Nov. 10, 2013, 6:08 p.m., Patrick von Reth wrote: > > please use winsock2.h instead of winsock.h > > Kevin Ottens wrote: > Alexander? Any chance to see this comment addressed? Oops somehow didn't see that comment. Sure I will fix it right away. Any other objections or can I commit aft

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

> On Nov. 10, 2013, 5:08 p.m., Patrick von Reth wrote: > > please use winsock2.h instead of winsock.h Alexander? Any chance to see this comment addressed? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://gi

Re: Review Request 113503: make dbus dependency optional in JobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/#review43742 --- Any chance to see Stephen's comments addressed or this patch is

Re: Review Request 113863: Remove WINCE specific cmake code paths

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/ --- (Updated Nov. 15, 2013, 5:35 p.m.) Review request for Build System and KDE

Review Request 113887: Deprecate KDE4_* KAuth macros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113887/ --- Review request for Build System and KDE Frameworks. Repository: kdelibs

Re: RFC Rules for installation of header files

On Fri, Nov 15, 2013 at 5:24 PM, Aurélien Gâteau wrote: > On Thu, 14 Nov 2013 17:55:42 +0100, Kevin Ottens wrote: > >> On Thursday 14 November 2013 18:40:04 Aurélien Gâteau wrote: >> >>> Looks like we have an agreement then. Let me recap: >>> >>> # Installation dir >>> >>> All header files are in

Re: RFC Rules for installation of header files

El viernes, 15 de noviembre de 2013, Kevin Ottens escribió: > On Friday 15 November 2013 17:24:00 Aurélien Gâteau wrote: > > On Thu, 14 Nov 2013 17:55:42 +0100, Kevin Ottens wrote: > > > On Thursday 14 November 2013 18:40:04 Aurélien Gâteau wrote: > > >> Looks like we have an agreement then. Let m

Re: RFC Rules for installation of header files

On Friday 15 November 2013 17:24:00 Aurélien Gâteau wrote: > On Thu, 14 Nov 2013 17:55:42 +0100, Kevin Ottens wrote: > > On Thursday 14 November 2013 18:40:04 Aurélien Gâteau wrote: > >> Looks like we have an agreement then. Let me recap: > >> > >> # Installation dir > >> > >> All header files are

Re: RFC Rules for installation of header files

On Thu, 14 Nov 2013 17:55:42 +0100, Kevin Ottens wrote: On Thursday 14 November 2013 18:40:04 Aurélien Gâteau wrote: Looks like we have an agreement then. Let me recap: # Installation dir All header files are installed in $PREFIX/include/KF5/$Framework. This includes 'k' prefixed headers like

Build failed in Jenkins: plasma-framework_master_qt5 #905

See Changes: [aleixpol] Improve porting scripts [aleixpol] Iterate over the cmake scripts [aleixpol] Code cleanup [aleixpol] Remove unused variables from the cmake scripts -- [...truncat

Re: Wrapping up about KI18n and UIC

On Friday 15 November 2013 16:28:10 Stephen Kelly wrote: > Aleix Pol wrote: > > I see that Stephen Kelly has been doing some work on Qt and cmake to make > > it possible to integrate these properly, but also those changes will get > > in cmake 3 and Qt 5.3 which are not among our dependencies. > >

Re: Wrapping up about KI18n and UIC

Aleix Pol wrote: > I see that Stephen Kelly has been doing some work on Qt and cmake to make > it possible to integrate these properly, but also those changes will get > in cmake 3 and Qt 5.3 which are not among our dependencies. > CMake 3 will probably be out when releasing KI18n. Only KArchive

Wrapping up about KI18n and UIC

Hi, I have been going through the list looking for what we should we do when it comes to .ui file generation and i18n. I see that Stephen Kelly has been doing some work on Qt and cmake to make it possible to integrate these properly, but also those changes will get in cmake 3 and Qt 5.3 which are

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

> On Nov. 15, 2013, 1:31 p.m., Frank Reininghaus wrote: > > I'm not a KWindowSystem expert, but anyway, here are some more things that > > I noticed, and that might or might not be worth considering: > > > > > > 1. I think that you can simplify the code in > > KStartupInfo::Private::startups_

Re: Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113883/#review43729 --- Why do you need to drop the version? In similar cases we've bee

Re: Review Request 113882: Make constructors in KMediaPlayer explicit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113882/#review43728 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 15, 2013, 12

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/#review43727 --- I'm not a KWindowSystem expert, but anyway, here are some more

Re: Review Request 113881: Standardise d-pointer classes of kmediaplayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113881/#review43726 --- Looks good to me. Actually I don't really understand what the D

Re: kdoctools

On Fri, Nov 15, 2013 at 10:12 AM, Treeve Jelbert wrote: > I build all of kf5 as standalone modules > > kdoctools is now required when building kdewidgets, but the build fails > > FAILED: cd /usr/src/kdewidgets-5.x/build/docs/makekdewidgets && > /opt/qt5/bin/meinproc5 --stylesheet > /opt/qt5/share

Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113883/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113882: Make constructors in KMediaPlayer explicit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113882/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113881: Standardise d-pointer classes of kmediaplayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113881/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: KDE workspace users

Hey, On Thursday, November 14, 2013 18:50:35 Jonathan Riddell wrote: > With KDE Frameworks taking shape and sceenshots of Plasma 2 starting > to appear it's worth looking at what else will need to be done to > allow distros to ship it all. > > kde-runtime needs ported and there's a desire to move

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/ --- (Updated Nov. 15, 2013, 11:42 a.m.) Review request for KDE Frameworks. C

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

> On Nov. 15, 2013, 11:26 a.m., Frank Reininghaus wrote: > > I think the root cause of the corruption is that there is a "++it" in line > > 981, and then "remove_startup_info_internal( key )" in the following line, > > which calls QMap::remove(key). The latter invalidates all existing > > iter

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/#review43717 --- I think the root cause of the corruption is that there is a "++

Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

kdoctools

I build all of kf5 as standalone modules kdoctools is now required when building kdewidgets, but the build fails FAILED: cd /usr/src/kdewidgets-5.x/build/docs/makekdewidgets && /opt/qt5/bin/meinproc5 --stylesheet /opt/qt5/share/ksgmltools2/customization/kde-include-man.xsl --check /var/git/kde

Re: Review Request 113851: Unbreak kauth-policy-gen

> On Nov. 15, 2013, 9:38 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 00e39e1d2a8372c991e24383d7c45ea393522ca8 by Aurélien Gâteau to branch > > frameworks. > > Aurélien Gâteau wrote: > Decided to push it without a "ship it": it fixes the build of > kde-works

Re: Review Request 113851: Unbreak kauth-policy-gen

> On Nov. 15, 2013, 8:38 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 00e39e1d2a8372c991e24383d7c45ea393522ca8 by Aurélien Gâteau to branch > > frameworks. > > Aurélien Gâteau wrote: > Decided to push it without a "ship it": it fixes the build of > kde-works

Re: Review Request 113851: Unbreak kauth-policy-gen

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113851/#review43705 --- Ship it! Ship It! - Dario Freddi On Nov. 15, 2013, 8:38 a.m

Re: Review Request 113851: Unbreak kauth-policy-gen

> On Nov. 15, 2013, 9:38 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 00e39e1d2a8372c991e24383d7c45ea393522ca8 by Aurélien Gâteau to branch > > frameworks. Decided to push it without a "ship it": it fixes the build of kde-workspace on build.kde.org and a few peo

Re: Review Request 113851: Unbreak kauth-policy-gen

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113851/ --- (Updated Nov. 15, 2013, 8:38 a.m.) Status -- This change has been mar

Re: Review Request 113851: Unbreak kauth-policy-gen

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113851/#review43702 --- This review has been submitted with commit 00e39e1d2a8372c991e

KDE workspace users

With KDE Frameworks taking shape and sceenshots of Plasma 2 starting to appear it's worth looking at what else will need to be done to allow distros to ship it all. kde-runtime needs ported and there's a desire to move its various parts around https://community.kde.org/Frameworks/Epics/New_Runtim