----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/#review43755 -----------------------------------------------------------
Ship it! I propose a couple tiny improvements. Do what you want with them, otherwise ready to go in IMO. tier3/kconfigwidgets/src/kcolorschememanager.cpp <http://git.reviewboard.kde.org/r/113685/#comment31427> Nitpick: Feel free to ignore. I'd put the lambda on a separate line and get rid of the explicit bool declaration to make it more readable. tier3/kconfigwidgets/src/kcolorschememanager.cpp <http://git.reviewboard.kde.org/r/113685/#comment31428> Would make sense to change the lambda so that you'd pass 16 and 24 instead. It feels kinda weird otherwise. :-) You can still do (size / 2) - 1 in the lambda to prepare for the fillRect calls. - Kevin Ottens On Nov. 14, 2013, 5:50 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113685/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 5:50 a.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, Gilles Caulier, and > Boudewijn Rempt. > > > Repository: kdelibs > > > Description > ------- > > This class is inspired by functionality offered by e.g. Krita and > Digikam to allow the user to select a different color scheme for the > application. > > This manager simplifies this task and also ensures that the required > property on QApplication is set, so that a QStyle can pass the scheme > to the window manager/compositor for the windows of the application. > > @boud and @cgilles: please have a look whether this approach is sufficient > for your usecases in digkam and Krita. > > > Diffs > ----- > > tier3/kconfigwidgets/tests/kcolorschemedemo.cpp PRE-CREATION > tier3/kconfigwidgets/src/CMakeLists.txt 36ffca8 > tier3/kconfigwidgets/src/kcolorschememanager.h PRE-CREATION > tier3/kconfigwidgets/src/kcolorschememanager.cpp PRE-CREATION > tier3/kconfigwidgets/src/kcolorschememanager_p.h PRE-CREATION > tier3/kconfigwidgets/tests/CMakeLists.txt f66dc32 > > Diff: http://git.reviewboard.kde.org/r/113685/diff/ > > > Testing > ------- > > see demo application > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
