> On Nov. 15, 2013, 8:38 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 00e39e1d2a8372c991e24383d7c45ea393522ca8 by Aurélien Gâteau to branch > > frameworks. > > Aurélien Gâteau wrote: > Decided to push it without a "ship it": it fixes the build of > kde-workspace on build.kde.org and a few people looked at it without being > horrified.
Not a big deal, the patch wasn't really intrusive. OTOH, 24hrs is still a decent reaction time :) - Dario ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113851/#review43702 ----------------------------------------------------------- On Nov. 15, 2013, 8:38 a.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113851/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2013, 8:38 a.m.) > > > Review request for KDE Frameworks and Dario Freddi. > > > Repository: kdelibs > > > Description > ------- > > This is a two-commit patch, it fixes a build failure in > kde-workspace/kcontrol/dateandtime. > > > 1. make policy-gen accept a second argument pointing to the output file > > 2. Unbreak call to kauth-policy-gen > > Uses the new kauth-policy-gen syntax for extra safety (no empty output file > gets created in case of failure) > > Note: I haven't tested the Mac part of the code. Would be awesome if someone > could give it a try. > > > Diffs > ----- > > tier2/kauth/KAuthConfig.cmake.in 67eb7de > tier2/kauth/cmake/KAuthMacros.cmake 1ebc889 > tier2/kauth/src/CMakeLists.txt 68c7c37 > tier2/kauth/src/policy-gen/policy-gen.cpp b00e09f > > Diff: http://git.reviewboard.kde.org/r/113851/diff/ > > > Testing > ------- > > Still builds, kcmclock_actions.policy is correctly generated in > kde-workspace/kcontrol/dateandtime > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
