Re: QTimeZone merged for 5.2

2013-10-14 Thread Kevin Ottens
On Monday 14 October 2013 17:38:42 John Layt wrote: > On 14 October 2013 12:55, Kevin Ottens wrote: > > Giving it a closer look, I'm wondering: are you sure about this course of > > action? > > KDateTimeEdit is basically a KDateComboBox and a KTimeComboBox layouted > > together. So deprecating tho

Jenkins build is back to stable : kdelibs_stable #859

2013-10-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Bring kdewin back?

2013-10-14 Thread Kevin Ottens
Hello, On Monday 14 October 2013 18:42:02 Nicolás Alvarez wrote: > While trying to get KDE Frameworks to build on Windows, I found the > codebase of KDirWatch is full of Unixisms. I did a few improvements > towards getting it to build on Windows, but I'm now getting several > errors related to the

Re: Bring kdewin back?

2013-10-14 Thread Nicolás Alvarez
2013/10/14 Aleix Pol : > It's good to know that there's somebody out there taking care of kf5 on > windows. I'm unsure of what to say, though. Maybe you can come up with a > list of issues so that we can fix them? At least some output log could be > useful... I'm now working on http://community.kd

Re: Bring kdewin back?

2013-10-14 Thread Aleix Pol
On Mon, Oct 14, 2013 at 11:42 PM, Nicolás Alvarez wrote: > Hi, > > While trying to get KDE Frameworks to build on Windows, I found the > codebase of KDirWatch is full of Unixisms. I did a few improvements > towards getting it to build on Windows, but I'm now getting several > errors related to th

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/ --- (Updated Oct. 14, 2013, 10:56 p.m.) Status -- This change has been ma

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review41760 --- This review has been submitted with commit cf319d371bf211e63d8

Bring kdewin back?

2013-10-14 Thread Nicolás Alvarez
Hi, While trying to get KDE Frameworks to build on Windows, I found the codebase of KDirWatch is full of Unixisms. I did a few improvements towards getting it to build on Windows, but I'm now getting several errors related to the lack of symbolic links (such as no lstat). It's clear this code coul

Jenkins build became unstable: kdelibs_stable #858

2013-10-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-14 Thread Jeremy Whiting
> On Oct. 12, 2013, 10:43 a.m., David Faure wrote: > > knewstuff/KNewStuffConfig.cmake.in, line 4 > > > > > > why is kjs listed as a dependency here but not in the cmakelists.txt? Ah, the Config.cmake.in I copied f

Re: Review Request 113226: Cleanup kdirwatch includes.

2013-10-14 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113226/ --- (Updated Oct. 14, 2013, 4:11 p.m.) Status -- This change has been mar

Re: Review Request 113248: Cleanup KNotifyConfig

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 5:33 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/#review41750 --- Ship it! Good catch David! - Aleix Pol Gonzalez On Oct. 14,

Review Request 113248: Cleanup KNotifyConfig

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113247: Port KCompletion away from KStandardAction

2013-10-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113243: KMessageBox: Re-enable squeezed text for extreme situations

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113243/#review41746 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 14, 2013, 4:

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-10-14 Thread Chusslove Illich
> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Re: QTimeZone merged for 5.2

2013-10-14 Thread John Layt
On 14 October 2013 12:55, Kevin Ottens wrote: > Giving it a closer look, I'm wondering: are you sure about this course of > action? > KDateTimeEdit is basically a KDateComboBox and a KTimeComboBox layouted > together. So deprecating those two without deprecating KDateTimeEdit sounds > weird to me.

Re: Review Request 113240: Move KJsEmbed to tier3

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113240/ --- (Updated Oct. 14, 2013, 4:30 p.m.) Status -- This change has been mar

Re: Review Request 113240: Move KJsEmbed to tier3

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113240/#review41744 --- This review has been submitted with commit 5344e02ae20deaea435

Re: Review Request 113157: Remove Nepomuk dependency from kde4support

2013-10-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113157/ --- (Updated Oct. 14, 2013, 4:21 p.m.) Status -- This change has been dis

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113154/ --- (Updated Oct. 14, 2013, 4:21 p.m.) Status -- This change has been dis

Review Request 113243: KMessageBox: Re-enable squeezed text for extreme situations

2013-10-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113243/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

2013-10-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153/ --- (Updated Oct. 14, 2013, 4:16 p.m.) Status -- This change has been mar

Re: Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153/#review41741 --- This review has been submitted with commit af8deabf64506b4f3ee

Re: Review Request 113237: Move KInit to tier3

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113237/ --- (Updated Oct. 14, 2013, 4:15 p.m.) Status -- This change has been mar

Re: Review Request 113237: Move KInit to tier3

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113237/#review41740 --- This review has been submitted with commit bc43c8b20d21d6c06c6

Re: Review Request 113241: Move khtml java tests into the test directory

2013-10-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113241/ --- (Updated Oct. 14, 2013, 4:10 p.m.) Status -- This change has been mar

Re: Review Request 113241: Move khtml java tests into the test directory

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113241/#review41739 --- This review has been submitted with commit 1472061e9e203ae1d81

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-14 Thread Àlex Fiestas
> On Oct. 12, 2013, 4:57 p.m., David Faure wrote: > > kded/kbuildsycoca.cpp, line 84 > > > > > > Not called anymore with your commit. > > > > But I'm not sure we want to remove the feature... what's the pr

Re: Compiling Plasma-Framework with a QT5 compiled with -egl -opengl es2

2013-10-14 Thread nerdopolis
On Monday, October 14, 2013 02:38:46 PM kde-frameworks-devel-requ...@kde.org wrote: > Message: 3 > Date: Mon, 14 Oct 2013 16:40:03 +0200 > From: Martin Gr??lin > To: kde-frameworks-devel@kde.org > Subject: Re: Re: Compiling Plasma-Framework with a QT5 compiled with > -egl -opengl es2 > Mess

Re: Review Request 113237: Move KInit to tier3

2013-10-14 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113237/#review41736 --- Ship it! No test is breaking because of the patch, it looks go

Re: Review Request 113240: Move KJsEmbed to tier3

2013-10-14 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113240/#review41735 --- Ship it! Looks good, it compiles and all policies are done so

Re: QTimeZone merged for 5.2

2013-10-14 Thread John Layt
On 14 October 2013 12:55, Kevin Ottens wrote: > Giving it a closer look, I'm wondering: are you sure about this course of > action? > KDateTimeEdit is basically a KDateComboBox and a KTimeComboBox layouted > together. So deprecating those two without deprecating KDateTimeEdit sounds > weird to me

Re: Review Request 113241: Move khtml java tests into the test directory

2013-10-14 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113241/#review41734 --- Ship it! Makes sense to have all this tests into their own jav

Review Request 113241: Move khtml java tests into the test directory

2013-10-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113241/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Re: Compiling Plasma-Framework with a QT5 compiled with -egl -opengl es2

2013-10-14 Thread Martin Gräßlin
On Friday 11 October 2013 07:32:47 nerdopolis wrote: > On Thursday, October 10, 2013 12:00:04 PM kde-frameworks-devel- requ...@kde.org wrote: > > > Is this a bug I should file? > > > > no need to file a bug about it. It's code I have written and I know that > > it > > currently requires glx. The p

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-14 Thread Vishesh Handa
> On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote: > > -1 > > > > I disagree with the removal, OK they get deprecated in KDE4... but it's > > been done only recently (the patch isn't even in yet). We still have a > > couple of users for those classes and it would be one more breakage on our >

Re: Review Request 113238: Remove set _LIBRARIES calls in root CMakeLists.txt

2013-10-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113238/ --- (Updated Oct. 14, 2013, 2:07 p.m.) Status -- This change has been mar

Re: Review Request 113238: Remove set _LIBRARIES calls in root CMakeLists.txt

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113238/#review41729 --- This review has been submitted with commit 884a0ff9a25973be6d0

Review Request 113240: Move KJsEmbed to tier3

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113240/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113197: KMessageBox: Factorize code between regular and *WId functions

2013-10-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113197/ --- (Updated Oct. 14, 2013, 2 p.m.) Status -- This change has been marked

Re: Review Request 113197: KMessageBox: Factorize code between regular and *WId functions

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113197/#review41728 --- This review has been submitted with commit d16abdc34489e19d671

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

2013-10-14 Thread Mark Gaiser
> On Oct. 14, 2013, 12:52 p.m., David Faure wrote: > > tier1/kcoreaddons/src/lib/jobs/kjob.h, line 372 > > > > > > I wonder if the Qt/kdelibs coding style has something about indentation > > of pre-processor dire

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

2013-10-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/#review41714 --- Ship it! tier1/kcoreaddons/src/lib/jobs/kjob.h

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

2013-10-14 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/ --- (Updated Oct. 14, 2013, 12:46 p.m.) Review request for KDE Frameworks, kde

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-10-14 Thread Stephen Kelly
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-14 Thread Mark Gaiser
> On Oct. 14, 2013, 6:47 a.m., Kevin Ottens wrote: > > Why do it just for result and not finished, suspended, resumed? We end up > > with both mechanisms for private signals in the same header otherwise. Will do. Will update this patch shortly. - Mark ---

Re: Review Request 113197: KMessageBox: Factorize code between regular and *WId functions

2013-10-14 Thread Aurélien Gâteau
> On Oct. 14, 2013, 11 a.m., Kevin Ottens wrote: > > Looks good indeed. > > > > Maybe an idea for an improvement: What about having the internal methods > > use a QScopedPointer on the dialog? It'd avoid the delete before the > > return, and if someone modifies the file later on adding more su

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-10-14 Thread Chusslove Illich
> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-10-14 Thread Stephen Kelly
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-10-14 Thread Chusslove Illich
> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-10-14 Thread Stephen Kelly
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-14 Thread Kevin Ottens
> On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote: > > -1 > > > > I disagree with the removal, OK they get deprecated in KDE4... but it's > > been done only recently (the patch isn't even in yet). We still have a > > couple of users for those classes and it would be one more breakage on our >

Re: Review Request 113046: Move kconfigwidgets to tier3

2013-10-14 Thread Kevin Ottens
On Wednesday 02 October 2013 15:09:35 Aurélien Gâteau wrote: > On Wednesday 02 October 2013 14:48:45 Stephen Kelly wrote: > > Aurélien Gâteau wrote: > > > On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote: > > >> Aurélien Gâteau wrote: > > >> > I don't have any strong opinion on this, but i

Re: Failing Tests in Kross

2013-10-14 Thread Vishesh Handa
Minor update - Sebastian Sauer's email does not seem to be working. I've tried contacting him via twitter. Lets see. If anyone knows how to contact him, please inform me. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-14 Thread Vishesh Handa
> On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote: > > -1 > > > > I disagree with the removal, OK they get deprecated in KDE4... but it's > > been done only recently (the patch isn't even in yet). We still have a > > couple of users for those classes and it would be one more breakage on our >

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-10-14 Thread Chusslove Illich
> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Review Request 113237: Move KInit to tier3

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113237/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-10-14 Thread Stephen Kelly
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-10-14 Thread Aleix Pol Gonzalez
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Re: QTimeZone merged for 5.2

2013-10-14 Thread Kevin Ottens
Hello, On Thursday 03 October 2013 18:15:22 John Layt wrote: > KDateTimeEdit > - My new widget to replace many local widgets, added in last kdelibs release > - Can replace KDateComboBox, KTimeComboBox, api is almost the same - Not > used anywhere!?! > - API uses QDate, QTime, KDateTime, KCalendarS

Re: Review Request 113238: Remove set _LIBRARIES calls in root CMakeLists.txt

2013-10-14 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113238/#review41699 --- Ship it! Also consider (separately) removing the _LIBRARIES va

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-10-14 Thread Stephen Kelly
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Review Request 113238: Remove set _LIBRARIES calls in root CMakeLists.txt

2013-10-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113238/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1429

2013-10-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_frameworks_qt5 #1428

2013-10-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-14 Thread Kevin Ottens
> On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote: > > -1 > > > > I disagree with the removal, OK they get deprecated in KDE4... but it's > > been done only recently (the patch isn't even in yet). We still have a > > couple of users for those classes and it would be one more breakage on our >

Re: Review Request 113182: Remove all the versioned classes of KCategoryDrawer.

2013-10-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113182/ --- (Updated Oct. 14, 2013, 10:24 a.m.) Status -- This change has been ma

Re: Review Request 113182: Remove all the versioned classes of KCategoryDrawer.

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113182/#review41695 --- This review has been submitted with commit 9cda5f809335481dd26

Re: Review Request 113182: Remove all the versioned classes of KCategoryDrawer.

2013-10-14 Thread Kevin Ottens
> On Oct. 14, 2013, 8:27 a.m., Kevin Ottens wrote: > > tier1/itemviews/src/kcategorydrawer.h, line 228 > > > > > > Wouldn't a typedef be enough? OK... would loose the DEPRECATED effect > > though... > > David Ed

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-14 Thread Vishesh Handa
> On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote: > > -1 > > > > I disagree with the removal, OK they get deprecated in KDE4... but it's > > been done only recently (the patch isn't even in yet). We still have a > > couple of users for those classes and it would be one more breakage on our >

Re: Review Request 113182: Remove all the versioned classes of KCategoryDrawer.

2013-10-14 Thread David Edmundson
> On Oct. 14, 2013, 8:27 a.m., Kevin Ottens wrote: > > tier1/itemviews/src/kcategorydrawer.h, line 228 > > > > > > Wouldn't a typedef be enough? OK... would loose the DEPRECATED effect > > though... I tried a ty

Re: Review Request 113226: Cleanup kdirwatch includes.

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113226/#review41687 --- Ship it! Ship It! - Kevin Ottens On Oct. 13, 2013, 5:20 a.m

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review41686 --- knewstuff/CMakeLists.txt

Re: Review Request 113199: KHTML: KComponentData -> KAboutData

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113199/#review41685 --- This review has been submitted with commit 1ad41d1c158091be9e7

Re: Review Request 113199: KHTML: KComponentData -> KAboutData

2013-10-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113199/ --- (Updated Oct. 14, 2013, 9:06 a.m.) Status -- This change has been mar

Re: Review Request 113157: Remove Nepomuk dependency from kde4support

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113157/#review41684 --- Ship it! Ship It! - Kevin Ottens On Oct. 7, 2013, 5:25 p.m.

Re: Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113158/#review41683 --- I'm not sold on bastardizing QErrorMessage for that feature. Th

Re: Review Request 113197: KMessageBox: Factorize code between regular and *WId functions

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113197/#review41682 --- Looks good indeed. Maybe an idea for an improvement: What abou

Re: Review Request 113199: KHTML: KComponentData -> KAboutData

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113199/#review41680 --- Ship it! Ship It! - Kevin Ottens On Oct. 11, 2013, 12:16 p.

Re: Review Request 113182: Remove all the versioned classes of KCategoryDrawer.

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113182/#review41679 --- tier1/itemviews/src/kcategorydrawer.h

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-14 Thread Kevin Ottens
> On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote: > > -1 > > > > I disagree with the removal, OK they get deprecated in KDE4... but it's > > been done only recently (the patch isn't even in yet). We still have a > > couple of users for those classes and it would be one more breakage on our >

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113154/#review41676 --- -1 I disagree with the removal, OK they get deprecated in KDE4

Re: Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153/#review41675 --- Yes, should have a note in KDE5Porting before going in. - Kevi

KF5 Update Meeting 2013-w42 Reminder

2013-10-14 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc