----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/#review41750 -----------------------------------------------------------
Ship it! Good catch David! - Aleix Pol Gonzalez On Oct. 14, 2013, 5:04 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113247/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2013, 5:04 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Fix depends in KCompletion > > KCompletion cannot use KStandardAction which is from kconfigwidgets in tier3 > > > Diffs > ----- > > tier2/kcompletion/CMakeLists.txt 8c34bd6 > tier2/kcompletion/KCompletionConfig.cmake.in 46647d1 > tier2/kcompletion/src/CMakeLists.txt d2b7602 > tier2/kcompletion/src/klineedit.cpp 2f70935 > > Diff: http://git.reviewboard.kde.org/r/113247/diff/ > > > Testing > ------- > > Compiled in source > Tried compiling standalone (it builds, but has a linker fail on something > unrelated) > Ran klineedittest and checked combobox was the same. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
