> On Oct. 12, 2013, 10:43 a.m., David Faure wrote: > > knewstuff/KNewStuffConfig.cmake.in, line 4 > > <http://git.reviewboard.kde.org/r/112730/diff/3/?file=200166#file200166line4> > > > > why is kjs listed as a dependency here but not in the cmakelists.txt?
Ah, the Config.cmake.in I copied from had KJS, so should I list the public dependencies in the Config.cmake or the private ones? or both? - Jeremy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review41599 ----------------------------------------------------------- On Oct. 9, 2013, 2:24 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112730/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2013, 2:24 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, David Faure, and > Chusslove Illich. > > > Repository: kdelibs > > > Description > ------- > > This makes it so I can mkdir build; cd build; cmake ../; make install from > knewstuff sources. > It's still using KDE4_KIO_LIBS and find_package(KIO) since not all of the kio > libraries have been split out apparently. > I'm not sure why sources had to be changed, but I had to add includes of > klocalizedstring where we didn't need them before somehow. > > > Diffs > ----- > > knewstuff/CMakeLists.txt 8ee3653c92692d606a2ff6d1fa69d0d8deb5439a > knewstuff/KNewStuffConfig.cmake.in PRE-CREATION > knewstuff/src/CMakeLists.txt 5bdf0f6ee619751d66ec48dc7516a73cfe89a8c0 > knewstuff/src/downloaddialog.cpp 3294c7c04c7879320fc0949db0310868bd6fa4fa > knewstuff/src/downloadwidget.cpp 64b7673d67b4e2f15007fc1a3f57d3da844d1dc0 > knewstuff/src/ui/entrydetailsdialog.cpp > 65b75d79941d9026f368f82c7b6df91d754e0925 > knewstuff/src/uploaddialog.cpp dbde573e8c3a477755c8c866d0ca1fccd1a35729 > > Diff: http://git.reviewboard.kde.org/r/112730/diff/ > > > Testing > ------- > > It builds and installs. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
