Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/ --- (Updated Sept. 13, 2013, 11:38 p.m.) Review request for KDE Frameworks and

Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/ --- Review request for KDE Frameworks and David Faure. Description --- In

Jenkins build became unstable: kdelibs_frameworks_qt5 #1195

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112715: Move KI18n to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/ --- (Updated Sept. 13, 2013, 6:30 p.m.) Status -- This change has been ma

Re: Review Request 112715: Move KI18n to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/#review39988 --- This review has been submitted with commit bdb20124230829b6382

Re: Review Request 112717: Start adopting QCollator

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/ --- (Updated Sept. 13, 2013, 5:55 p.m.) Review request for KDE Frameworks, Fra

Re: Review Request 112717: Start adopting QCollator

> On Sept. 13, 2013, 5:32 p.m., Mark Gaiser wrote: > > That's a very impressive part on the porting side! Thank you very much for > > taking care here. > > > > I have "some" experience in optimizing this function (understatement ^_^) > > and know very well that even a tiny change in performace

Re: Review Request 112715: Move KI18n to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/#review39981 --- Ship it! Ship It! - Chusslove Illich On Sept. 13, 2013, 3:1

Re: Review Request 112717: Start adopting QCollator

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review39986 --- That's a very impressive part on the porting side! Thank you ve

Review Request 112717: Start adopting QCollator

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/ --- Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau.

Re: Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112673/#review39985 --- This review has been submitted with commit e8e401e317c4bd526a8

Re: Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112673/ --- (Updated Sept. 13, 2013, 5:25 p.m.) Status -- This change has been ma

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 3:33 p.m.) Status -- This change has been di

Re: Review Request 112685: Fix KWindowSystem::setMainWindow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/ --- (Updated Sept. 13, 2013, 3:25 p.m.) Status -- This change has been ma

Re: Review Request 112685: Fix KWindowSystem::setMainWindow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/#review39978 --- This review has been submitted with commit dbeae027d76c0215aea

Review Request 112716: Prepare itemviews for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112716/ --- Review request for KDE Frameworks. Description --- - Use REQUIRED_QT_

Re: Review Request 112556: Move itemviews to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112556/ --- (Updated Sept. 13, 2013, 5:02 p.m.) Status -- This change has been di

Fwd: Binary incompatible change in dev branch.

--- Forwarded message (begin) Subject: Binary incompatible change in dev branch. From: Stephen Kelly Date: Fri, 13 Sep 2013 16:52:14 +0200 Newsgroup: gmane.comp.lib.qt.devel Hello, Two changes which are binary incompatible compared to the state before them were just merged to dev

Re: Templates for frameworks CMake files

On Friday 13 September 2013 11:30:32 Aurélien Gâteau wrote: > Hi, > > I have been playing around with itemviews CMake files and put together some > templates for the top level CMakeLists.txt and *Config.cmake.in. You can > find them attached there. Any one against me adding those to the > reposito

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1192

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/ --- (Updated Sept. 13, 2013, 1:42 p.m.) Status -- This change has been ma

Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/#review39967 --- This review has been submitted with commit 0be299aa017f717926f

Re: Review Request 112685: Fix KWindowSystem::setMainWindow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/#review39966 --- Ship it! Looks good to me. - Martin Gräßlin On Sept. 12, 20

Review Request 112715: Move KI18n to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/ --- Review request for KDE Frameworks and Chusslove Illich. Description --

Jenkins build became unstable: kdelibs_frameworks_qt5 #1191

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1189

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112710: Move KIO::NetAccess to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/#review39955 --- This review has been submitted with commit 4cb177ae494e04a250b

Re: Review Request 112710: Move KIO::NetAccess to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/ --- (Updated Sept. 13, 2013, 11:42 a.m.) Status -- This change has been m

Build failed in Jenkins: kdelibs_frameworks_qt5 #1188

See Changes: [aleixpol] Move KNotifications to tier2 -- [...truncated 3959 lines...] [ 27%] Building CXX object tier2/kauth/src/CMakeFiles/KAuth.dir/kauthaction.cpp.o [ 27%] Building CXX objec

Re: Review Request 112696: Moves KNotifications to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112696/#review39954 --- This review has been submitted with commit 3359a8cbe993159d830

Re: Review Request 112710: Move KIO::NetAccess to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/#review39953 --- Ship it! Ship It! - David Faure On Sept. 13, 2013, 11:21 a.

Review Request 112710: Move KIO::NetAccess to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/ --- Review request for KDE Frameworks and David Faure. Description --- Mo

Re: Dependency specifications

On Friday 13 September 2013 13:17:47 Aleix Pol wrote: > Well, but in that case you'll maybe want to find QtGui, QtWidgets or > KF5::AwesomeTests. Ah yes, true, manual tests can have more deps sometimes. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Fra

Re: Review Request 112696: Moves KNotifications to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112696/#review39952 --- Ship it! Ship It! - David Faure On Sept. 12, 2013, 4:25 p.m

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39951 --- Ship it! Looks good. Remember to adjust the commit log if it s

Re: Dependency specifications

On Fri, Sep 13, 2013 at 1:17 PM, David Faure wrote: > On Friday 13 September 2013 13:03:29 Aleix Pol wrote: > > On Fri, Sep 13, 2013 at 9:43 AM, David Faure wrote: > > > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > > > > I'd say that all Qt dependencies in the module should be defin

Re: Review Request 112699: Reorganize KDocTools cmake code

> On Sept. 12, 2013, 7:57 p.m., Stephen Kelly wrote: > > > Move the finders from kdoctools/CMakeLists.txt to > > > kdoctools/src/CMakeLists.txt. > > > This should make it possible to move kdoctools to its own tier. > > > > Why is this necessary to move it to its own tier? That wouldn't be an >

Re: Review Request 112699: Reorganize KDocTools cmake code

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112699/ --- (Updated Sept. 13, 2013, 11:15 a.m.) Review request for KDE Frameworks and

Re: Dependency specifications

On Friday 13 September 2013 13:03:29 Aleix Pol wrote: > On Fri, Sep 13, 2013 at 9:43 AM, David Faure wrote: > > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > > > I'd say that all Qt dependencies in the module should be defined only > > > > once > > > > > in the root CMakeLists.txt. A

Re: Review Request 112700: Prepare KI18n to move to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/#review39948 --- This review has been submitted with commit 9c0e739a866eefd5aa9

Re: Review Request 112700: Prepare KI18n to move to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/ --- (Updated Sept. 13, 2013, 11:05 a.m.) Status -- This change has been m

Re: Dependency specifications

On Fri, Sep 13, 2013 at 9:43 AM, David Faure wrote: > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > > I'd say that all Qt dependencies in the module should be defined only > once > > in the root CMakeLists.txt. Actually this should be the only file with > > "find_package" calls. > > A

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/ --- (Updated Sept. 13, 2013, 11:01 a.m.) Review request for KDE Frameworks.

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

> On Sept. 13, 2013, 7:35 a.m., David Faure wrote: > > See the docu inside kdelibs-frameworks/superbuild/CMakeLists.txt. > > > > This is preparation for future splitting. The variables are necessary for > > that, for now, as I understand it. > > > > Let's finish moving everything into separate

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 10:33 a.m.) Review request for Build System, KDE

Templates for frameworks CMake files

Hi, I have been playing around with itemviews CMake files and put together some templates for the top level CMakeLists.txt and *Config.cmake.in. You can find them attached there. Any one against me adding those to the repository? Auréliencmake_minimum_required(VERSION 2.8.11) project(FooBar)

Re: Review Request 112681: Tests for KPluginTrader and friends

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/#review39943 --- staging/kservice/autotests/pluginlocatortest.cpp

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39942 --- staging/kcompletion/src/klineedit.cpp

Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/#review39940 --- Ship it! Much simpler indeed - David Faure On Sept. 12, 201

Re: Review Request 112680: KPluginTrader: QPluginLoader/metadata-based querying of Plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112680/#review39939 --- Ship it! ... after these docu fixes staging/kservice/src/plu

Re: Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112673/#review39938 --- Ship it! Ah right. We exported it, but if the _p.h isn't insta

Re: Dependency specifications

On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > I'd say that all Qt dependencies in the module should be defined only once > in the root CMakeLists.txt. Actually this should be the only file with > "find_package" calls. And I disagree. If you build the framework with unittests disabled (

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39936 --- See the docu inside kdelibs-frameworks/superbuild/CMakeLists.tx

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39935 --- Ship it! ... after fixing the last two small issues. staging

Re: Review Request 112556: Move itemviews to tier2

On Tuesday 10 September 2013 21:46:45 Christoph Feck wrote: > So what about renaming itemmodels/itemviews to kitemmodels/kitemviews, or is > it too late for that? I'd be fine with that. There are indeed other item models and item views than the ones provided by KF5, so a k makes sense. Stephen,