Re: Questions on module splitting

Hello, On Tuesday 27 August 2013 19:03:56 Aleix Pol wrote: > I've started looking into splitting KUnitConversion, there's some things > I'd like to discuss: > > - There's some weird constructions > regarding KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION. This came from the KDE Platfor

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Aug. 27, 2013, 9:21 p.m.) Review request for KDE Frameworks. De

Re: Updating CMake requirement to 2.8.12 RC 1

On Wed, Aug 28, 2013 at 2:54 AM, Alexander Neundorf wrote: > On Friday 23 August 2013, Ben Cooksley wrote: >> On Fri, Aug 23, 2013 at 7:14 PM, David Faure wrote: >> > On Friday 23 August 2013 06:51:23 Martin Graesslin wrote: >> >> Given that it's already lots of work to keep up with the constant

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1097

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[kdelibs/frameworks] tier1: Find Qt dependendency in tier1 frameworks.

Git commit 92acd71c769d46d479152356783e21a03bda25e2 by Stephen Kelly. Committed on 27/08/2013 at 17:14. Pushed by skelly into branch 'frameworks'. Find Qt dependendency in tier1 frameworks. This way, find_package(KArchive REQUIRED) now works and is enough to be able to use the KF5::KArchive ta

Questions on module splitting

Hi, I've started looking into splitting KUnitConversion, there's some things I'd like to discuss: - There's some weird constructions regarding KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION. Especially a trade off between depending on QtNetwork or using kioclient to download a specific f

Re: Review Request 112151: Use components in FindXCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review38751 --- You wrote that it allows having some components be optional, an

Re: kdelibs fails

Christoph Feck wrote: > On Tuesday 27 August 2013 17:12:08 Stephen Kelly wrote: >> Christoph Feck wrote: >> > /local/qt5/include/QtCore/qhash.h:857:31: error: within this >> > context while (bucketIterator != it) { >> > ^ >> >> A recent commit in qtbase was buggy and introduced this error. > > O

KF5 Update Meeting Minutes 2013-w35

Hello everyone, This is the minutes of the Week 35 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, apol, d_ed, dfaure, mck182, mgraesslin, sebas, shadeslayer, teo, vHanda, wojtask9 and myself. Announcement: * I will be away three weeks, dfaure w

Re: Updating CMake requirement to 2.8.12 RC 1

On Tuesday 20 August 2013, Stephen Kelly wrote: > Hello, > > CMake 2.8.12 RC 1 was released a few hours ago: > > http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/47443 > > Updating to that will allow us to get on the home straight with regard to > our buildsystem files. > > For

Re: kdelibs fails

On Tuesday 27 August 2013 17:12:08 Stephen Kelly wrote: > Christoph Feck wrote: > > /local/qt5/include/QtCore/qhash.h:857:31: error: within this > > context while (bucketIterator != it) { > > ^ > > A recent commit in qtbase was buggy and introduced this error. Oh dear, and I was sure it was my bu

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

> On Aug. 27, 2013, 1:47 p.m., Albert Astals Cid wrote: > > Question is, why should it go into this function and not say into others > > that also accept a language string? Maybe this should go there somewhere as > > a static helper function? I mean yes, we are using this function from > > som

Re: kdelibs fails

Christoph Feck wrote: > /local/qt5/include/QtCore/qhash.h:857:31: error: within this context > while (bucketIterator != it) { > ^ A recent commit in qtbase was buggy and introduced this error. https://codereview.qt-project.org/#change,63901 Thanks, Steve. ___

Re: Updating CMake requirement to 2.8.12 RC 1

On Friday 23 August 2013, Ben Cooksley wrote: > On Fri, Aug 23, 2013 at 7:14 PM, David Faure wrote: > > On Friday 23 August 2013 06:51:23 Martin Graesslin wrote: > >> Given that it's already lots of work to keep up with the constant > >> breakage due to changes in frameworks the outlook of also h

Re: I'm out

On Friday 23 August 2013, Alexander Neundorf wrote: ... > Another nice thing of a standard variable would have been that those > packages could be made more easy available to non-cmake buildsystems. > Two years ago after Randa I added an option --find-package JPEG to cmake, > so you can call cmake

Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112311/ --- Review request for KDE Frameworks. Description --- Title says it all

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

On Monday 26 August 2013 13:48:16 Albert Astals Cid wrote: >QStandardPaths::standardLocations(QStandardPaths::GenericDataLocation) + > QString::fromLatin1("locale/"); <-- note this does not compile :D QStandardPaths::locate(QStandardPaths::GenericDataLocation, "locale", QStandardPaths::Locate

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112292/#review38740 --- Question is, why should it go into this function and not say in

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112292/ --- (Updated Aug. 27, 2013, 1:14 p.m.) Review request for KDE Frameworks, Albe

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112292/ --- (Updated Aug. 27, 2013, 1:08 p.m.) Review request for KDE Frameworks, Albe

Re: Review Request 112302: Make export include in KIO consistent

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112302/#review38734 --- This review has been submitted with commit d56e4be5944caf31f83

Re: Review Request 112302: Make export include in KIO consistent

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112302/ --- (Updated Aug. 27, 2013, 12:17 p.m.) Status -- This change has been ma

Re: Review Request 112177: Split URL drop functionality from KLineEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112177/ --- (Updated Aug. 27, 2013, 11:49 a.m.) Review request for KDE Frameworks and

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

> On Aug. 26, 2013, 6:25 p.m., Albert Astals Cid wrote: > > if you want to see the language codes we have, they are listed in > > http://websvn.kde.org/trunk/l10n-kde4/ > > > > To be honest i don't see why we need conversion between uiLanguages and > > here since uiLanguages returns what we i

Re: Review Request 112217: copy KStyle as K4Style in KDE4Support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112217/ --- (Updated Aug. 27, 2013, 9:13 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

> On Aug. 26, 2013, 7:08 a.m., Kevin Ottens wrote: > > tier1/sonnet/src/ui/spellcheckdecorator.h, line 40 > > > > > > I would rather have a setter than an extra ctor parameter if possible. > > Since we already hav

Re: Review Request 112302: Make export include in KIO consistent

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112302/#review38720 --- Ship it! Ship It! - Kevin Ottens On Aug. 26, 2013, 8:26 p.m

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

> On Aug. 26, 2013, 6:25 p.m., Albert Astals Cid wrote: > > if you want to see the language codes we have, they are listed in > > http://websvn.kde.org/trunk/l10n-kde4/ > > > > To be honest i don't see why we need conversion between uiLanguages and > > here since uiLanguages returns what we i

Re: Review Request 112229: Port bunch of POSIX calls to qplatformdefs.h calls

> On Aug. 26, 2013, 6:47 a.m., Kevin Ottens wrote: > > Looks OK. Assuming you ran the whole kdelibs test suite and it all passed. > > Martin Klapetek wrote: > Actually running the whole suite I have 6 tests failing with no patches > and a clean build (running the tests as described in the w

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/ --- (Updated Aug. 27, 2013, 8:41 a.m.) Status -- This change has been mar

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/#review38715 --- This review has been submitted with commit bd132d22511ad4ae3f5

Re: Review Request 112303: KIO: Move krun tests to staging/kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112303/ --- (Updated Aug. 27, 2013, 8:42 a.m.) Status -- This change has been mar

Re: Review Request 112303: KIO: Move krun tests to staging/kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112303/#review38716 --- This review has been submitted with commit 5248290f5dda0106333

Re: Smart D-Ptr in KCoreAddons

> Heh? Every single class in Qt has a d ptr. > > > How many people write libs and care about ABI > > All of Qt itself, and all the libs based on Qt... Well, I don't expect Qt to switch the whole code-base to it. I meant Qt users, but if you think it might be worth a try... > Yeah, ask him (no

Re: Smart D-Ptr in KCoreAddons

On Tuesday 27 August 2013 09:08:24 Ivan Čukić wrote: > > Well, if it's so useful, why would it be an over-stretch to have it in Qt? > > Maybe it's just me, but I don't see d-ptr idiom as something ubiquitous in > C++/Qt world, as it is in KDE. Heh? Every single class in Qt has a d ptr. > How ma

Re: Smart D-Ptr in KCoreAddons

> Well, if it's so useful, why would it be an over-stretch to have it in Qt? Maybe it's just me, but I don't see d-ptr idiom as something ubiquitous in C++/Qt world, as it is in KDE. How many people write libs and care about ABI, if libstdc++ doesn't (for example, gcc 4.7 has a different abi fo

Re: Review Request 112303: KIO: Move krun tests to staging/kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112303/#review38711 --- Ship it! Thanks! If you (or anyone else) is looking for KF5 t