----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review38751 -----------------------------------------------------------
You wrote that it allows having some components be optional, and others be required. However, you don't seem to follow the advice here to do that: http://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/readme.txt;h=9dc1c6ab3976d259b2870ae196e6fbb994a1a3b4;hb=236133e7#l133 and I don't see the how the implementation would allow what you describe. find-modules/FindXCB.cmake <http://git.reviewboard.kde.org/r/112151/#comment28610> I don't think 'NAMES lib' is correct. That will search for a lib named 'lib' with certain patterns, eg liblib.so. You should probably just remove the 'NAMES lib' part. The variable name here should be _LIBRARY. find-modules/FindXCB.cmake <http://git.reviewboard.kde.org/r/112151/#comment28611> I think this message should report about _DIR. find-modules/FindXCB.cmake <http://git.reviewboard.kde.org/r/112151/#comment28609> Shouldn't this be _DIRS instead? - Stephen Kelly On Aug. 19, 2013, 9:39 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112151/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2013, 9:39 a.m.) > > > Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. > > > Description > ------- > > Instead of finding all or nothing from XCB it becomes components aware. So a > user can just specify which XCB components it needs and compilation doesn't > fail if a not-needed unrelated component is not found. It also allows to have > some components as required and some as optional. > > > Diffs > ----- > > find-modules/FindXCB.cmake 7e7e701 > > Diff: http://git.reviewboard.kde.org/r/112151/diff/ > > > Testing > ------- > > tested in kde-workspace > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
