Re: KDE service provider for handling arbitrary links (namely tel: links)

2019-05-08 Thread Sune Vuorela
On 2019-05-08, Hans-Peter Jansen wrote: > Since some time, special links like e.g. tel:+49... appear on the web, and > I've taught my browser (Firefox) to handle those as well. Now, I would like > integrate with kmail, chromium, ... https://phabricator.kde.org/D18369 I think that patch helps e

Re: How are tier 1 framework qm translations supposed to be loaded?

2021-02-15 Thread Sune Vuorela
On 2021-01-26, Halla Rempt wrote: > Ah... I guess that explains it. GenericDataLocation is only useful in a linux > distribution packages setup, because it's the location that's shared with > other applications, so we patch ki18n to use AppDataLocation -- I guess we'll > have to patch ECM as we

Re: Would Scandoc be somthing for Extragear?

2022-11-10 Thread Sune Vuorela
On 2022-11-10, Thomas Baumgart wrote: > I don't know, if you have thought of this when writing invoices. Include > an EPC QR (https://de.wikipedia.org/wiki/EPC-QR-Code) on the invoice. I am > thinking about adding a webcam interface so that KMyMoney can use it to > read the QR code and use the dat

Re: QML: a packagers nightmare. Assistance please.

2023-11-08 Thread Sune Vuorela
On 2023-11-08, Nicolas Fella wrote: > Furthermore, kwin is not a framework, it's part of Plasma, and > dependencies between Plasma components are generally fine. That there is > a circular dependency between plasma-workspace and kwin is not good and > should probably be addressed somehow, but the

Re: QML: a packagers nightmare. Assistance please.

2023-11-08 Thread Sune Vuorela
On 2023-11-08, Kai Uwe Broulik wrote: > Hi, > > that WorkspaceComponents is used for a ShadowedLabel which is literally > one QML file with a Label and a DropShadow. KWin could just not use that > (and build its own) and we’d resolve the issue. It sounds like either moving that component one le

KF6 porting. KSelectAction::triggered signal

2024-01-03 Thread Sune Vuorela
Hi I just - during KF6 porting of an app - fall in an api trap: Original code: | connect(d->aZoom, QOverload::of(&KSelectAction::triggered), | this, &PageView::slotZoom); The wrong porting code: | connect(d->aZoom, &KSelectAction::triggered, this, &PageView::slotZoom); The gotcha is that the

Re: KF6 porting. KSelectAction::triggered signal

2024-01-04 Thread Sune Vuorela
On 2024-01-03, Albert Astals Cid wrote: > scripty has everything checked out so if you tell me what to grep for, I can > run a query on it. I got access to the lxr machine and has been grep'ing there instead, and I only found one maybe-issue that I need to investigate /Sune

Re: KF6 porting. KSelectAction::triggered signal

2024-01-04 Thread Sune Vuorela
On 2024-01-04, Sune Vuorela wrote: > On 2024-01-03, Albert Astals Cid wrote: >> scripty has everything checked out so if you tell me what to grep for, I can >> run a query on it. > > I got access to the lxr machine and has been grep'ing there instead, and > I only

Re: KDE Gear projects with failing CI (release/24.02) (Branching edition)

2024-01-12 Thread Sune Vuorela
On 2024-01-12, Albert Astals Cid wrote: > okular: > * https://invent.kde.org/graphics/okular/-/pipelines/580655 > * It's trying to find packages in a wrong branch On it. Will report a MR for others with likely similar issues. /Sune

Re: KDE Gear projects with failing CI (release/24.02) (Branching edition)

2024-01-12 Thread Sune Vuorela
On 2024-01-12, Sune Vuorela wrote: > On 2024-01-12, Albert Astals Cid wrote: >> okular: >> * https://invent.kde.org/graphics/okular/-/pipelines/580655 >> * It's trying to find packages in a wrong branch > > On it. Will report a MR for others with likely similar

Re: KDE Gear projects with failing CI (master) (20 February 2024)

2024-02-21 Thread Sune Vuorela
On 2024-02-21, Ben Cooksley wrote: >> ark - 3rd week >> * https://invent.kde.org/utilities/ark/-/pipelines/611869 >> * tests fail on FreeBSD >> > > Wonder if the tests properly handle umask being set? I agree that the issue is likely here /Sune

Re: KDE Gear projects with failing CI (master) (20 February 2024)

2024-02-21 Thread Sune Vuorela
On 2024-02-21, Sune Vuorela wrote: > On 2024-02-21, Ben Cooksley wrote: >>> ark - 3rd week >>> * https://invent.kde.org/utilities/ark/-/pipelines/611869 >>> * tests fail on FreeBSD >>> >> >> Wonder if the tests properly handle umask being se

Re: Post-MegaRelease projects

2024-02-23 Thread Sune Vuorela
On 2024-02-22, Nate Graham wrote: > I've started pondering post-megarelease projects. We've spent so long on > porting and bugfixing that I think it might be useful to shift gears to > feature work, and I'd like to brainstorm potential large-scale projects > and gauge the level of interest in p

Re: KDE Gear projects with failing CI (master) (28 February 2024)

2024-02-28 Thread Sune Vuorela
On 2024-02-28, Albert Astals Cid wrote: > > ark - 1st week > * https://invent.kde.org/utilities/ark/-/pipelines/616910 > * flatpak fails complaining about KF6BreezeIcons I think this is due to an old flatpak environment https://invent.kde.org/frameworks/breeze-icons/-/commit/a4970ce40ec43c0a1

Re: KDE Gear projects with failing CI (release/24.02) (28 February 2024)

2024-02-28 Thread Sune Vuorela
On 2024-02-28, Albert Astals Cid wrote: > konversation - 1st week > * https://invent.kde.org/network/konversation/-/pipelines/616933 > * cmake fails to find dbus on Linux CI This seems like intentional sillyness from the konversation developers. Let's fail at build time for runtime components

Re: resvg

2024-03-14 Thread Sune Vuorela
On 2024-03-14, Igor Mironchik wrote: > Hello, > > What do you think about https://github.com/RazrFalcon/resvg in case of > processing and rendering SVGs? > > Do you have any plans to have this in Craft? With the current revitalization of QtSvg, I kind of think we should work harder with that rat

Re: Should we stop distributing source tarballs?

2024-04-04 Thread Sune Vuorela
On 2024-04-03, Albert Vaca Cintora wrote: > What's the advantage of providing tarballs? I do think there is an advantage in being able to verify that the soure tarball is the same across distributions. Using a checksum on the tarball is an easy way of doing it. Different git invocations for git a

Re: Should we stop distributing source tarballs?

2024-04-04 Thread Sune Vuorela
On 2024-04-04, Ben Cooksley wrote: >> I do also think it is nice if we get someone else to verify that the >> tarball we ship actually matches the tag. I think some people in >> distributions have already started looking into verifying that. >> > > Hopefully they'll be gentle with tooling that doe

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-15 Thread Sune Vuorela
tps://git.reviewboard.kde.org/r/114933/#comment33732> Would it be hard to get rid of XmlGui here? I don't see what it really buy us for this example? Replacing it with kwidgetaddons - and maybe switch from kmainwindow to qmainwindow will make the example simpler. - Sune Vuorela On Ja

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-16 Thread Sune Vuorela
> On Jan. 15, 2014, 9:17 a.m., Sune Vuorela wrote: > > kdeui/kmessagewidgetdemo/CMakeLists.txt, line 23 > > <https://git.reviewboard.kde.org/r/114933/diff/2/?file=233694#file233694line23> > > > > Would it be hard to get rid of XmlGui here? I don't s

Re: Should KDED4 run all the time?

2014-06-30 Thread Sune Vuorela
On 2014-06-28, Ian Wadham wrote: > Hi guys, > > When fixing some bugs in the KCrash-DrKonqi sequence on Apple OS X, > I have come to a point where Dr Konqi attempts to call kded4, using DBus, > and issues a message "Failed to communicate with kded. Make sure it is > running." In the kdelibs4.x-a

Re: Should KDED4 run all the time?

2014-07-03 Thread Sune Vuorela
On 2014-07-01, Ian Wadham wrote: >> In the kdelibs4.x-age, yes. kded should be running all the time no matter >> what. > > In Linux and a KDE desktop manager, that is fine: kded4 is part of the > structure > of a KDE desktop manager. But in Apple OS X (or other desktop managers), that > should

Re: code convention

2014-08-12 Thread Sune Vuorela
On 2014-08-12, Rodrigo Bonifacio wrote: > Dear kevin, I am conducting a survey about the use of exception > handling constructs in C++. I would really appreciate if you could > contribute to this research by answering a few questions on the > subject. > > The survey is available on-line: > > https

Re: Fwd: Re: kscreengenie

2015-04-20 Thread Sune Vuorela
On 2015-04-20, Boudhayan Gupta wrote: > Well, Sune Vuorela and Luigi Toscano got on my back and I ended up > re-doing the ungrab workaround the proper way, without the dependency > on private headers, so yay! Try building master now. Yay. Thanks. /Sune >> Visit http://mail.

Re: Qt -fPIC building suggestion

2015-05-23 Thread Sune Vuorela
On 2015-05-22, Jeremy Whiting wrote: > /home/jeremy/devel/kde/build/kdesupport/phonon/phonon/CMakeTmp/check_qt_visibility.cpp:1: > /usr/include/qt/QtCore/qglobal.h:1050:4: error: #error "You must build > your code with position independent code if Qt was built with > -reduce-relocations. " "Compil

Re: Metadata for shared libraries: .json or .desktop?

2015-07-08 Thread Sune Vuorela
On 2015-07-04, Filipe Saraiva wrote: > Hi, I am developing the port of Cantor plugins and libraries to "JSON > files way" - translanting the .desktop files to .json and putting it in > the binaries. Are you talking about plugins (those that gets loaded by [KQ]PluginLoader / QLibrary / dlopen) or

Re: kcoreaddons_add_plugin without INSTALL_NAMESPACE

2015-09-13 Thread Sune Vuorela
On 2015-09-04, Filipe Saraiva wrote: > But for libcantorpart.so I can not to use kcoreaddons_add_plugin because > I need to install that part in the "plugins root" directory. If I use Why do you need to do that? It seems wrong to me. Maybe you should look at your plugin loading code at the same t

Re: Implementing "translation in context"

2015-09-18 Thread Sune Vuorela
On 2015-09-18, Thomas Lübking wrote: > On Freitag, 18. September 2015 09:17:16 CEST, Dashamir Hoxha wrote: > >> The most difficult part in my opinion is how to mark (or decorate) >> the translated string, so that it can respond to a Ctrl+Click event. > > You need a plugin for the (every, could be

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

2015-11-18 Thread Sune Vuorela
e.cpp (line 137) <https://git.reviewboard.kde.org/r/126105/#comment60725> if(rc == 0) return false src/engine/database.cpp (line 167) <https://git.reviewboard.kde.org/r/126105/#comment60726> if(rc == 0) return false - Sune Vuorela On Nov. 18, 2015, 7:40 p.m.

Re: I developed a workaround for Qt5.4 DND bug that KDE apps might need

2016-01-23 Thread Sune Vuorela
On 2016-01-16, PCMan wrote: > Since DND is crucial for a modern desktop environment and it's an upstream > bug, I believe that KDE is also affected. > Luckily I found some quick workarounds, so I'm gonna share it with you. > > https://github.com/lxde/pcmanfm-qt/pull/295/files > > I made it an inde

Re: The situation of KWallet, and what to do about it?

2016-07-11 Thread Sune Vuorela
On 2016-07-07, Kevin Ottens wrote: > There's two sides to that problem in fact, use from applications and the=20 > service provided by our workspace. One issue that I'm a bit puzzled about is the following scenario: A user uses KMail for emails. But switches between various desktop environments.

Re: CMake code to find KrossPython

2011-02-28 Thread Sune Vuorela
On 2011-02-27, Daniel E. Moctezuma wrote: > I'm trying to make a CMake Module to find whether or not KrossPython is > installed, as fas as I know once you install the Python plugin for Kross, > you will have a 'krosspython.so' file installed (in my case this file is in > /usr/lib64/kde4). It soun

Re: CMake code to find KrossPython

2011-03-01 Thread Sune Vuorela
On 2011-02-28, Daniel E. Moctezuma wrote: > Yes, this CMake code is to check whether or not the krosspython library is > installed on the system when you execute the configure file before build. > We think it is necessary to check it because it allows the user to know > which functionalities you

Re: KIO::Slave for secrets collections browsing

2011-08-14 Thread Sune Vuorela
On 2011-08-14, Valentin Rusu wrote: > Hello, > > Just wanted to inform you that I introduced a new component into the > KSecretsService infrastructure, a KIO::Slave. This will let you browse > for the secrets directly inside Konqueror or Dolphin. See this screen > capture: > http://wstaw.org/m/201

Re: Moving installed kdelibs

2011-08-30 Thread Sune Vuorela
On 2011-08-30, Michael Jansen wrote: > But perhaps you find some problems and have to fix them. I am not absolutely > sure of our DESTDIR support. Perhaps it is completly screwed up. Which would > be another cmake regression compared to automake. DESTDIR works nicely. It is also very important

Re: Bug triage process needs help

2011-09-29 Thread Sune Vuorela
On 2011-09-28, Bart Kelsey wrote: > Hi folks, > > I'd like to draw attention to the fact that KDE's bug triage process is > lacking. Hi Bart You are absolutely right that we get more bug reports to any component than we can currently handle, as you have noticed yourself. I haven't looked at th

Re: Bug triage process needs help

2011-10-02 Thread Sune Vuorela
On 2011-10-02, Kevin Krammer wrote: > Interesting. So do other projects ship bug fixes without patch level releas= > e or=20 > do the not ship bug fixes at all? At least in debian, for stable updates it is only for very serious issues there are shipped updates in stable releases, among other thin

Re: Relicensing Questions

2011-11-26 Thread Sune Vuorela
On 2011-11-26, Andras Mantia wrote: >> a) current license of a file > > Maybe krazy can do it? Maybe modestas vainius' (of debian kde) copyrighthelper script can help. http://anonscm.debian.org/gitweb/?p=users/modax/copyright-helper.git;a=summary >> Regarding b) I wonder: >> Is anyone who ever

Re: Hacking KDE applications

2012-01-07 Thread Sune Vuorela
On 2012-01-07, Bjoern Schiessle wrote: > How does other KDE developers handle this situation? Is it possible to > compile and run a program in my home directory without messing up my > system installation? make sure the Plasma session has KDEDIRS variable set to your install prefix. /Sune >> V

Re: Get involved on KDE Development

2012-02-02 Thread Sune Vuorela
On 2012-02-02, Aaron J. Seigo wrote: > that said, there are a lot of projects in need of helping hands and don't > require year-long commitments :) kde-edu and kde-games are two great > communities to get started with and both have great need for participation, > for instance. Another example

Re: Konqueror- GSOC idea

2012-02-13 Thread Sune Vuorela
On 2012-02-13, Andrew Mason wrote: >> By the way, if you want to sort downloads by file types, using Nepomuk >> is the obvious solution. > > I like this idea but please consider there are some people, for which Nepomuk > is disabled. This can be because Nepomuk impacts the performance of their >

Re: GSoC idea: improving scanning and OCR in KDE (skanlite/kooka)

2012-03-06 Thread Sune Vuorela
On 2012-03-06, todd rme wrote: > Scanner kio slave. An easy scanner interface using file managers > (like the current CD ripper kio slave). There would be a folder for > each scanner. When the folder is opened it will pull in a preview > from that scanner. There would then be folders for suppo

Re: GSoC idea: improving scanning and OCR in KDE (skanlite/kooka)

2012-03-08 Thread Sune Vuorela
On 2012-03-07, Kåre Särs wrote: > How do we go forward from here? Put it on the wikipage, wait for KDE to be a gsoc approved organization, wait for official project submissions, get the student to submit the project. hope that KDE as a organization selects your project. > Who is willing to ment

Re: Should the library version follow the KDE release version?

2012-05-02 Thread Sune Vuorela
On 2012-05-02, Stefan Majewsky wrote: > On Wed, May 2, 2012 at 8:30 PM, Weng Xuetian wrote: >> For example, libkdecore is now 5.8.0, but still the api is 4.7. > > When the VERSION was 5.1.0 previously, can I go back to 4.9.0 to reach > consistency with the KDE release, while I still bump the SOVE

Re: What builds libnepomukdatamanagement?

2012-05-06 Thread Sune Vuorela
On 2012-05-06, Vishesh Handa wrote: > --===4448671127468223506== > Content-Type: multipart/alternative; boundary=bcaec554de825124e104bf5e7f70 > > --bcaec554de825124e104bf5e7f70 > Content-Type: text/plain; charset=ISO-8859-1 > > On Sun, May 6, 2012 at 4:38 PM, Lindsay Mathieson < > lind

Re: using unixodbc-dev instead of libiodbc2-dev

2012-05-25 Thread Sune Vuorela
On 2012-05-25, Aaron J. Seigo wrote: > (assuming virtodbc_r is indeed the correct library from unixodbc to use; i > don't know, just going from what's in the patch you posted) This one isn't about switching to unixodbc, but bypassing the drivermanager bits called 'odbc' completely. The reason f

Re: When does kbuildsycoca4 run?

2012-09-18 Thread Sune Vuorela
On 2012-09-18, mk-li...@email.de wrote: >> Technically it needs to be run if new .desktop files are installed. > > Is the assumption correct that the run would have to be carried out by the > user and not by root? Yes. (and kded takes care of running it (with a small delay of a minute or so (t

Re: KPluginLoader ==> cannot load any more object with static TLS

2012-10-31 Thread Sune Vuorela
On 2012-10-30, Stephane MANKOWSKI wrote: > On kubuntu 12.04 (with KDE 4.9.1), all plugins were successfully loaded. > On kubuntu 12.10 (with KDE 4.9.2), some plugins are not loaded due to a=20 > NULL pointer returned by /*loader.factory()*/ > I didn't change the code of Skrooge in between. > > If

Re: <3 for some people

2013-02-19 Thread Sune Vuorela
On 2013-02-17, Lydia Pintscher wrote: > Who's on your list? On top of my list is Lydia for doing stuff like this, for managing stuff like GSoC and for ensuring new and old people feel welcome in KDE. Albert also have a sweet spot in my heart for stepping up on getting stuff released. and a 3rd

Re: Incubation Request: Kiview

2024-04-29 Thread Sune Vuorela
On 2024-04-28, Méven wrote: > The immediate goal with this application is to fill this request feature > for dolphin : > https://bugs.kde.org/show_bug.cgi?id=272539 > And we can imagine reusing it in many other places potentially. I just opened 'DocumentViewer' class and spent 5 minutes and got a

Re: KDE Gear projects with failing CI (master) (25 June 2024)

2024-06-26 Thread Sune Vuorela
On 2024-06-26, Ben Cooksley wrote: > Possible fallout of the Windows image being rebuilt, except libssh hasn't > changed since 2023 in Craft, so this must be due to Qt changes. > Pretty sure we've seen this type of error before though? (curiously, > qplatformdefines.h should include sys/types.h an

Re: Coding style: const QString foo = foo();

2024-10-29 Thread Sune Vuorela
On 2024-10-28, Albert Astals Cid wrote: > My vote goes for rename the variable, there's 2 reasons i can think why you > do > > const QString foo = foo(); > > (there's probably many more, i spent 5 seconds thinking) > > Reason 1: You're caching it because foo is expensive, rename the variable to

Coding style: const QString foo = foo();

2024-10-28 Thread Sune Vuorela
Hi peoples Quite some repositories have enabled cppcheck with a ruleset that I more or less have composed so far. I do think it provides valuable feedback, especially if we can get the rules groomed sufficiently and fix the remaining points. It at least have helped me with quite some bugs over ti

Re: New Application Status

2024-12-03 Thread Sune Vuorela
On 2024-12-03, Ingo Klöcker wrote: > Is "passing KDE Review" really connected in any way to "packaged by some > distro"? I guess that's a question only distro packagers can answer. It is not. But "having stable releases" is connected, though if the thing is sufficiently interesting, prereleases

Re: Help with a KMail crash

2024-12-04 Thread Sune Vuorela
On 2024-12-04, Ingo Klöcker wrote: > Given that iterators are involved I suspect that shadowIdentities is modified > while it is being iterated over which invalidates the iterator it. There are > some signals emitted in this loop so that there's is a lot of potential for > additional calls to K

Re: KDE Gear projects with failing CI (master) (14 January 2025)

2025-01-15 Thread Sune Vuorela
On 2025-01-14, Albert Astals Cid wrote: >> kamera - NEW >> * https://invent.kde.org/graphics/kamera/-/pipelines/865501 >> * FreeBSD build fails >>* It's a gphoto2 bug but we should probably workaround it >> * https://github.com/gphoto/libgphoto2/issues/1077 > > How does https://invent.k

Re: Test Failures Fatal by Default in KDE CI

2025-03-18 Thread Sune Vuorela
On 2025-03-18, Ingo Klöcker wrote: > For libkleo we do have Windows CI. But those tests seems green? or are they flaky? /Sune

Re: Test Failures Fatal by Default in KDE CI

2025-03-18 Thread Sune Vuorela
On 2025-03-18, Ingo Klöcker wrote: > Options: > require-passing-tests-on: ['Linux', 'FreeBSD'] > ``` > and there are builds for Linux, FreeBSD, and Windows. > > I suppose I can safely add > ``` > allow-failing-tests-on: [ 'Windows' ] > ``` > now _additionally_ to the require-passing-tests-on.

Re: Proposal to Update Minimum CMake Version to 3.22

2025-04-01 Thread Sune Vuorela
On 2025-03-30, Ömer Fadıl USTA wrote: > I hope this message finds you well. I would like to propose an update to > the minimum required version of CMake for KDE Frameworks and KDE Plasma > projects, raising it from 3.16 to 3.22. I'm missing the good argument for this other than larger is better.