> On Jan. 15, 2014, 9:17 a.m., Sune Vuorela wrote: > > kdeui/kmessagewidgetdemo/CMakeLists.txt, line 23 > > <https://git.reviewboard.kde.org/r/114933/diff/2/?file=233694#file233694line23> > > > > Would it be hard to get rid of XmlGui here? I don't see what it really > > buy us for this example? > > > > Replacing it with kwidgetaddons - and maybe switch from kmainwindow to > > qmainwindow will make the example simpler. > > Laurent Navet wrote: > XmlGui replaced with KWidgetAddons and KConfigWidgets. > switched from KMainWindow to QMainWindow.
I don't see the updated diff ? - Sune ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review47428 ----------------------------------------------------------- On Jan. 10, 2014, 8:49 p.m., Laurent Navet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114933/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2014, 8:49 p.m.) > > > Review request for KDE Examples and Sune Vuorela. > > > Repository: kdeexamples > > > Description > ------- > > This is part of Google Code-IN Contest. > As I'm no more student, I've waited for the end of the contest to work on it. > > Comments appreciated, > > > Diffs > ----- > > kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac > kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 > kdeui/kmessagewidgetdemo/window.h d3a67c8 > kdeui/kmessagewidgetdemo/window.cpp 9786da6 > > Diff: https://git.reviewboard.kde.org/r/114933/diff/ > > > Testing > ------- > > Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit > I've commented the line. > > > Thanks, > > Laurent Navet > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
