----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126105/#review88556 -----------------------------------------------------------
without actualy knowing the code in question, a brief look over gives me the impression that the error handling could be improved and that would make this patch not needed. src/engine/database.cpp (line 104) <https://git.reviewboard.kde.org/r/126105/#comment60724> SHouldn't there be a if(rc == 0) return false here ? src/engine/database.cpp (line 137) <https://git.reviewboard.kde.org/r/126105/#comment60725> if(rc == 0) return false src/engine/database.cpp (line 167) <https://git.reviewboard.kde.org/r/126105/#comment60726> if(rc == 0) return false - Sune Vuorela On Nov. 18, 2015, 7:40 p.m., Boudhayan Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126105/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 7:40 p.m.) > > > Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Add a check in Baloo::Database::open() to return false if we're opening the > database in ReadOnly mode and the database doesn't exist. This fixes a crash > in Dolphin when Baloo isn't running. > > This isn't the entire fix - one will also have to remove > ~/.local/share/baloo/index to not crash anymore; this patch prevents the file > from being recreated everytime Baloo::Database::open() is run, and re-causing > the crash. > > > Diffs > ----- > > src/engine/database.cpp 4f0579f > > Diff: https://git.reviewboard.kde.org/r/126105/diff/ > > > Testing > ------- > > Builds, runs, doesn't crash anymore, the works. > > > Thanks, > > Boudhayan Gupta > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
