Re: Review Request 125818: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125818/#review87535 --- I really have no idea about this. If you're sure about this go

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

2015-10-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125776/#review87537 --- src/engine/transaction.h

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

2015-10-27 Thread Pinak Ahuja
> On Oct. 27, 2015, 6:26 p.m., Vishesh Handa wrote: > > src/engine/transaction.h, line 120 > > > > > > I'm a little confused. Isn't the metadatamover using this method? > > > > $ ack renameFilePath > >

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

2015-10-27 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125776/ --- (Updated Oct. 27, 2015, 6:35 p.m.) Review request for Baloo and Vishesh H

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

2015-10-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125776/#review87541 --- Ship it! :) - Vishesh Handa On Oct. 27, 2015, 6:35 p.m., P

Re: Review Request 125818: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-27 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125818/ --- (Updated Okt. 27, 2015, 6:53 nachm.) Review request for Baloo and Vishesh

Re: Review Request 125818: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-27 Thread Heiko Becker
> On Okt. 27, 2015, 6:22 nachm., Vishesh Handa wrote: > > I really have no idea about this. If you're sure about this go ahead. I previously put up a review for kwallet: https://git.reviewboard.kde.org/r/125819/ which has been accepted in the meatime. This also has been done for other framew

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

2015-10-27 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125776/ --- (Updated Oct. 27, 2015, 7:05 p.m.) Status -- This change has been ma

Re: Review Request 125818: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125818/#review87546 --- Ship it! Ship It! - Vishesh Handa On Oct. 27, 2015, 6:53 p

Re: Review Request 125818: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-27 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125818/ --- (Updated Oct. 27, 2015, 9:59 p.m.) Status -- This change has been ma