> On Okt. 27, 2015, 6:22 nachm., Vishesh Handa wrote: > > I really have no idea about this. If you're sure about this go ahead.
I previously put up a review for kwallet: https://git.reviewboard.kde.org/r/125819/ which has been accepted in the meatime. This also has been done for other frameworks. Two examples: https://quickgit.kde.org/?p=knotifications.git&a=commit&h=6e04d368e400d7e5eedbc2ef4c2e9fab3a1a8052 https://quickgit.kde.org/?p=knotifications.git&a=commit&h=6e04d368e400d7e5eedbc2ef4c2e9fab3a1a8052 - Heiko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125818/#review87535 ----------------------------------------------------------- On Okt. 27, 2015, 6:53 nachm., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125818/ > ----------------------------------------------------------- > > (Updated Okt. 27, 2015, 6:53 nachm.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > ...and use PATH_VARS to make the config file work with absolute paths. > > Two reasons to do this: > - DBUS_INTERFACES_INSTALL_DIR is marked deprecated > - By not hard-coding the packackage prefix, it's helpful on a multiarch > layout where the prefix is /usr/${host} but arch-independent files > should still be installed to /usr/share (i.e a level below the > prefix). > > > Diffs > ----- > > CMakeLists.txt 9f719667902cd13257b59113f1eb8bb0e8515d28 > KF5BalooConfig.cmake.in 08413efa29290c37dc501cc2ec1eb86d13218981 > src/dbus/CMakeLists.txt 44240ec643eef69f90b3832314ede46bca1820e5 > src/dbus/fake/CMakeLists.txt c9735b3d176c4a3c7ee995dac0aa83a3b715bf7c > > Diff: https://git.reviewboard.kde.org/r/125818/diff/ > > > Testing > ------- > > Successfully installed it with > -DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and > -DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share > > > Thanks, > > Heiko Becker > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
