----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125776/#review87537 -----------------------------------------------------------
src/engine/transaction.h <https://git.reviewboard.kde.org/r/125776/#comment60096> I'm a little confused. Isn't the metadatamover using this method? $ ack renameFilePath src/file/metadatamover.cpp 116: tr->renameFilePath(id, job.document()); - Vishesh Handa On Oct. 26, 2015, 8:16 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125776/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 8:16 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Since the inode remains same on moving, the fileId should be preserved. We > can simply check if the filePath in the db is same as the actual filePath to > check if file is moved and update the filePath if needed. This will also > handle renames. > > > Diffs > ----- > > src/engine/documentoperations.h 6382e53 > src/engine/transaction.h 2ae052e > src/engine/transaction.cpp f3c0f4c > src/engine/writetransaction.cpp ae27ad9 > src/file/unindexedfileindexer.cpp 6873047 > > Diff: https://git.reviewboard.kde.org/r/125776/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
