Re: Review Request 110084: Make ftp error messages prettier

2015-02-01 Thread Kai Uwe Broulik
/04/19/ftpmsgafter.png Thanks, Kai Uwe Broulik

Re: Review Request 108312: Use view-certificate for SSL settings KCM

2015-02-01 Thread Kai Uwe Broulik
icon. Diffs - kio/kssl/kcm/kcm_ssl.desktop c1cebd6 Diff: https://git.reviewboard.kde.org/r/108312/diff/ Testing --- kbuildsycoca4 doesn't complain :-) Thanks, Kai Uwe Broulik

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2015-02-01 Thread Kai Uwe Broulik
ttons and other elements do). File Attachments KPageDialog icon adapted https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconding.png Thanks, Kai Uwe Broulik

Re: Review Request 123169: Show percentage value beside brightness level slider

2015-03-29 Thread Kai Uwe Broulik
percentage from the brightness sliders in the battery monitor since you basically change the brightness to your liking and not to some odd percentage, so adding them back in the PowerDevil settings doesn't make sense. - Kai Uwe Broulik On März 29, 2015, 9:42 vorm., Siddhartha Sahu

Re: Review Request 123169: Show percentage value beside brightness level slider

2015-03-29 Thread Kai Uwe Broulik
> On März 29, 2015, 6:34 nachm., Kai Uwe Broulik wrote: > > Thank you for this patch! > > > > However, we chose to remove the percentage from the brightness sliders in > > the battery monitor since you basically change the brightness to your > > liking a

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/#review79171 --- Please use the kdeframeworks group, kdelibs is 4.x - Kai Uwe

Re: Distros and QtWebEngine

2015-04-20 Thread Kai Uwe Broulik
‎Note that QtQuick Text never uses RichText unless told, AutoText only enables StyledText when it finds something that looks like a tag before the first line break.    Originalnachricht   Von: Thomas Lübking Gesendet: Montag, 20. April 2015 23:27 An: Jeremy Whiting Cc: kdelibs Betreff: Re: Distr

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Kai Uwe Broulik
tps://git.reviewboard.kde.org/r/123797/#comment55163> use .isEmpty() rather than string comparison plasma-workspace/klipper/historyitem.cpp (line 89) <https://git.reviewboard.kde.org/r/123797/#comment55164> return nullptr; - Kai Uwe Broulik On Mai 15, 2015, 2:24 nachm., Patri

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Kai Uwe Broulik
against plasma-workspace ;) - Kai Uwe Broulik On Mai 15, 2015, 6:33 nachm., Patrick Eigensatz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Kai Uwe Broulik
> On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: > > thanks for rebasing! > > > > I just had a look at the bug report and have to agree with comment #1: I do > > from time to time copy on purpose whitespaces (yes I'm weird). I also tend > > to copy newlines and I do want to have them in t

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Kai Uwe Broulik
ld try to implement an option for this, > although I've never done this before and I would surely need some > assistance... > > Kai Uwe Broulik wrote: > I also sometimes copy whitespace but then I immediately paste it in, so I > wouldn't need it in the history, its

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Kai Uwe Broulik
tps://git.reviewboard.kde.org/r/123806/#comment55182> You could probably simplify that to m_ui.kcfg_WhitespacesAsSymbols->setEnabled(m_ui.kcfg_AllowWhitespaces->isChecked()); - Kai Uwe Broulik On Mai 16, 2015, 12:40 nachm., Patrick Eig

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Kai Uwe Broulik
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other option

Re: Review Request 124253: Resurrect dead code and fix two memory leaks

2015-07-04 Thread Kai Uwe Broulik
/login1suspendjob.cpp (line 81) <https://git.reviewboard.kde.org/r/124253/#comment56401> If you're at it, please change this to the new connect syntax: connect(watcher, &QDBusPendingCallWatcher::finished, this, &Login1SuspendJob::sendResult); - Kai Uwe Broulik On Juli 4, 2015,

Re: Review Request 124253: Resurrect dead code and fix two memory leaks

2015-07-04 Thread Kai Uwe Broulik
> On Juli 4, 2015, 4:18 nachm., Kai Uwe Broulik wrote: > > daemon/backends/upower/login1suspendjob.cpp, line 83 > > <https://git.reviewboard.kde.org/r/124253/diff/1/?file=383152#file383152line83> > > > > If you're at it, please change this to the new co

AW: folder icons where should they be set

2015-09-11 Thread Kai Uwe Broulik
Hi, Aren't these XDG standard dirs you can even configure? Just show the folder at XDG images with a pictures folder icon and so on.  If you use different folders without telling the system, it's your own fault ;) Cheers,  Kai Uwe‎

Re: Review Request 126204: kdialog: Implement new password dialog

2015-11-30 Thread Kai Uwe Broulik
tps://git.reviewboard.kde.org/r/126204/#comment60899> Don't abbreviate those - Kai Uwe Broulik On Nov. 30, 2015, 8:51 vorm., Andrew Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

Re: Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

2015-12-15 Thread Kai Uwe Broulik
media/uploaded/files/2013/01/16/colorbigsizeafter.png Thanks, Kai Uwe Broulik

Re: Review Request 110266: Cleanp Places Panel context menu

2015-12-15 Thread Kai Uwe Broulik
hments Comparison (left old, right new) https://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/kdelibsplaces.png Thanks, Kai Uwe Broulik

Re: Review Request 108442: [High-dpi issues] Fix KIconButton initial icon size and its occurence in KPropertiesDialog

2015-12-15 Thread Kai Uwe Broulik
size and font scales perfectly and looks good. See screenshot. File Attachments KPropertiesDialog with Retina settings https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconbutton.png Thanks, Kai Uwe Broulik

Re: Review Request 102149: Improve Calculate/Stop buttons when folder Size is being calculated

2015-12-15 Thread Kai Uwe Broulik
s - kio/kfile/kpropertiesdialog.cpp ba56f18 Diff: https://git.reviewboard.kde.org/r/102149/diff/ Testing --- Compiles and the buttons toggle (and react) fine. Screenshots --- Screenshot of the dialog while it is calculating https://git.reviewboard.kde.org/r/102149/s/213/ Thanks, Kai Uwe Broulik

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Kai Uwe Broulik
) <https://git.reviewboard.kde.org/r/125910/#comment61813> Note that this string can be shown to the user (we do this in Battery Monitor), so it should be a translatable proper string. - Kai Uwe Broulik On Dez. 29, 2015, 8:54 nachm., Johannes Stefan

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Kai Uwe Broulik
> On Dez. 30, 2015, 2:52 nachm., Kai Uwe Broulik wrote: > > kdeui/notifications/knotificationrestrictions.cpp, line 50 > > <https://git.reviewboard.kde.org/r/125910/diff/2/?file=414354#file414354line50> > > > > Note that this string can be shown t

Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls

2016-01-04 Thread Kai Uwe Broulik
inwindow.cpp (line 747) <https://git.reviewboard.kde.org/r/126627/#comment61929> .value(); app/mainwindow.cpp (line 760) <https://git.reviewboard.kde.org/r/126627/#comment61931> setArguments({mScreenSaverInhibitionCookie}) - Kai Uwe Broulik On Jan. 4, 2016, 8:07 nachm

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Kai Uwe Broulik
7;s also a reserved QML keyword. Also, you can access any role with a name clash by accessing it through "model", ie. model.index - Kai Uwe Broulik On Jan. 23, 2016, 1:14 nachm., Daniel Faust wrote: > > --- > This is an autom

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Kai Uwe Broulik
> On Jan. 23, 2016, 1:22 nachm., Kai Uwe Broulik wrote: > > id isn't particularly better either as that's also a reserved QML keyword. > > > > Also, you can access any role with a name clash by accessing it through > > "model", ie. model.index

Re: KDE file dialog

2016-03-06 Thread Kai Uwe Broulik
Hi, > Distributions set up distribution-wide "Sans", "Serif" and "Monospace" > aliases for a reason. The fonts are carefully selected by the distribution > based on a variety of criteria, including glyph coverage We tried to keep font decisions to distributions before Plasma 5 and it always ma

Re: Open Folder and select file

2016-03-19 Thread Kai Uwe Broulik
Hi, I've been working on something exactly like this: https://git.reviewboard.kde.org/r/127004/ I want it to support Windows and OS X eventually, too. Haven't found the time lately to finish it yet, though.  Cheers,  Kai Uwe 

Re: [Kde-pim] Qt 4 Builds

2016-03-27 Thread Kai Uwe Broulik
Hi,> gwenview depends on baloo as well isn't Gwenview already released as kf5? At least I've been running it for years almost without a problem. Cheers, Kai Uwe 

Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

2016-05-02 Thread Kai Uwe Broulik
s Before https://git.reviewboard.kde.org/media/uploaded/files/2016/05/02/7dfbde66-ded8-4881-b7d4-86ba253afae4__kfindbefore.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/05/02/d7d22fb6-c326-41c3-836a-4fa3bce8cc76__kfindafter.png Thanks, Kai Uwe Broulik

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

2016-05-02 Thread Kai Uwe Broulik
/2016/05/02/d7d22fb6-c326-41c3-836a-4fa3bce8cc76__kfindafter.png Thanks, Kai Uwe Broulik

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

2016-05-29 Thread Kai Uwe Broulik
i Uwe Broulik On Mai 2, 2016, 7:04 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

2016-06-06 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Base Apps and KDE Usability. Changes --- Submitted with commit 7d94f8ce772b04fb26d3d8c03c71d7770fcba45c by Kai Uwe Broulik to branch frameworks. Repository: kde-baseapps Description --- While searching the entire tab widget got disabled so

Re: web server for appstream metadata screenshots

2016-06-08 Thread Kai Uwe Broulik
Hi, I thought we agreed to keep artwork in SVN due to the penalty you get in Git when storing large blobs. However given Breeze stuff is entirely in Git now, ... Cheers,  Kai Uwe 

Review Request 128305: [KFind] Use KIO::highlightInFileManager

2016-06-28 Thread Kai Uwe Broulik
xcept that it'll result in just one file manager window now. Thanks, Kai Uwe Broulik

Re: Review Request 128305: [KFind] Use KIO::highlightInFileManager

2016-07-01 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Base Apps. Changes --- Submitted with commit 5997228c0a129ea75dad1dd5264c681386793015 by Kai Uwe Broulik to branch frameworks. Repository: kde-baseapps Description --- This has the file manager open the parent folder(s), scroll to and

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Kai Uwe Broulik
landed a long time ago. Itook your patch and ported it to Frameworks 5, please see the review at https://phabricator.kde.org/D5034 - Kai Uwe Broulik On Juni 22, 2014, 1:39 vorm., Stefan Brüns wrote: > > --- > This is an auto

Re: liquidshell in kdereview

2017-11-04 Thread Kai Uwe Broulik
Hi, AppMenu.cxx: * You can use NoDotAndDotDot flag in entryInfoList() to already skip those * You seem to be using KFileItem and the url you generate just for isDesktopFile(), you could use KDesktopFile::isDesktopFile(), also the isDir() check could come before, a folder cannot be a desktop file

Re: Tipping the apple cart?

2019-06-30 Thread Kai Uwe Broulik
Hi, > In our move to Gitlab, we can do better. Given Gitlab emails contain even less information and context than Phabricator which themselves contained even less information and context than Reviewboard back then, I don't see how this will change or improve anything. > Phab sends out an em

Re: Tipping the apple cart?

2019-07-02 Thread Kai Uwe Broulik
Hi, What are you missing? The description of the change (Review Board had that, Phabricator doesn't, so I got used to it, I guess...), the context of the comment (i.e. the code snippet a comment was added to), so I don't need to open GitLab to figure out what's going on. On Phabricator yo

Re: Tipping the apple cart?

2019-07-08 Thread Kai Uwe Broulik
Hi James, thanks for the info, that sounds great! I think the lack of context and bulk review are really my main issues. Other than that I can't think of any right now. I also only just now realized the filename shown in the mail is actually a deep-link to the actual comment. Cheers Kai Uwe

Re: binary compatibility and qwidget::event

2019-07-12 Thread Kai Uwe Broulik
To avoid situations like [1] and [2] [1] https://cgit.kde.org/kiconthemes.git/commit/?id=1e9af6c54470e890597739f8f2189b0743a00b6f [2] https://cgit.kde.org/kiconthemes.git/commit/?id=083bb8a80fd5941e6fcbaf1ec12a08d8f8c881a5 Am 12.07.19 um 11:14 schrieb Harald Sitter: Hey our binary compatibi

Re: Urgent(ish) Contract KDE Developer availability?

2020-04-02 Thread Kai Uwe Broulik
Hi Bernard, Bug 418906 is actually already being worked on right now and should be fixed soon. See https://phabricator.kde.org/D28476 and https://phabricator.kde.org/D28488 Cheers Kai Uwe

Re: Type=FSDevice desktop files

2020-04-27 Thread Kai Uwe Broulik
Hi, > Would it be OK if we dropped support for desktop files that represent devices? > This was a KDE1/KDE2/KDE3? feature, you'd write/ship a desktop file with Type=FSDevice and Dev=/dev/sdc and this would give you Mount and Unmount in the context menu. I believe macOS to this day automatica

Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/#review39399 --- There seems to be no patch attached - Kai Uwe Broulik On

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Kai Uwe Broulik
. - Kai Uwe Broulik On Oct. 8, 2013, 3:13 p.m., Sven Brauch wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

2013-10-13 Thread Kai Uwe Broulik
sample message http://git.reviewboard.kde.org/r/105304/s/606/ Thanks, Kai Uwe Broulik

Re: Review Request 108312: Use view-certificate for SSL settings KCM

2013-10-13 Thread Kai Uwe Broulik
- kio/kssl/kcm/kcm_ssl.desktop c1cebd6 Diff: http://git.reviewboard.kde.org/r/108312/diff/ Testing --- kbuildsycoca4 doesn't complain :-) Thanks, Kai Uwe Broulik

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

2013-10-14 Thread Kai Uwe Broulik
sample message http://git.reviewboard.kde.org/r/105304/s/606/ Thanks, Kai Uwe Broulik

Re: Review Request 104222: Display recent documents in places bookmark by default

2013-10-27 Thread Kai Uwe Broulik
-baseapps] dolphin/src/panels/places/placesitemmodel.cpp then. - Kai Uwe Broulik On Oct. 27, 2013, 7:07 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 104222: Display recent documents in places bookmark by default

2013-10-27 Thread Kai Uwe Broulik
> On Oct. 27, 2013, 7:09 p.m., Kai Uwe Broulik wrote: > > Note that this needs similar adjustments in Dolphin [kde-baseapps] > > dolphin/src/panels/places/placesitemmodel.cpp then. Belay that, I guess showing "Recent places" in Dolphin isn't that needed. Sor

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-05 Thread Kai Uwe Broulik
nt31041> Not needed, you're not scaling or transforming the images - Kai Uwe Broulik On Nov. 4, 2013, 8:22 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-

Re: Review Request 113885: 3 types of blur

2013-11-18 Thread Kai Uwe Broulik
ttp://git.reviewboard.kde.org/r/113885/#comment31524> Add a doxygen comment about the blurBehindEffect param tier1/kwindowsystem/src/kwindoweffects_x11.cpp <http://git.reviewboard.kde.org/r/113885/#comment31523> Unused include? - Kai Uwe Broulik On Nov. 15, 2013, 2:54 p.m., Marco

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

2013-12-13 Thread Kai Uwe Broulik
> On Dec. 13, 2013, 2:27 p.m., Frank Reininghaus wrote: > > Thanks for looking into this, Dawit! I greatly appreciate this effort. > > > > > > Two questions come to my mind: > > > > 1. Why should these dialogs be modal at all? Everything that KIO does is > > asynchronous, so it could very wel

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-02-01 Thread Kai Uwe Broulik
tps://git.reviewboard.kde.org/r/115408/#comment34408> It also helped a lot if the icon size adjusted to pixel density of the screen / font dpi - Kai Uwe Broulik On Jan. 31, 2014, 8:47 p.m., kdeuser56 kdeuser56 wrote: > > --- > This is a

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-03-01 Thread Kai Uwe Broulik
Please always enclose, even one-liners, in curly braces: if (state == 1) { and below a/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp <https://git.reviewboard.kde.org/r/116481/#comment36394> if (…) { - Kai Uwe Broulik On Feb. 28, 2014, 1:53 p.m.

Re: Review Request 116522: Make KAboutDialog looks better under OSX

2014-03-01 Thread Kai Uwe Broulik
tps://git.reviewboard.kde.org//r/116522/#fcomment161> There is no way to send an E-Mail anymore? Mabye use a text link instead for all platforms and get rid of that misused toolbar button altogether. - Kai Uwe Broulik On March 1, 2014, 11:06 p.m., Yue Liu

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-08-31 Thread Kai Uwe Broulik
out and then Ship it. Thanks! - Kai Uwe Broulik On Feb. 28, 2014, 1:53 nachm., Joschi Brauchle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 121191: Use properly rounded brightness values in OSD

2014-11-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121191/#review70709 --- There does not seem to be a patch applied. - Kai Uwe Broulik

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2015-01-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/#review73975 --- Ping? - Kai Uwe Broulik On Feb. 28, 2014, 1:53 nachm

Re: Retiring

2021-01-13 Thread Kai Uwe Broulik
Hi Christoph, thank you so much for enduring work! I sometimes imagined me calling you on the phone Sunday morning at 5 am asking about some bug report that I vaguely remembered seeing but couldn't find and you immediately knew what I was talking about, spat out the 6 digit bug report number,

Adding a MimeType without breaking existing associations

2021-05-26 Thread Kai Uwe Broulik
Hi everyone, the other day I noticed that Engrampa (MATE's archive viewer) could open some Windows EXE files so I could pull out self-extracting archive contents without running the executable. I found that this actually came from libarchive and was curious if flipping a switch in Ark could a

Regression in remote thumbnail generation in KIO

2021-12-11 Thread Kai Uwe Broulik
Hi, I suggest we hold back the release briefly, revert [1] and respin KIO as to not release a version with a severe regression. Cheers Kai Uwe [1] https://invent.kde.org/frameworks/kio/-/merge_requests/617

Re: Git merge workflow: reverse it?

2022-05-10 Thread Kai Uwe Broulik
Hi, can we get an update on this? Plasma is full on cherry-pick now but in KDE Gear it's inconsistent and frustrating when some projects use cherry-pick (e.g. Kate) and some don't (e.g. Dolphin). I don't really mind what the outcome is but I need it to be consistent and predictable where to

Where to put Solid device action macro expander?

2022-07-26 Thread Kai Uwe Broulik
Hi everyone, Plasma's Device Notifier applet offers actions for devices, such as "open in file manager", "download images", "format partition" provided through Solid actions. Those are basically special desktop files with a predicate that Solid runs against your drives to determine whether the

Re: KJournald in KDE-Review

2022-11-03 Thread Kai Uwe Broulik
Hi, nice work! Here's some comments, nitpicks, etc on the code (might apply to other files than the one mentioned, too): * bootmodel.cpp: I don't think you need to call beginResetModel() when you populate it in the constructor * bootmodel.cpp: QAbstractListModel is a flat list with a single

Re: KJournald in KDE-Review

2022-11-04 Thread Kai Uwe Broulik
Hi, > in the left side filter area, there are tooltips, do you mean others? Oh, indeed, maybe I was too impatient with my mouse, I can see them now :) > Do you have a hint how to do this best? 😄 Since we should not use contextProperties anymore, I do not directly see how to avoid a proxy class.

Re: what to do with phonon & why aren't you using it?

2023-03-14 Thread Kai Uwe Broulik
Hi, like Android for which the traditional linux-based multimedia platforms like gstreamer or vlc don't work, or are very hard to get working properly. GStreamer seems the most comprehensive QML-capable framework on Android, too. At least I recall Eike having to use GStreamer for Kirogi (dro

Re: "Logout Screen" only shows shutdown when pressing the power button

2024-07-14 Thread Kai Uwe Broulik
Hi, I guess that’s the same issue I had where I had a leftover “default logout option” in settings, so the “Leave” screen defaulted to that option (e.g. only Shutdown) without the other options. Cheers Kai uwe Am 15.07.24 um 00:22 schrieb Nate Graham: That's not what's supposed to be happeni

Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/ --- Review request for KDE Base Apps. Summary --- Since I use kdialog a l

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/ --- (Updated May 5, 2011, 3:57 p.m.) Review request for KDE Base Apps. Chang

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-06 Thread Kai Uwe Broulik
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/#review3137 ----------- On May 5, 2011, 3:57 p.m., Kai Uwe Broulik wrote: > > --

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-06 Thread Kai Uwe Broulik
(: Done > On May 5, 2011, 8:36 p.m., Christoph Feck wrote: > > kdialog/kdialog.cpp, line 378 > > <http://git.reviewboard.kde.org/r/101282/diff/2/?file=16137#file16137line378> > > > > Could you add the icon argument to this fallback call, too? See API > >

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/ --- (Updated May 6, 2011, 12:16 p.m.) Review request for KDE Base Apps. Chan

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-06 Thread Kai Uwe Broulik
nd instead for such a purpose which then is handled by the respective desktop environment. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/#review3158 -------------

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/ --- (Updated May 6, 2011, 12:15 p.m.) Review request for KDE Base Apps. Chan

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/ --- (Updated May 6, 2011, 2:52 p.m.) Review request for KDE Base Apps. Chang

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-10 Thread Kai Uwe Broulik
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/#review3228 --- On May 6, 2011, 2:52 p.m., Kai Uwe Broulik wrote: > > -

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/ --- (Updated May 10, 2011, 9:58 a.m.) Review request for KDE Base Apps. Chan

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/ --- (Updated May 10, 2011, 10:16 a.m.) Review request for KDE Base Apps. Cha

Review Request: Make “Edit File Type” button more discoverable

2011-06-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101800/ --- Review request for kdelibs. Summary --- On IRC this evening somebody

Re: Review Request: Make “Edit File Type” button more discoverable

2011-06-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101800/ --- (Updated June 29, 2011, 9:39 a.m.) Review request for kdelibs. Changes -

Review Request: Make “No multiscreen configuration” message prettier

2011-06-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101810/ --- Review request for KDE Base Apps. Summary --- I always found Bluedevi

Re: Review Request: Make “No multiscreen configuration” message prettier

2011-07-01 Thread Kai Uwe Broulik
I corrected that o.O - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101810/#review4284 --- On June 30, 2011,

Re: Review Request: Make “No multiscreen configuration” message prettier

2011-07-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101810/ --- (Updated June 30, 2011, 8:45 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request: Make “No multiscreen configuration” message prettier

2011-07-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101810/ --- (Updated June 30, 2011, 8:47 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request: Make “No multiscreen configuration” message prettier

2011-07-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101810/ --- (Updated June 30, 2011, 9:02 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request: Make “Edit File Type” button more discoverable

2011-07-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101800/#review4260 --- On June 29, 2011, 9:39 a.m., Kai Uwe Broulik wrote: > > -

Re: Review Request: Make “Edit File Type” button more discoverable

2011-07-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101800/ --- (Updated June 30, 2011, 10:34 p.m.) Review request for kdelibs. Changes

Re: Review Request: Make “Edit File Type” button more discoverable

2011-07-18 Thread Kai Uwe Broulik
sit: http://git.reviewboard.kde.org/r/101800/#review4495 --- On June 30, 2011, 10:34 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.

Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-07-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/ --- Review request for kdelibs. Summary --- This patch improves the Calcu

Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-07-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/ --- (Updated July 30, 2011, 2:51 p.m.) Review request for kdelibs. Changes -

Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-08-08 Thread Kai Uwe Broulik
y 30, 2011, 2:51 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102149/ >

Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

2011-09-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102523/ --- Review request for KDE Runtime. Summary --- This little patch adds a

Re: Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

2011-09-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102523/ --- (Updated Sept. 3, 2011, 4:22 p.m.) Review request for KDE Runtime and Nepo

Re: Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

2011-09-06 Thread Kai Uwe Broulik
de.org/r/102523/#review6294 --- On Sept. 3, 2011, 4:22 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-09-22 Thread Kai Uwe Broulik
e. I did not forget this thing here ;) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/#review5534 --- On July 30

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-10-25 Thread Kai Uwe Broulik
feature to make the individual activities selectable, i.e. you can choose in which particular activities an entry should appear, similar to KWin’s "Activity" menu in the window title where you can assign a window to multiple activities. - Kai Uwe Broulik On June 1, 2011, 6:07 a.m

Re: Review Request: Add warning for searching the complete file system

2012-05-04 Thread Kai Uwe Broulik
> On May 3, 2012, 7:35 p.m., Mark Gaiser wrote: > > Let me first say that i have absolutely nothing to say about this. I do > > have an opinion about this though. > > I would not like this. If i'm searching i just want to search and certainly > > don't get a dialog just to confirm my search. >

Re: Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

2012-05-23 Thread Kai Uwe Broulik
nepomuk/kcm/statuswidget.ui ab210c8 Diff: http://git.reviewboard.kde.org/r/102523/diff/ Testing --- Thanks, Kai Uwe Broulik

  1   2   >