> On June 29, 2011, 1:21 p.m., Aaron J. Seigo wrote: > > this is definitely an improvement for discoverability. i'm not sure about > > the exact text (which was not your fault :), see inline comment for that. > > also, i do think with this change to improve the layout and avoid overly > > wide dialogs that the button maybe should be moved beneath the file type > > itself, e.g.: > > > > Type: <mimetype> > > [ File Type Options ] > > Location: <location>
Ok I will look into moving the button below the label :) > On June 29, 2011, 1:21 p.m., Aaron J. Seigo wrote: > > kio/kfile/kpropertiesdialog.cpp, line 963 > > <http://git.reviewboard.kde.org/r/101800/diff/1/?file=25704#file25704line963> > > > > the text (which was already there, yes) is a bit misleading imho. it > > isn't editing the file type of the file itself, but rather changing the > > options associated with the file type. so perhaps "File Type Options" would > > be better? I just copied the tool tip text and capitalized it ;) I will change that - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101800/#review4260 ----------------------------------------------------------- On June 29, 2011, 9:39 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101800/ > ----------------------------------------------------------- > > (Updated June 29, 2011, 9:39 a.m.) > > > Review request for kdelibs. > > > Summary > ------- > > On IRC this evening somebody found it hard to find the options to edit a > specific file type. The KCM is a mess unfortunately but I told him that you > could edit specific file types directly from the properties dialog. > That button is hard to spot, though, which I also often found annoying. It is > neither labled nor does it stand out as “button”. > This patch solves that issue. > > It is in need of discussion whether the label itself should stay but the > button definitly has to look like a clickable target. > > Comparison screenshot: privat.broulik.de/filedialogpatch.png (this screenshot > is from the initial attempt where i forgot the capitalization :P) > > > Diffs > ----- > > kio/kfile/kpropertiesdialog.cpp 3382daa > > Diff: http://git.reviewboard.kde.org/r/101800/diff > > > Testing > ------- > > > Thanks, > > Kai Uwe > >
