----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126627/#review90590 -----------------------------------------------------------
Makes me sad :( +1 nonetheless app/mainwindow.cpp (line 732) <https://git.reviewboard.kde.org/r/126627/#comment61928> Full screen presentation going on / in progress? also perhaps add a hint to the translators app/mainwindow.cpp (line 735) <https://git.reviewboard.kde.org/r/126627/#comment61930> Is this check neccessary? app/mainwindow.cpp (line 747) <https://git.reviewboard.kde.org/r/126627/#comment61929> .value(); app/mainwindow.cpp (line 760) <https://git.reviewboard.kde.org/r/126627/#comment61931> setArguments({mScreenSaverInhibitionCookie}) - Kai Uwe Broulik On Jan. 4, 2016, 8:07 nachm., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126627/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 8:07 nachm.) > > > Review request for Gwenview, KDE Base Apps and Kai Uwe Broulik. > > > Bugs: 334525 > http://bugs.kde.org/show_bug.cgi?id=334525 > > > Repository: gwenview > > > Description > ------- > > This is a better approach to fix bug 334525 than > https://git.reviewboard.kde.org/r/125910/ which forces > a default reason (which is user visible). > > With this new patch Gwenview will set a proper reason > why is it inhibitting the screensaver ("Full Screen Presentation") > and will use the DBus directly rather than the obsolete > KNotificationRestrictions API. > > > Diffs > ----- > > app/mainwindow.cpp 7b30c4e > > Diff: https://git.reviewboard.kde.org/r/126627/diff/ > > > Testing > ------- > > PowerDevil correctly shows that Gwenview is inhibitting > the PM because "Full Screen Presentation". > > > Thanks, > > Martin Klapetek > >
