https://bugs.kde.org/show_bug.cgi?id=438038
--- Comment #1 from ahashmi ---
Created attachment 139231
--> https://bugs.kde.org/attachment.cgi?id=139231&action=edit
Adds arm64 v8.2 FCCMP, FCCMPE, FCMEQ, FCMGE and FCMGT instructions
Note to reviewers: this patch may look a bit big a
https://bugs.kde.org/show_bug.cgi?id=438038
ahashmi changed:
What|Removed |Added
Summary|Addition of arm64 v8.2 |Addition of arm64 v8.2
|FCCMP
https://bugs.kde.org/show_bug.cgi?id=438038
ahashmi changed:
What|Removed |Added
Summary|Addition of arm64 v8.2 |Addition of arm64 v8.2
|FCCMP
https://bugs.kde.org/show_bug.cgi?id=438630
Bug ID: 438630
Summary: Adding zero variants of arm64 v8.2 FCCMP, FCCMPE,
FCMEQ, FCMGE and FCMGT instructions
Product: valgrind
Version: unspecified
Platform: Other
https://bugs.kde.org/show_bug.cgi?id=438630
ahashmi changed:
What|Removed |Added
Assignee|jsew...@acm.org |assad.has...@linaro.org
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=438038
--- Comment #2 from ahashmi ---
Compare-with-zero variants of these instructions are implemented by
https://bugs.kde.org/show_bug.cgi?id=438630
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=428016
--- Comment #8 from ahashmi ---
Adding compare-with-zero variants of arm64 v8.2 FCCMP, FCCMPE, FCMEQ, FCMGE and
FCMGT instructions:
https://bugs.kde.org/show_bug.cgi?id=438630
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=438630
ahashmi changed:
What|Removed |Added
Summary|Adding zero variants of |Adding zero variants of
|arm64
https://bugs.kde.org/show_bug.cgi?id=438630
ahashmi changed:
What|Removed |Added
Summary|Adding zero variants of |Adding zero variants of
|arm64
https://bugs.kde.org/show_bug.cgi?id=438630
--- Comment #1 from ahashmi ---
Created attachment 139381
--> https://bugs.kde.org/attachment.cgi?id=139381&action=edit
Adds zero variants of arm64 v8.2 FCMEQ, FCMGE, FCMGT, FCMLE and FCMLT
instructions
NOTE: This patch is for the compare-wi
https://bugs.kde.org/show_bug.cgi?id=438038
ahashmi changed:
What|Removed |Added
Attachment #139231|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=438038
--- Comment #5 from ahashmi ---
(In reply to Julian Seward from comment #3)
> No .. ensure SIGILL is raised (decode failure) for any undecodable insns.
> Never assert.
Good point, I've changed it to:
+ else {
+/* ty = 2 is an illeg
https://bugs.kde.org/show_bug.cgi?id=438038
ahashmi changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=438038
ahashmi changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=438630
ahashmi changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=438630
ahashmi changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=436411
Bug ID: 436411
Summary: Addition of arm64 v8.2 FABD, FACGE, FACGT and FADD
instructions
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=436411
ahashmi changed:
What|Removed |Added
Assignee|jsew...@acm.org |assad.has...@linaro.org
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=436411
ahashmi changed:
What|Removed |Added
Summary|Addition of arm64 v8.2 |Addition of arm64 v8.2
|FABD
https://bugs.kde.org/show_bug.cgi?id=436411
--- Comment #1 from ahashmi ---
Created attachment 138216
--> https://bugs.kde.org/attachment.cgi?id=138216&action=edit
Adds arm64 v8.2 scalar FABD, FACGE, FACGT and FADD instructions
This patch is for the scalar instruction variant, the
https://bugs.kde.org/show_bug.cgi?id=428016
--- Comment #5 from ahashmi ---
Addittion of v8.2 scalar FABD, FACGE, FACGT and FADD instructions:
https://bugs.kde.org/show_bug.cgi?id=436411
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=436873
Bug ID: 436873
Summary: Addition of arm64 v8.2 vector FABD, FACGE, FACGT and
FADD instructions
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=436873
ahashmi changed:
What|Removed |Added
Assignee|jsew...@acm.org |assad.has...@linaro.org
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=436411
ahashmi changed:
What|Removed |Added
Attachment #138216|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=428016
--- Comment #6 from ahashmi ---
Addition of vector FABD, FACGE, FACGT and FADD instructions:
https://bugs.kde.org/show_bug.cgi?id=436873
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=436873
--- Comment #1 from ahashmi ---
Created attachment 138348
--> https://bugs.kde.org/attachment.cgi?id=138348&action=edit
Adds arm64 v8.2 vector FABD, FACGE, FACGT and FADD instructions
Adds arm64 v8.2 vector FABD, FACGE, FACGT and FADD instr
https://bugs.kde.org/show_bug.cgi?id=428016
Bug ID: 428016
Summary: Collection of tasks for addition of ARMv8.2
instructions and related features
Product: valgrind
Version: unspecified
Platform: Other
OS: Li
https://bugs.kde.org/show_bug.cgi?id=428016
--- Comment #1 from ahashmi ---
Created attachment 132579
--> https://bugs.kde.org/attachment.cgi?id=132579&action=edit
v8.2 instruction list (including variants)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=428016
--- Comment #2 from ahashmi ---
Feature detection tasks moved from https://bugs.kde.org/show_bug.cgi?id=414270
(v8.1) and made part of v8.2 work.
https://bugs.kde.org/show_bug.cgi?id=414268
https://bugs.kde.org/show_bug.cgi?id=413547
--
You are
https://bugs.kde.org/show_bug.cgi?id=414270
--- Comment #1 from ahashmi ---
Feature detection tasks moved to https://bugs.kde.org/show_bug.cgi?id=428016
(v8.2):
https://bugs.kde.org/show_bug.cgi?id=414268
https://bugs.kde.org/show_bug.cgi?id=413547
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=414270
ahashmi changed:
What|Removed |Added
Depends on|413547, 414268 |
Referenced Bugs:
https://bugs.kde.org
https://bugs.kde.org/show_bug.cgi?id=414268
ahashmi changed:
What|Removed |Added
Blocks|414270 |
Referenced Bugs:
https://bugs.kde.org
https://bugs.kde.org/show_bug.cgi?id=414270
ahashmi changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=413547
ahashmi changed:
What|Removed |Added
Blocks|414270 |
Referenced Bugs:
https://bugs.kde.org
https://bugs.kde.org/show_bug.cgi?id=414268
ahashmi changed:
What|Removed |Added
CC||assad.has...@linaro.org
--- Comment #2 from ahashmi
https://bugs.kde.org/show_bug.cgi?id=413547
ahashmi changed:
What|Removed |Added
Attachment #123538|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=413547
ahashmi changed:
What|Removed |Added
See Also||https://bugs.kde.org/show_b
https://bugs.kde.org/show_bug.cgi?id=414268
ahashmi changed:
What|Removed |Added
See Also||https://bugs.kde.org/show_b
https://bugs.kde.org/show_bug.cgi?id=414268
ahashmi changed:
What|Removed |Added
CC||jsew...@acm.org
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=413547
ahashmi changed:
What|Removed |Added
CC||jsew...@acm.org
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=431556
Bug ID: 431556
Summary: Complete arm64 FADDP v8.2 instruction support started
in 413547
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=431556
ahashmi changed:
What|Removed |Added
Assignee|jsew...@acm.org |assad.has...@linaro.org
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=431556
--- Comment #1 from ahashmi ---
Created attachment 134815
--> https://bugs.kde.org/attachment.cgi?id=134815&action=edit
arm64 v8.2 faddp instruction support
Patch completes addition of arm64 v8.2 faddp instructions.
--
You are receiving th
https://bugs.kde.org/show_bug.cgi?id=428016
--- Comment #3 from ahashmi ---
Addition of v8.2 faddp instructions:
https://bugs.kde.org/show_bug.cgi?id=431556
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=431556
ahashmi changed:
What|Removed |Added
Attachment #134815|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=431556
--- Comment #4 from ahashmi ---
(In reply to Julian Seward from comment #3)
> The cases are distinguished as follows:
> isD == True, bitQ == 1 => 2d
> isD == False, bitQ == 1 => 4s
> isD == False, bitQ == 0
https://bugs.kde.org/show_bug.cgi?id=431556
ahashmi changed:
What|Removed |Added
Attachment #134852|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=432161
Bug ID: 432161
Summary: Addition of arm64 v8.2 FABS, FNEG and FSQRT
instructions
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Statu
https://bugs.kde.org/show_bug.cgi?id=428016
--- Comment #4 from ahashmi ---
Addition of FABS, FNEG and FSQRT instructions:
https://bugs.kde.org/show_bug.cgi?id=432161
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=432161
--- Comment #1 from ahashmi ---
Created attachment 135211
--> https://bugs.kde.org/attachment.cgi?id=135211&action=edit
Adds arm64 v8.2 FABS, FNEG and FSQRT instructions
Patch ready for review.
--
You are receiving this mail because:
https://bugs.kde.org/show_bug.cgi?id=432161
--- Comment #2 from ahashmi ---
When ready for checkin, please paste the following text as the Git commit
message:
- - - snip
432161 Addition of arm64 v8.2 FADDP, FNEG and FSQRT
This patch adds FP half-precision support for the following:
FABS
https://bugs.kde.org/show_bug.cgi?id=432161
ahashmi changed:
What|Removed |Added
Attachment #135211|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=432161
--- Comment #5 from ahashmi ---
> This isn't quite right, in that the two added lines change the behaviour for
> the fallthrough cases immediately above.
Gah, of course! Careless of me. Fixed.
> One final question: did you check tha
https://bugs.kde.org/show_bug.cgi?id=432161
ahashmi changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=432161
ahashmi changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=436411
ahashmi changed:
What|Removed |Added
Attachment #138343|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=438038
Bug ID: 438038
Summary: Addition of arm64 v8.2 FCCMP, FCCMPE and FCMEQ
instructions
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
St
https://bugs.kde.org/show_bug.cgi?id=438038
ahashmi changed:
What|Removed |Added
Assignee|jsew...@acm.org |assad.has...@linaro.org
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=428016
--- Comment #7 from ahashmi ---
Addition of arm64 v8.2 FCCMP, FCCMPE and FCMEQ instructions:
https://bugs.kde.org/show_bug.cgi?id=438038
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=436411
ahashmi changed:
What|Removed |Added
Attachment #138947|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=436411
--- Comment #7 from ahashmi ---
Landed, 3ac86151404e6d018473dc3f6cd8b933be1ee038.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=436411
ahashmi changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=436411
ahashmi changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=436873
--- Comment #3 from ahashmi ---
(In reply to Julian Seward from comment #2)
> This is structurally very similar to the scalar-version patch at
> https://bugs.kde.org/show_bug.cgi?id=436411#c2 (which is good) and
> so the same comments for t
https://bugs.kde.org/show_bug.cgi?id=436873
--- Comment #5 from ahashmi ---
(In reply to Julian Seward from comment #4)
> I didn't actually see any gating stuff in the three new frontend
> (guest_arm64_toIR.c) cases, but maybe it's done elsewhere?
Yes, the three new front-
https://bugs.kde.org/show_bug.cgi?id=436873
--- Comment #6 from ahashmi ---
Landed, f048559cb04bd88f0613d02a3b7aa5fdd075617b.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=436873
ahashmi changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=436873
ahashmi changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=414268
ahashmi changed:
What|Removed |Added
Attachment #133310|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=414268
--- Comment #6 from ahashmi ---
Thanks for reviewing/testing Mark Wielaard and Peter Maydell.
> There are two machines this seems to work correctly on:
> Arch and hwcaps: ARM64, LittleEndian, v8.1-rdm-atomics
> Arch and hwcaps: ARM64, Lit
https://bugs.kde.org/show_bug.cgi?id=413547
ahashmi changed:
What|Removed |Added
Attachment #133311|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=414268
ahashmi changed:
What|Removed |Added
Attachment #133666|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=414268
--- Comment #9 from ahashmi ---
> It's true that if you are v8.2 or better then DC CVAP is present, but this
> does not mean the converse (that if DC CVAP is present then you are v8.2). It
> is valid for a v8.1 implementation to provid
https://bugs.kde.org/show_bug.cgi?id=413547
--- Comment #4 from ahashmi ---
Created attachment 133751
--> https://bugs.kde.org/attachment.cgi?id=133751&action=edit
Adds arm64 feature detection for regression tests
Removed v8.x version detection. Now using features only.
--
You are re
https://bugs.kde.org/show_bug.cgi?id=414268
--- Comment #11 from ahashmi ---
> I know too little about arm64 to know whether or not we should care about
> these.
The current approach assumes that all base v8 h/w has the features you list.
I've not seen any base v8 h/w which is dif
https://bugs.kde.org/show_bug.cgi?id=430117
Bug ID: 430117
Summary: Implement guest Arm64/AArch64 feature detection
support for v8 instructions
Product: valgrind
Version: unspecified
Platform: Other
OS: Linu
https://bugs.kde.org/show_bug.cgi?id=414268
--- Comment #13 from ahashmi ---
> So it seems to me we also need a way to filter the attribute/feature
> registers to only advertise those armv8 instructions we actually implement.
> That is what other arches do too (see for ex
https://bugs.kde.org/show_bug.cgi?id=413547
--- Comment #6 from ahashmi ---
> Assad, am I right to understand that the comment 3 patch
> has been made redundant by the comment 4 patch?
That's correct Julian.
I should have deleted the comment 3 patch when I uploaded the latest comm
https://bugs.kde.org/show_bug.cgi?id=414268
ahashmi changed:
What|Removed |Added
Attachment #133750|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=414268
--- Comment #17 from ahashmi ---
> One tiny nit .. please #undef get_cpu_ftr and get_ftr just before the
> closing brace of the fn that defines them.
Good spot! Fixed in latest patch.
--
You are receiving this mail because:
You are watching a
https://bugs.kde.org/show_bug.cgi?id=413547
ahashmi changed:
What|Removed |Added
Attachment #133751|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=413547
--- Comment #9 from ahashmi ---
> Most of the code in this patch is, I assume, boilerplate test-support
> functions taken from other tests in none/tests/arm64.
Yes but it includes additional code for testing half-precision floating-point
instru
https://bugs.kde.org/show_bug.cgi?id=430484
--- Comment #1 from ahashmi ---
CPU implementer 0x43 and CPU part 0x0af indicates a Cavium ThunderX2.
Previous experience with DynamoRIO suggests this behaviour may be limited to
ThunderX machines only. It would be interesting to see if the same
https://bugs.kde.org/show_bug.cgi?id=369509
ahashmi changed:
What|Removed |Added
CC||assad.has...@linaro.org
Assignee|jsew
https://bugs.kde.org/show_bug.cgi?id=413547
Bug ID: 413547
Summary: regression test does not check for Arm 64 features
Product: valgrind
Version: 3.14.0
Platform: Compiled Sources
OS: Linux
Status: REPORTED
https://bugs.kde.org/show_bug.cgi?id=369509
ahashmi changed:
What|Removed |Added
Platform|Other |Compiled Sources
Version|3.12 SVN
https://bugs.kde.org/show_bug.cgi?id=369509
--- Comment #1 from ahashmi ---
Created attachment 123537
--> https://bugs.kde.org/attachment.cgi?id=123537&action=edit
Patch implements and tests Arm v8.1 LSE atomics
This patch implements ARMv8.1 memory atomics in VEX/priv/guest_arm64_toI
https://bugs.kde.org/show_bug.cgi?id=369509
ahashmi changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=413547
ahashmi changed:
What|Removed |Added
Assignee|jsew...@acm.org |assad.has...@linaro.org
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=413547
--- Comment #1 from ahashmi ---
Created attachment 123538
--> https://bugs.kde.org/attachment.cgi?id=123538&action=edit
Patch implements tests/arm64_features.c
Patch implements tests/arm64_features.c for future additions to prereq
none/test
https://bugs.kde.org/show_bug.cgi?id=413547
ahashmi changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=413634
Bug ID: 413634
Summary: ARMv8.1 arithmetic instructions are not supported
Product: valgrind
Version: 3.14.0
Platform: Compiled Sources
OS: Linux
Status: REPORTED
https://bugs.kde.org/show_bug.cgi?id=369509
ahashmi changed:
What|Removed |Added
Resolution|FIXED |---
Status|RESOLVED
https://bugs.kde.org/show_bug.cgi?id=413547
ahashmi changed:
What|Removed |Added
Status|RESOLVED|REPORTED
Resolution|FIXED
https://bugs.kde.org/show_bug.cgi?id=413547
ahashmi changed:
What|Removed |Added
CC||assad.has...@linaro.org
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=415136
--- Comment #4 from ahashmi ---
Created attachment 126175
--> https://bugs.kde.org/attachment.cgi?id=126175&action=edit
Patch tests ARM v8.1 CAS instructions
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=415136
ahashmi changed:
What|Removed |Added
Attachment #124590|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=415136
--- Comment #5 from ahashmi ---
Thanks for reviewing in detail.
Good point about splitting up the large patch. I've
uploaded the implementation and tests as 2 separate patches:
arm64_v81_cas_impl.patch
arm64_v81_cas_test.patch
> I am going
https://bugs.kde.org/show_bug.cgi?id=415136
ahashmi changed:
What|Removed |Added
Attachment #126174|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=418702
Bug ID: 418702
Summary: ARMv8.1 Paired register compare-and-swap instructions
are not supported
Product: valgrind
Version: 3.14.0
Platform: Other
OS: Linux
1 - 100 of 124 matches
Mail list logo
