https://bugs.kde.org/show_bug.cgi?id=436411

ahashmi <assad.has...@linaro.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138947|0                           |1
        is obsolete|                            |

--- Comment #6 from ahashmi <assad.has...@linaro.org> ---
Created attachment 139074
  --> https://bugs.kde.org/attachment.cgi?id=139074&action=edit
Addition of arm64 v8.2 scalar FABD, FACGE, FACGT and FADD instructions

> That all looks fine; please land.  Just before you do -- if you haven't
> already -- please though run the test cases once by hand on Memcheck,
> with --track-origins=yes, and check nothing breaks.  This has been
> known to happen in the past, at least to me :-)

Good point! And now I remember why I made the RIL change <facepalm>. When run
with --tool=memcheck:
vex: priv/host_arm64_isel.c:1292 (iselIntExpr_RIL_wrk): Assertion `ty
== Ity_I64 || ty == Ity_I32' failed.

Thanks for the out-of-band email explanation about IR traversal for isel and
the RIL functions. The latest patch includes the fix and tests pass with
--tool=memcheck and --track-origins=yes.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to