https://bugs.kde.org/show_bug.cgi?id=355684
David Edmundson changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit|
https://bugs.kde.org/show_bug.cgi?id=355684
Oleg changed:
What|Removed |Added
CC|mehanoid...@gmail.com |
--
You are receiving this mail because:
You are watchi
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #23 from Benedikt Gollatz ---
David, I believe I've addressed your points, and I've posted the new version of
the patch as review request #126336: https://git.reviewboard.kde.org/r/126336/
Rakyn, yes, I mean naive as opposed to sophisticate
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #22 from Rakyn Barker ---
Sorry no typo, i think it is just my poor english.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #21 from Rakyn Barker ---
Works fine here too.
There is a typo in na(t)ive.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #20 from David Edmundson ---
Seems OK to me.
Code review:
- I don't like how update() has a call to isTransparentImage even when we
potentially we've already done that.
can we make getImageNonComposite have a second isTransparentIm
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #19 from Benedikt Gollatz ---
Created attachment 96045
--> https://bugs.kde.org/attachment.cgi?id=96045&action=edit
Try naive conversion, only then use alternative copying method
This patch doesn't regress on my machine where the current
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #18 from Benedikt Gollatz ---
Like I said in comment #5, depth is 24 even for transparent images (bpp is 32),
both in practice and according to xcb-util-image documentation.
I'm currently preparing a patch that only uses Rakyn's conversion
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #17 from David Edmundson ---
My usual test suite is
xchat, tuxguitar, spotify
as that's:
gtk, java, qt
then I get someone else to test Steam via Wine as that normally behaves
weirdly.
I've just run the 3 above. First two are fine, spotif
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #16 from David Edmundson ---
I don't see how it's a regression? your new section only applies to images
where depth == 24, so they wouldn't have had any transparency anyway?
--
You are receiving this mail because:
You are watching all bug
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #15 from Rakyn Barker ---
Can you name a few applications which worked fine before please?
I would like to check.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #14 from Benedikt Gollatz ---
This patch is still a regression on machines where transparency worked fine in
the first place. It is visible e.g. in the hexchat icon, where
createHeuristicMap will leave the black spots in the middle of the ic
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #13 from Rakyn Barker ---
(In reply to David Edmundson from comment #9)
> Rakyn, what's your surname. I need it for the commit author.
Rakyn Barker
Added sort of artificial alpha mask to the icons,
posting the patch at this place one last t
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #12 from Rakyn Barker ---
Created attachment 96044
--> https://bugs.kde.org/attachment.cgi?id=96044&action=edit
Patch for xembed-sni-proxy-0~git20151104-ded1538
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=355684
Javier Villavicencio changed:
What|Removed |Added
CC||javier.p...@gmail.com
--
You are receiv
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #11 from ko...@indywidualni.org ---
Sorry for a duplicate I submitted. The same problem here. Arch Linux, Nvidia
driver. I will be glad to provide all the info needed to resolve it completely.
--
You are receiving this mail because:
You are
https://bugs.kde.org/show_bug.cgi?id=355684
David Edmundson changed:
What|Removed |Added
CC||ko...@indywidualni.org
--- Comment #10 from D
https://bugs.kde.org/show_bug.cgi?id=355684
fadem...@gmail.com changed:
What|Removed |Added
CC||fadem...@gmail.com
--
You are receiving th
https://bugs.kde.org/show_bug.cgi?id=355684
Oleg changed:
What|Removed |Added
CC||mehanoid...@gmail.com
--
You are receiving this mail be
https://bugs.kde.org/show_bug.cgi?id=355684
deonix changed:
What|Removed |Added
CC||deonix+...@gmail.com
--
You are receiving this mail b
https://bugs.kde.org/show_bug.cgi?id=355684
jeremy9...@gmail.com changed:
What|Removed |Added
CC||jeremy9...@gmail.com
--
You are receivin
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #9 from David Edmundson ---
Rakyn, what's your surname. I need it for the commit author.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #8 from David Edmundson ---
Patch looks good.
In theory I specific what format embedded clients should be using, but they
also seem to just ignore it.
In future, if you can put patches on git.reviewboard.kde.org it's a bit easier
for me t
https://bugs.kde.org/show_bug.cgi?id=355684
David Edmundson changed:
What|Removed |Added
CC||lukas.schneiderbauer@gmail.
https://bugs.kde.org/show_bug.cgi?id=355684
David Edmundson changed:
What|Removed |Added
CC||ad1r...@hotmail.fr
--- Comment #6 from David
https://bugs.kde.org/show_bug.cgi?id=355684
Vasyl Demin changed:
What|Removed |Added
CC||vasyl.de...@gmail.com
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=355684
d...@kaosx.us changed:
What|Removed |Added
CC||d...@kaosx.us
--
You are receiving this mail be
https://bugs.kde.org/show_bug.cgi?id=355684
darkba...@linuxsystems.it changed:
What|Removed |Added
CC||darkba...@linuxsystems.it
--
You ar
https://bugs.kde.org/show_bug.cgi?id=355684
Viorel-Cătălin Răpițeanu changed:
What|Removed |Added
CC||rapiteanu.cata...@gmail.com
--
You
https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #5 from Benedikt Gollatz ---
Using Rakyn's patch, I get visible icons with a black background on both of my
systems, i.e. including the one where icon display worked well previously. This
is because for the icons grabbed those two systems, x
https://bugs.kde.org/show_bug.cgi?id=355684
Rakyn changed:
What|Removed |Added
CC||hioeri...@gmx.net
--- Comment #4 from Rakyn ---
Create
31 matches
Mail list logo
