https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #5 from Benedikt Gollatz <bened...@gollatz.net> ---
Using Rakyn's patch, I get visible icons with a black background on both of my
systems, i.e. including the one where icon display worked well previously. This
is because for the icons grabbed those two systems, xcbImage->depth is 24,
whereas xcbImage->bpp is 32. This is in line with the comments in the
xcb-util-image source code:

  uint8_t            depth;   /**< Depth in bits. Valid depths
                   *   are 1, 4, 8, 16, 24 for z format,
                   *   1 for xy-bitmap-format, anything
                   *   for xy-pixmap-format.
                   */
  uint8_t            bpp;   /**< Storage per pixel in bits.
                 *   Must be >= depth. Valid bpp
                 *   are 1, 4, 8, 16, 24, 32 for z
                 *   format, 1 for xy-bitmap format,
                 *   anything for xy-pixmap-format.
                 */

Effectively, what Rakyn's code does in this case, is simply use
QImage::Format_RGB32 always and ignore the alpha channel completely (basically,
what I did with my hacky workaround above). Once one changes xcbImage->depth to
xcbImage->bpp in the switch statement, the old behaviour of the unpatched
version returns.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to