https://bugs.kde.org/show_bug.cgi?id=355684
--- Comment #20 from David Edmundson <k...@davidedmundson.co.uk> --- Seems OK to me. Code review: - I don't like how update() has a call to isTransparentImage even when we potentially we've already done that. can we make getImageNonComposite have a second isTransparentImage after convertFromNative, and if applicable return a null QImage. Then remove the check from update(). It groups the logic together - don't leave commented out code + //QImage image(xcbImage->data, xcbImage->width, xcbImage->height, format); - why did you remove the braces in isTransparentImage ? https://techbase.kde.org/Policies/Kdelibs_Coding_Style - make methods const -- You are receiving this mail because: You are watching all bug changes.
