[JPP-Devel] ESC for ConstrainedMultiClickTool

Hi, it's just a small thing, but it is kind of intuitive to cancel a gesture by pressing Escape, imo. To implement that for an instance of ConstrainedMultiClickTool would be quite easy by changing the current keypressed-method in line 337: public void keyPressed(KeyEvent e){

Re: [JPP-Devel] ESC for ConstrainedMultiClickTool

Unlike MultiClickTool, ConstrainedMultiClickTool ends with both double-click and right-click. Adding Escape sounds like a valid enhancement to me. regards, Larry On Mon, Feb 22, 2010 at 9:20 AM, wrote: > Hi, > > it's just a small thing, but it is kind of intuitive to cancel a gesture by > pre

Re: [JPP-Devel] delay on rendering

Good catch! I had some obvious cut and paste errors. I should be fixed now. Larry 2010/2/19 Michaël Michaud > Larry Becker a écrit : > > @Michaël, Selection Renderer's Paint now returns immediately with > > passed geometry's envelope doesn't intersect viewport. This should > > speed up your

Re: [JPP-Devel] delay on rendering

Hi, Thanks Larry, fixed. I had a quick look to check if I could do it myself, but for a few weeks, I've just enough time to test your many improvments ;-) Michaël Larry Becker a écrit : > Good catch! I had some obvious cut and paste errors. I should be > fixed now. > > Larry > > 2010/2/19 Mi

Re: [JPP-Devel] delay on rendering

Getting back to Stefan's 1000 point linestring problem, the issue here is clipping extents. As he determined, it is much faster when a large linstring is broken into 2 point linestrings. This is probably because instead of an expensive clipping operation to find the intersection of the 1000 point

Re: [JPP-Devel] delay on rendering

Yeah, I've actually played around with a "FastRectangleClipper" concept in JTS, for just this kind of problem. Although it started turning out to be almost as complex as the original intersection code, so I back-burnered it since it wasn't clear it was going to be a big win. Although perhaps t

Re: [JPP-Devel] delay on rendering

Stefan, for future reference can you send the linestring, and the viewport which causes the problem? Stefan Steiniger wrote: > mhm.. ok, so I would guess the problem is related to the size of the > geometries and its drawing? > I recently had a problem - drawing a linestring that consisted of mo

Re: [JPP-Devel] delay on rendering

Better send it to me too. All the cases I've found in the wild render very quickly. See the attached for an example. Larry On Mon, Feb 22, 2010 at 4:13 PM, Martin Davis wrote: > Stefan, for future reference can you send the linestring, and the > viewport which causes the problem? > > Stefan S

Re: [JPP-Devel] delay on rendering

Yeah, it seems to me that I haven't seen much speed impact from rendering fairly large linestrings. I suppose it's possible that if the linestring was really complex the intersection() computation might be slow, however. In any case, computing a full intersection() is definitely doing more wo

Re: [JPP-Devel] delay on rendering

If the problem is what we have been assuming, I see where Martin's algorithm could be applied: com.vividsolutions.jump.workbench.ui.renderer.style.StyleUtil#toShape() We could do a conversion of large linestrings whose bounding boxes contain the viewport, to "rough clip" MultiLineStrings instead

Re: [JPP-Devel] ESC for ConstrainedMultiClickTool

thanks Volker.. "we" should commit that ;) tmrw. Larry Becker schrieb: > Unlike MultiClickTool, ConstrainedMultiClickTool ends with both > double-click and right-click. Adding Escape sounds like a valid > enhancement to me. > > regards, > Larry > > On Mon, Feb 22, 2010 at 9:20 AM,