chia7712 commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1593681340
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -410,6 +448,432 @@ public void testOptionEntityTypeNames() {
doTestOptionEntityTypeNames(f
sidyag commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1593693523
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3037,14 +3062,71 @@ class KafkaApisTest extends Logging {
}
@Test
- def shouldAppendToLogOn
chia7712 commented on code in PR #15868:
URL: https://github.com/apache/kafka/pull/15868#discussion_r1593737692
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/SessionedProtocolIntegrationTest.java:
##
@@ -115,11 +112,11 @@ public void ensureInternalEndpoin
lucasbru commented on code in PR #15882:
URL: https://github.com/apache/kafka/pull/15882#discussion_r1593738288
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -544,69 +585,78 @@ private void handleReassignedActiveTask(final Task tas
chia7712 commented on PR #15890:
URL: https://github.com/apache/kafka/pull/15890#issuecomment-2100176348
@gongxuanzhang thanks for this patch. Could you take a look at
https://issues.apache.org/jira/browse/KAFKA-10787? Personally, we should
introduce the new checkstyle file. And then we app
gaurav-narula commented on PR #15886:
URL: https://github.com/apache/kafka/pull/15886#issuecomment-2100220810
> Before merging this PR, I want to know which `timerTask` gets hanging when
shutdown. Do you have any idea?
I don't unfortunately but I see you're trying to investigate that
gongxuanzhang commented on PR #15890:
URL: https://github.com/apache/kafka/pull/15890#issuecomment-2100235766
@chia7712 Yes i do .
I think these changes, though numerous, are still simple changes.
Even with the introduction of new checkstyle file , the style we pursue is
always "unit
chia7712 commented on PR #15890:
URL: https://github.com/apache/kafka/pull/15890#issuecomment-2100256001
> In this PR I have followed the checkstyle ModifierOrder rule and passed
the self-test.
We need the checkstyle first, because it is hard to review those huge
changes by human eye
cadonna commented on code in PR #15882:
URL: https://github.com/apache/kafka/pull/15882#discussion_r1593835933
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -544,69 +585,78 @@ private void handleReassignedActiveTask(final Task task
cadonna commented on code in PR #15882:
URL: https://github.com/apache/kafka/pull/15882#discussion_r1593836743
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -365,17 +365,47 @@ public void handleAssignment(final Map> activeTasks,
chirag-wadhwa5 opened a new pull request, #15895:
URL: https://github.com/apache/kafka/pull/15895
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
chirag-wadhwa5 closed pull request #15895: AKCORE-138: Integrated logic for
handling maxDeliveryCount and moving SPSO with releaseAcquisitionLockOnTimeout
in Share Partition
URL: https://github.com/apache/kafka/pull/15895
--
This is an automated message from the Apache Git Service.
To respon
cadonna opened a new pull request, #15896:
URL: https://github.com/apache/kafka/pull/15896
Removes the unused remove operation from the state updater
that asynchronously removed tasks and put them into an
output queue.
### Committer Checklist (excluded from commit message)
- [
lucasbru commented on code in PR #15882:
URL: https://github.com/apache/kafka/pull/15882#discussion_r1593900987
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -544,69 +585,78 @@ private void handleReassignedActiveTask(final Task tas
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1593917049
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -53,14 +52,15 @@ public class ClusterConfig {
private final Map adminClientProperties;
private
lucasbru commented on code in PR #15894:
URL: https://github.com/apache/kafka/pull/15894#discussion_r1593911025
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -954,8 +954,7 @@ private void recycleTaskFromStateUpdater(final Task task
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1593920627
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -153,15 +148,19 @@ public Map>
perBrokerOverrideProperties() {
return perBrokerOverrideProperti
dajac commented on PR #15727:
URL: https://github.com/apache/kafka/pull/15727#issuecomment-2100429869
@riedelmax Would you have time to address the last remaining comment? It
would be great if we could merge it.
--
This is an automated message from the Apache Git Service.
To respond to th
nizhikov commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1593927539
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -410,6 +448,432 @@ public void testOptionEntityTypeNames() {
doTestOptionEntityTypeNames(f
gongxuanzhang commented on PR #15890:
URL: https://github.com/apache/kafka/pull/15890#issuecomment-2100450694
@chia7712
I will resubmit my PR, introduce the new checkstyle and re-modify the PR
according to the module.
Thank you for your patience and best wishes
--
This is a
jlprat commented on PR #15880:
URL: https://github.com/apache/kafka/pull/15880#issuecomment-2100463993
I checked the test failures and they all pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
jlprat merged PR #15880:
URL: https://github.com/apache/kafka/pull/15880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
C0urante commented on PR #14372:
URL: https://github.com/apache/kafka/pull/14372#issuecomment-2100483882
@vamossagar12 The ticket description is a little thin on details. What is
causing the work thread to die?
In general, I'm not really a fan of this approach since it doesn't provide
Prashant-Jagtap commented on PR #15644:
URL: https://github.com/apache/kafka/pull/15644#issuecomment-2100499643
Hi @mimaison
The challenges seen with ppc64le are not encountered on s390x. We have added
s390x build stage in the existing pipeline, so it'll run concurrently without
needing
johnnychhsu commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2100511022
run `./gradlew clean core:test --tests ClusterTestExtensionsTest --tests
ClusterConfigTest` and passed
--
This is an automated message from the Apache Git Service.
To respond to the
cadonna commented on code in PR #15894:
URL: https://github.com/apache/kafka/pull/15894#discussion_r1593985438
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -149,14 +149,25 @@ public void run() {
} catch (final
cadonna commented on code in PR #15894:
URL: https://github.com/apache/kafka/pull/15894#discussion_r1593985778
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -149,14 +149,25 @@ public void run() {
} catch (final
cadonna commented on code in PR #15894:
URL: https://github.com/apache/kafka/pull/15894#discussion_r1593990443
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -787,9 +796,12 @@ public DefaultStateUpdater(final String name,
cadonna commented on code in PR #15894:
URL: https://github.com/apache/kafka/pull/15894#discussion_r1593991574
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -954,8 +954,7 @@ private void recycleTaskFromStateUpdater(final Task task,
cadonna commented on code in PR #15882:
URL: https://github.com/apache/kafka/pull/15882#discussion_r1593995260
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -544,69 +585,78 @@ private void handleReassignedActiveTask(final Task task
lucasbru commented on code in PR #15894:
URL: https://github.com/apache/kafka/pull/15894#discussion_r1594047844
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -787,9 +796,12 @@ public DefaultStateUpdater(final String name,
soarez commented on PR #15866:
URL: https://github.com/apache/kafka/pull/15866#issuecomment-2100604396
@showuon this one is really tiny and straightforward, can you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
FrankYang0529 opened a new pull request, #15897:
URL: https://github.com/apache/kafka/pull/15897
Both ClusterType#ALL and ClusterType#DEFAULT are a kind of "tag" instead of
true "type". It seems to me they can be removed by using Array. For example:
ClusterType#ALL -> {Type.ZK, Type.K
vamossagar12 commented on PR #14372:
URL: https://github.com/apache/kafka/pull/14372#issuecomment-2100630568
Thanks @C0urante , I updated the ticket description with examples of
exceptions which leads to this scenario. It is mainly for scenarios like
`org.apache.kafka.common.errors.SslAuthe
emitskevich-blp commented on code in PR #15889:
URL: https://github.com/apache/kafka/pull/15889#discussion_r1593310007
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -106,44 +106,55 @@ public String toString() {
public abstract doub
KevinZTW commented on code in PR #15884:
URL: https://github.com/apache/kafka/pull/15884#discussion_r1594136562
##
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##
@@ -160,28 +154,26 @@ private String outputWithoutEpoch(String output) {
int pos = o
vamossagar12 opened a new pull request, #15898:
URL: https://github.com/apache/kafka/pull/15898
In IncrementalCooperativeAssignor in Connect, during
`performTaskAssignment`, there is a step where it finds the newly created
connectors and tasks
[here](https://github.com/apache/kafka/blob/2a
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594156634
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -1840,28 +1840,28 @@ public void
testOperationsBySubscribingConsumerWithDefaul
brandboat opened a new pull request, #15899:
URL: https://github.com/apache/kafka/pull/15899
related to https://issues.apache.org/jira/browse/KAFKA-16595
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594200503
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -3253,13 +3252,13 @@ public void
testProducerBatchRetriesWhenPartitionLeade
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594199948
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -3232,7 +3231,7 @@ public void
testProducerBatchRetriesWhenPartitionLeaderC
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594213570
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -3492,9 +3491,9 @@ private void verifyErrorMessage(ProduceResponse response,
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594231539
##
clients/src/test/java/org/apache/kafka/common/utils/ImplicitLinkedHashMultiCollectionTest.java:
##
@@ -114,11 +114,11 @@ public void testEnlargement() {
lianetm commented on PR #15408:
URL: https://github.com/apache/kafka/pull/15408#issuecomment-2100868214
This LGTM @cadonna , left comment above discarding one of my messages, the
test is clear enough. Only
[this](https://github.com/apache/kafka/pull/15408#discussion_r1591300734) other
nit
clolov commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2100946258
I will look at `kafka.server.ApiVersionsRequestTest` failures tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jolshan commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1594302111
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3036,15 +3061,32 @@ class KafkaApisTest extends Logging {
assertEquals(expectedErrors, markers
jolshan commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1594302492
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2822,6 +2822,31 @@ class KafkaApisTest extends Logging {
() => kafkaApis.handleWriteTxnMarke
junrao commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1594333143
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -404,9 +414,7 @@ class LogValidatorTest {
assertEquals(now + 1, validatingResults.maxTimestampMs
junrao commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1594333143
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -404,9 +414,7 @@ class LogValidatorTest {
assertEquals(now + 1, validatingResults.maxTimestampMs
nizhikov commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1594336755
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -410,6 +448,432 @@ public void testOptionEntityTypeNames() {
doTestOptionEntityTypeNames(f
AyoubOm opened a new pull request, #15900:
URL: https://github.com/apache/kafka/pull/15900
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
jolshan merged PR #15892:
URL: https://github.com/apache/kafka/pull/15892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
lianetm commented on code in PR #15869:
URL: https://github.com/apache/kafka/pull/15869#discussion_r1594393442
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -260,6 +260,7 @@ private void process(final
ConsumerRebalanceListen
jolshan commented on code in PR #15888:
URL: https://github.com/apache/kafka/pull/15888#discussion_r1594398385
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -468,8 +467,24 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
- val producerExpireCheck: Sch
jolshan commented on PR #15891:
URL: https://github.com/apache/kafka/pull/15891#issuecomment-2101084506
Thanks this was bothering me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
jolshan commented on PR #15888:
URL: https://github.com/apache/kafka/pull/15888#issuecomment-2101104028
Do we have a test that the config persists on restart of the broker? We had
a small bug in the implementation of the expiration time and had to do a
followup. Perhaps the test can be mode
lianetm commented on code in PR #15869:
URL: https://github.com/apache/kafka/pull/15869#discussion_r1594430619
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1968,7 +1972,7 @@ SubscriptionState subscriptions() {
}
lianetm commented on PR #15869:
URL: https://github.com/apache/kafka/pull/15869#issuecomment-2101139225
Hey @Phuc-Hong-Tran , thanks for the changes, left some comments. Could we
add unit tests for this? Definitely helpful to validate the main goal of this
patch, which is to ensure the rege
matthiaskraaz opened a new pull request, #15901:
URL: https://github.com/apache/kafka/pull/15901
After a short discussion with Sophie Blee-Goldman (see
https://lists.apache.org/thread/x4szs4szq0gq1twrpdv0fppzr92rr623), I dived into
a few days of debugging and testing with a network connecti
junrao commented on code in PR #15859:
URL: https://github.com/apache/kafka/pull/15859#discussion_r1593188110
##
raft/src/main/java/org/apache/kafka/raft/ElectionState.java:
##
@@ -16,46 +16,44 @@
*/
package org.apache.kafka.raft;
+import java.util.List;
+import java.util.O
nizhikov commented on PR #15873:
URL: https://github.com/apache/kafka/pull/15873#issuecomment-2101427991
JFYI I’m offline till Monday.
Will fix all possible comments after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
jeffkbkim opened a new pull request, #15902:
URL: https://github.com/apache/kafka/pull/15902
write events create and add a TimerTask to schedule the timeout operation.
The issue is that we pile up the number of timer tasks which are essentially
no-ops if replication was successful. They sta
rreddy-22 opened a new pull request, #15903:
URL: https://github.com/apache/kafka/pull/15903
During performance testing we realized the the rack aware portion of the
code is not performing as expected. We are going to temporarily remove it for
3.8 and re-analyze and add it after more thorou
emitskevich-blp commented on code in PR #15889:
URL: https://github.com/apache/kafka/pull/15889#discussion_r1593310007
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -106,44 +106,55 @@ public String toString() {
public abstract doub
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2101717211
@lianetm & @philipnee If you have a moment, please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1594849626
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -404,9 +414,7 @@ class LogValidatorTest {
assertEquals(now + 1, validatingResults.maxTimestamp
chia7712 opened a new pull request, #15904:
URL: https://github.com/apache/kafka/pull/15904
from: https://github.com/apache/kafka/pull/15621#discussion_r1592859538
This is a follow-up of #15621
### Committer Checklist (excluded from commit message)
- [ ] Verify design and imp
artemlivshits commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1591704034
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -258,6 +259,13 @@ public enum MetadataVersion {
this.didMetadat
FrankYang0529 commented on code in PR #15872:
URL: https://github.com/apache/kafka/pull/15872#discussion_r1594865250
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -57,28 +56,47 @@
import static org.juni
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1594882664
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -74,16 +75,18 @@ static void generator(ClusterGenerator clusterG
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1594884853
##
server-common/src/main/java/org/apache/kafka/server/common/FeatureVersion.java:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
chia7712 commented on code in PR #15884:
URL: https://github.com/apache/kafka/pull/15884#discussion_r1594885585
##
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##
@@ -47,22 +47,16 @@
@ClusterTestDefaults(clusterType = Type.KRAFT)
Review Comment:
It se
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1594885949
##
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1594886684
##
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1594889173
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -258,6 +259,13 @@ public enum MetadataVersion {
this.didMetadataChang
chia7712 commented on code in PR #15899:
URL: https://github.com/apache/kafka/pull/15899#discussion_r1594887215
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,32 +17,72 @@
package kafka.server
-import kafka.test.ClusterInstance
+import kafk
brandboat closed pull request #15899: KAFKA-16595: Introduce ClusterTemplate in
ClusterTests
URL: https://github.com/apache/kafka/pull/15899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
brandboat commented on code in PR #15899:
URL: https://github.com/apache/kafka/pull/15899#discussion_r1594893021
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,32 +17,72 @@
package kafka.server
-import kafka.test.ClusterInstance
+import kaf
chia7712 commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1594892743
##
tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java:
##
@@ -73,7 +74,7 @@ public void testDescribeQuorumReplicationSuccessful() throws
Interr
chia7712 merged PR #15900:
URL: https://github.com/apache/kafka/pull/15900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
ableegoldman commented on code in PR #15887:
URL: https://github.com/apache/kafka/pull/15887#discussion_r1594892242
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundat
chia7712 commented on PR #15836:
URL: https://github.com/apache/kafka/pull/15836#issuecomment-2101862846
@gaurav-narula Could you take a look at those failed tests? I feel they are
unrelated to this PR, so +1
--
This is an automated message from the Apache Git Service.
To respond to the m
github-actions[bot] commented on PR #15345:
URL: https://github.com/apache/kafka/pull/15345#issuecomment-2101870085
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
dajac commented on code in PR #15902:
URL: https://github.com/apache/kafka/pull/15902#discussion_r1594944744
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1083,6 +1094,11 @@ public void run() {
public void
BOOTMGR opened a new pull request, #15905:
URL: https://github.com/apache/kafka/pull/15905
`kafka-consumer-perf-test` is a great tool to quickly check raw consumer
performance. Currently, It subscribes to all the partitions and gives overall
cluster performance, however If we want to test p
FrankYang0529 commented on PR #15897:
URL: https://github.com/apache/kafka/pull/15897#issuecomment-2102406354
Hi @chia7712, I change `List` to `Set`.
For merging `ClusterTest` in `MetadataQuorumCommandTest.java`. I think it
can't work, because `cluster.config().clusterTypes().contains
chia7712 commented on PR #15897:
URL: https://github.com/apache/kafka/pull/15897#issuecomment-2102437430
> We may need a new attribute in ClusterInstance, so we can know whether the
cluster is CO_KRAFT or KRAFT.
you are right.
--
This is an automated message from the Apache Git Ser
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1595357027
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java:
##
@@ -242,6 +242,19 @@ public Response putConnectorConfig(final
chia7712 merged PR #15872:
URL: https://github.com/apache/kafka/pull/15872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1595365475
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##
@@ -773,6 +773,41 @@ public void
testDeleteConnectorCreatedWit
ivanyu commented on PR #6934:
URL: https://github.com/apache/kafka/pull/6934#issuecomment-2102553283
Thank you @C0urante. I updated the description (please tell me if I need to
add more) there.
Do you want to me squash the fixups or you squash when merge?
--
This is an automated messag
chia7712 merged PR #15878:
URL: https://github.com/apache/kafka/pull/15878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
johnnychhsu opened a new pull request, #15906:
URL: https://github.com/apache/kafka/pull/15906
## Context
from DistributedHerder, the comment
> Similar to handling HTTP requests, config changes which are observed
asynchronously by polling the config log are
> batched for handli
kamalcph commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1595488671
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##
@@ -176,17 +178,18 @@ private void waitUnt
C0urante commented on code in PR #15906:
URL: https://github.com/apache/kafka/pull/15906#discussion_r1595516663
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -260,9 +261,8 @@ public void testMultiNodeCluste
C0urante commented on code in PR #15906:
URL: https://github.com/apache/kafka/pull/15906#discussion_r1595528749
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -353,6 +353,9 @@ private void
awaitTaskConfigu
jeffkbkim commented on code in PR #15902:
URL: https://github.com/apache/kafka/pull/15902#discussion_r1595531424
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1083,6 +1094,11 @@ public void run() {
public v
jsancio commented on code in PR #15859:
URL: https://github.com/apache/kafka/pull/15859#discussion_r1595568006
##
raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java:
##
@@ -64,6 +64,43 @@ public Optional voterAddress(int voter,
String listener) {
.fla
jsancio commented on code in PR #15859:
URL: https://github.com/apache/kafka/pull/15859#discussion_r1595568368
##
raft/src/main/java/org/apache/kafka/raft/CandidateState.java:
##
@@ -51,14 +54,27 @@ public class CandidateState implements EpochState {
protected CandidateStat
jsancio commented on code in PR #15859:
URL: https://github.com/apache/kafka/pull/15859#discussion_r1595578267
##
raft/src/main/java/org/apache/kafka/raft/ElectionState.java:
##
@@ -16,46 +16,44 @@
*/
package org.apache.kafka.raft;
+import java.util.List;
+import java.util.
701 - 800 of 75134 matches
Mail list logo
