jolshan commented on code in PR #15888:
URL: https://github.com/apache/kafka/pull/15888#discussion_r1594398385
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -468,8 +467,24 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
- val producerExpireCheck: ScheduledFuture[_] =
scheduler.schedule("PeriodicProducerExpirationCheck", () =>
removeExpiredProducers(time.milliseconds),
- producerIdExpirationCheckIntervalMs, producerIdExpirationCheckIntervalMs)
+ var producerExpireCheck: ScheduledFuture[_] =
scheduleProducerExpireCheck(producerStateManager.producerStateManagerConfig())
+
+ def restartProducerExpireCheck(producerStateManagerConfig:
ProducerStateManagerConfig): Unit = {
Review Comment:
nice. This was not too complicated 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
