lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594156634
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -1840,28 +1840,28 @@ public void
testOperationsBySubscribingConsumerWithDefaultGroupId(GroupProtocol
// OK, expected
}
- try (KafkaConsumer<byte[], byte[]> consumer =
newConsumer(groupProtocol, (String) null)) {
+ try (KafkaConsumer<byte[], byte[]> consumer =
newConsumer(groupProtocol, null)) {
consumer.subscribe(Collections.singleton(topic));
fail("Expected an InvalidGroupIdException");
} catch (InvalidGroupIdException e) {
// OK, expected
}
Review Comment:
Since we're cleaning up this, maybe just `assertThrows`? (same for the
following 3 `try`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
