guozhangwang commented on PR #12654:
URL: https://github.com/apache/kafka/pull/12654#issuecomment-1405370976
This PR is now ready for review @cadonna @lucasbru
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
vamossagar12 commented on code in PR #13095:
URL: https://github.com/apache/kafka/pull/13095#discussion_r1088161412
##
tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
vamossagar12 commented on code in PR #13095:
URL: https://github.com/apache/kafka/pull/13095#discussion_r1088168895
##
tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1405382219
> Sorry for the delay. Thanks for the PR, I left a few minor suggestions.
No problem! I addressed the comments. Thanks for the review.
--
This is an automated message from th
big-andy-coates commented on PR #7414:
URL: https://github.com/apache/kafka/pull/7414#issuecomment-1405439947
FYI, this is probably being fixed because of this:
https://ossindex.sonatype.org/vulnerability/sonatype-2019-0422?component-type=maven&component-name=org.apache.kafka%2Fkafka-streams
mimaison merged PR #13131:
URL: https://github.com/apache/kafka/pull/13131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
beardt opened a new pull request, #13168:
URL: https://github.com/apache/kafka/pull/13168
Added try/catch within Abstract::getConfigInstances to enable clean up any
available instances (interceptors in this case) resources.
### Committer Checklist (excluded from commit message)
-
vcrfxia commented on PR #13142:
URL: https://github.com/apache/kafka/pull/13142#issuecomment-1405766435
Thanks @mjsax , fixed now. Wasn't sure whether it'd be better to add a dummy
close callback just for the single test or for all tests (even the ones which
do not call close(), and therefo
vcrfxia commented on PR #13143:
URL: https://github.com/apache/kafka/pull/13143#issuecomment-1405780466
Thanks. Needed to update the test for the latest changes which now set
`isOpen = true` always. Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the
mjsax commented on PR #13142:
URL: https://github.com/apache/kafka/pull/13142#issuecomment-1405947882
Checkstyle error:
```
> Task :streams:checkstyleTest
[2023-01-26T22:45:54.179Z] [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-13142/streams/sr
mjsax commented on PR #13143:
URL: https://github.com/apache/kafka/pull/13143#issuecomment-1405948413
Checkstyle error:
```
> Task :streams:checkstyleTest
[2023-01-26T23:03:19.137Z] [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-13143/streams/sr
mimaison commented on PR #13060:
URL: https://github.com/apache/kafka/pull/13060#issuecomment-1406261073
Thanks for the PR! We're moving JmxTool to the tools module in
https://github.com/apache/kafka/pull/13136. Let's do the rewrite/move first,
then I'll take a look at this PR.
--
This i
fvaleri commented on PR #13136:
URL: https://github.com/apache/kafka/pull/13136#issuecomment-1406316345
@mimaison I've rebased and added some tests.
This is now ready for another review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Hangleton commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1088898259
##
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java:
##
@@ -160,7 +160,7 @@ private void maybeThrowCancellationException(Throwable
cause)
Hangleton commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1088918527
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis
Cerchie commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1088951633
##
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java:
##
@@ -160,7 +160,7 @@ private void maybeThrowCancellationException(Throwable
cause) {
Hangleton commented on code in PR #13162:
URL: https://github.com/apache/kafka/pull/13162#discussion_r1088967227
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel
destChannel,
*
dpcollins-google commented on code in PR #13162:
URL: https://github.com/apache/kafka/pull/13162#discussion_r1089108841
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel
destChannel,
mimaison opened a new pull request, #13170:
URL: https://github.com/apache/kafka/pull/13170
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
cmccabe commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1089233294
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis()
cmccabe commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1089236363
##
server-common/src/main/java/org/apache/kafka/server/util/FutureUtils.java:
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
hachikuji commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089298321
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1153,6 +1157,8 @@ object KafkaConfig {
.define(MetadataMaxRetentionBytesProp, LONG,
Defaults.Met
cmccabe commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089313497
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis()
cmccabe commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089352604
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1153,6 +1157,8 @@ object KafkaConfig {
.define(MetadataMaxRetentionBytesProp, LONG,
Defaults.Metad
hachikuji commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089358150
##
server-common/src/main/java/org/apache/kafka/server/util/Deadline.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
cmccabe commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089524442
##
server-common/src/main/java/org/apache/kafka/server/util/Deadline.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
cmccabe commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089524563
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis()
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1089556608
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java:
##
@@ -0,0 +1,523 @@
+/*
+ * Licensed to the Apache S
cmccabe commented on PR #13114:
URL: https://github.com/apache/kafka/pull/13114#issuecomment-1407227921
Can we have a test in `ControllerApisTest`? These are mainly to verify that
our authorization logic is sound.
--
This is an automated message from the Apache Git Service.
To respond to
cmccabe commented on PR #13114:
URL: https://github.com/apache/kafka/pull/13114#issuecomment-1407228067
We should not be changing `BrokerMetadataSnapshotterTest.scala` here --
doesn't seem needed
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
cmccabe commented on PR #13114:
URL: https://github.com/apache/kafka/pull/13114#issuecomment-1407228326
* We need a `ScramControlManagerTest` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1407268172
> EndToEndLatencyService
Thanks @mimaison . Actually I lack some context here. The class,
`TestEndToEndLatency` was renamed to `EndToEndLatency` with this very old PR:
https:/
vamossagar12 commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1089609015
##
build.gradle:
##
@@ -1757,6 +1757,7 @@ project(':tools') {
archivesBaseName = "kafka-tools"
dependencies {
+implementation project(':core')
Review
vamossagar12 commented on PR #13127:
URL: https://github.com/apache/kafka/pull/13127#issuecomment-1407272563
> @vamossagar12 Thanks for the PR!
>
> I had one major comment.
Thanks @cadonna . I think that comment has been addressed now based on the
conversation.
--
This is an
fqaiser94 commented on code in PR #10747:
URL: https://github.com/apache/kafka/pull/10747#discussion_r1089848517
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedDeserializer.java:
##
@@ -44,18 +42,30 @@ public void setIfUnset(final SerdeGetter getter)
fqaiser94 commented on code in PR #10747:
URL: https://github.com/apache/kafka/pull/10747#discussion_r1089849065
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java:
##
@@ -45,34 +47,85 @@ public void setIfUnset(final SerdeGetter getter) {
fvaleri opened a new pull request, #13171:
URL: https://github.com/apache/kafka/pull/13171
This also includes a new test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
fvaleri commented on PR #13171:
URL: https://github.com/apache/kafka/pull/13171#issuecomment-1408394028
@mimaison @OmniaGM @tombentley this is ready for review if any of you have
time. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
mimaison commented on PR #13148:
URL: https://github.com/apache/kafka/pull/13148#issuecomment-1408432038
Thanks for the PR @C0urante ! I think none of the tests actually reproduce
the issue, I can get them to pass (minus the verify for the new methods) with
the previous logic. However I don
mimaison commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1408441506
I simply meant that it looks like some changes in the system tests are
required too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
tinaselenge opened a new pull request, #13172:
URL: https://github.com/apache/kafka/pull/13172
Support delegationToken APIs in MockAdminClient.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build s
OmniaGM commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1090495143
##
tools/src/main/java/org/apache/kafka/tools/StateChangeLogMerger.java:
##
@@ -0,0 +1,329 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
OmniaGM commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1090471930
##
tools/src/main/java/org/apache/kafka/tools/StateChangeLogMerger.java:
##
@@ -0,0 +1,329 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1408469183
> I simply meant that it looks like some changes in the system tests are
required too.
Got it. Thanks for the confirmation.
--
This is an automated message from the Apache
Hangleton commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1090646744
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis
tledkov opened a new pull request, #13173:
URL: https://github.com/apache/kafka/pull/13173
Demonstrates the behavior of integration test that is used the
`EmbeddedKafkaCluster`.
In case a test suite contains a lot of tests that creates/deletes lot of
topics the process if finished with t
fvaleri commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1090657703
##
tools/src/main/java/org/apache/kafka/tools/StateChangeLogMerger.java:
##
@@ -0,0 +1,329 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Hangleton commented on code in PR #13162:
URL: https://github.com/apache/kafka/pull/13162#discussion_r1090683591
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel
destChannel,
*
Hangleton commented on code in PR #13162:
URL: https://github.com/apache/kafka/pull/13162#discussion_r1090683591
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel
destChannel,
*
mimaison opened a new pull request, #13174:
URL: https://github.com/apache/kafka/pull/13174
- Remove unused methods
- Cleanup syntax
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
mimaison commented on code in PR #13174:
URL: https://github.com/apache/kafka/pull/13174#discussion_r1090688740
##
clients/src/main/java/org/apache/kafka/common/utils/MappedIterator.java:
##
@@ -32,12 +32,12 @@ public MappedIterator(Iterator
underlyingIterator, Function m
fvaleri commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1090717453
##
server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java:
##
@@ -100,4 +104,17 @@ public static void prettyPrintTable(
printRow(columnLength
Hangleton commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1090718859
##
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java:
##
@@ -160,7 +160,7 @@ private void maybeThrowCancellationException(Throwable
cause)
fvaleri commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1090717453
##
server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java:
##
@@ -100,4 +104,17 @@ public static void prettyPrintTable(
printRow(columnLength
fvaleri commented on PR #13171:
URL: https://github.com/apache/kafka/pull/13171#issuecomment-1408759302
Hi Omnia, thanks for the review.
I've addressed some of your comments and answered the others.
--
This is an automated message from the Apache Git Service.
To respond to the messa
dpcollins-google commented on code in PR #13162:
URL: https://github.com/apache/kafka/pull/13162#discussion_r1090733865
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel
destChannel,
pprovenzano commented on PR #13114:
URL: https://github.com/apache/kafka/pull/13114#issuecomment-1408812047
>
The changes to `BrokerMetadataSnapshotterTest.scala` are needed and small.
The size of the SCRAM records is larger than 1024 bytes and so I increased it
to 4096 bytes in the
C0urante commented on PR #13148:
URL: https://github.com/apache/kafka/pull/13148#issuecomment-1408822680
@mimaison Yeah, that's correct. I'm hoping that the `verify` calls for
`plugins::withClassLoader` will be sufficient for now. I've also added a small
comment explaining why we perform th
fvaleri commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1090717453
##
server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java:
##
@@ -100,4 +104,17 @@ public static void prettyPrintTable(
printRow(columnLength
OmniaGM commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1090808339
##
server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java:
##
@@ -100,4 +104,17 @@ public static void prettyPrintTable(
printRow(columnLength
electrical commented on PR #12358:
URL: https://github.com/apache/kafka/pull/12358#issuecomment-1408885972
We are hitting the same issue while we want to switch from MM1 to MM2.
Would be great to see this fixed so we can switch over
Thanks!
--
This is an automated message from th
fvaleri commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1090852796
##
server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java:
##
@@ -100,4 +104,17 @@ public static void prettyPrintTable(
printRow(columnLength
fvaleri commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1090852796
##
server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java:
##
@@ -100,4 +104,17 @@ public static void prettyPrintTable(
printRow(columnLength
mimaison commented on PR #13148:
URL: https://github.com/apache/kafka/pull/13148#issuecomment-1408944140
Thanks @C0urante, I just wanted to clarify this was indeed the intent. Like
you, I don't think we necessarily need system tests for this.
--
This is an automated message from the Apach
fvaleri commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1090852796
##
server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java:
##
@@ -100,4 +104,17 @@ public static void prettyPrintTable(
printRow(columnLength
mimaison merged PR #13148:
URL: https://github.com/apache/kafka/pull/13148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
ijuma commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1408995921
Thanks for doing this. One thing I didn't understand is why the shared
classes are in `server-common` instead of `tools`. Is this because `core` also
uses the class?
--
This is an automa
C0urante commented on PR #13148:
URL: https://github.com/apache/kafka/pull/13148#issuecomment-1409001897
Thanks Mickael!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mjsax opened a new pull request, #13175:
URL: https://github.com/apache/kafka/pull/13175
This PR adds a safe-guard for divide-by-zero. While `totalCapacity` can
never be zero, an explicit error message is desirable.
--
This is an automated message from the Apache Git Service.
To respond t
divijvaidya commented on PR #12620:
URL: https://github.com/apache/kafka/pull/12620#issuecomment-1409015865
> It may make sense to wait a bit and go straight to 3.8.1 (once that's
released
Note that Zk 3.8.1 has released in Jan 2023. @ijuma, do you think it is the
right time for us to mo
ijuma commented on PR #12620:
URL: https://github.com/apache/kafka/pull/12620#issuecomment-1409023494
@divijvaidya Yes, I think that would make sense. That should tide us over
until the KRaft transition happens.
--
This is an automated message from the Apache Git Service.
To respond to th
ijuma commented on PR #12620:
URL: https://github.com/apache/kafka/pull/12620#issuecomment-1409028650
A couple of things to consider:
1. If we upgrade the zk server to 3.8.1, what is the impact on the zk
clients. That is, what's the earliest zk client version that is supported by
the 3.8
C0urante commented on code in PR #13137:
URL: https://github.com/apache/kafka/pull/13137#discussion_r1090935837
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java:
##
@@ -255,13 +287,26 @@ private void addHerder(SourceAndTarget sourceAndTarget) {
C0urante commented on code in PR #13137:
URL: https://github.com/apache/kafka/pull/13137#discussion_r1090935837
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java:
##
@@ -255,13 +287,26 @@ private void addHerder(SourceAndTarget sourceAndTarget) {
C0urante commented on code in PR #13137:
URL: https://github.com/apache/kafka/pull/13137#discussion_r1090936585
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java:
##
@@ -119,7 +126,16 @@ public class MirrorMaker {
public MirrorMaker(MirrorMake
cmccabe commented on code in PR #13159:
URL: https://github.com/apache/kafka/pull/13159#discussion_r1090937161
##
metadata/src/main/java/org/apache/kafka/image/ConfigurationsImage.java:
##
@@ -61,6 +61,15 @@ public Properties configProperties(ConfigResource
configResource) {
cmccabe commented on code in PR #13159:
URL: https://github.com/apache/kafka/pull/13159#discussion_r1090937902
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -403,7 +404,7 @@ public void run() throws Exception {
At
cmccabe commented on code in PR #13159:
URL: https://github.com/apache/kafka/pull/13159#discussion_r1090939081
##
core/src/main/scala/kafka/migration/MigrationPropagator.scala:
##
@@ -118,9 +124,8 @@ class MigrationPropagator(
}
}
-// If there are new brokers (
C0urante commented on code in PR #13137:
URL: https://github.com/apache/kafka/pull/13137#discussion_r1090943031
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -0,0 +1,228 @@
+/*
+ * Licensed to the Apache So
mumrah commented on code in PR #13159:
URL: https://github.com/apache/kafka/pull/13159#discussion_r1090943050
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -403,7 +404,7 @@ public void run() throws Exception {
Ato
mumrah commented on code in PR #13159:
URL: https://github.com/apache/kafka/pull/13159#discussion_r1090944813
##
core/src/main/scala/kafka/migration/MigrationPropagator.scala:
##
@@ -118,9 +124,8 @@ class MigrationPropagator(
}
}
-// If there are new brokers (i
fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1409100823
> Thanks for doing this. One thing I didn't understand is why the shared
classes are in `server-common` instead of `tools`. Is this because `core` also
uses the class?
Good questio
Hangleton commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1090718859
##
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java:
##
@@ -160,7 +160,7 @@ private void maybeThrowCancellationException(Throwable
cause)
Hangleton commented on code in PR #13162:
URL: https://github.com/apache/kafka/pull/13162#discussion_r1091027869
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel
destChannel,
*
ijuma commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1409209835
Got it, so it's useful for `main` methods too - not just CLI tools. Then
it's fine for it to be in `server-common`.
--
This is an automated message from the Apache Git Service.
To respond
cmccabe merged PR #13153:
URL: https://github.com/apache/kafka/pull/13153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cmccabe commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1091058054
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##
@@ -521,7 +524,7 @@ protected Map getNumPartitions(final
Set topics
cmccabe commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1091061226
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis()
C0urante commented on code in PR #13163:
URL: https://github.com/apache/kafka/pull/13163#discussion_r1091016715
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -246,13 +246,22 @@ public Map originals(Map
configOverrides) {
*/
public
mjsax commented on code in PR #12654:
URL: https://github.com/apache/kafka/pull/12654#discussion_r1091058442
##
streams/src/main/java/org/apache/kafka/streams/processor/StateRestoreListener.java:
##
@@ -37,6 +37,9 @@
* These two interfaces serve different restoration purposes
mjsax commented on PR #12654:
URL: https://github.com/apache/kafka/pull/12654#issuecomment-1409251099
Why has this PR 392 commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
vladimirdyuzhev commented on code in PR #13081:
URL: https://github.com/apache/kafka/pull/13081#discussion_r1091084183
##
clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java:
##
@@ -90,6 +91,7 @@ public void configure(Map configs, String
contextNa
Hangleton commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1091084191
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis
cmccabe commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1091087602
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis()
C0urante commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1091084063
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -476,14 +480,34 @@ public List getConfiguredInstances(List
classNames, Class t, M
mjsax commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1091222822
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##
@@ -466,7 +469,10 @@ public Set makeReady(final Map topics) {
mjsax commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1091223587
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##
@@ -538,6 +544,8 @@ protected Map getNumPartitions(final
Set topics,
cmccabe commented on PR #13169:
URL: https://github.com/apache/kafka/pull/13169#issuecomment-1409444203
Looks like Jenkins is having issues.
```
[2023-01-30T20:15:48.665Z] + ./retry_zinc ./gradlew -PscalaVersion=2.13
clean compileJava compileScala compileTestJava compileTestScala
spot
cmccabe opened a new pull request, #13176:
URL: https://github.com/apache/kafka/pull/13176
Some minor improvements to the JavaDoc for ZkMigrationState.
Rename MigrationState to MigrationDriverState to avoid confusion with
ZkMigrationState.
Remove ClusterImage#zkBrokers. This co
cmccabe commented on PR #13169:
URL: https://github.com/apache/kafka/pull/13169#issuecomment-1409506162
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
201 - 300 of 75095 matches
Mail list logo
