cmccabe commented on code in PR #13159:
URL: https://github.com/apache/kafka/pull/13159#discussion_r1090937161


##########
metadata/src/main/java/org/apache/kafka/image/ConfigurationsImage.java:
##########
@@ -61,6 +61,15 @@ public Properties configProperties(ConfigResource 
configResource) {
         }
     }
 
+    public Map<String, String> configMap(ConfigResource configResource) {

Review Comment:
   It would be good to add JavaDoc here stating that this doesn't handle 
configuration overrides. Also, how about `configMapForResource` as a name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to