cmccabe commented on code in PR #13159:
URL: https://github.com/apache/kafka/pull/13159#discussion_r1090939081
##########
core/src/main/scala/kafka/migration/MigrationPropagator.scala:
##########
@@ -118,9 +124,8 @@ class MigrationPropagator(
}
}
- // If there are new brokers (including KRaft brokers) or if there are
changes in topic
- // metadata, let's send UMR about the changes to the old Zk brokers.
- if (brokersChanged || !delta.topicsDelta().deletedTopicIds().isEmpty ||
!delta.topicsDelta().changedTopics().isEmpty) {
+ // If there are changes in topic metadata, let's send UMR about the
changes to the old Zk brokers.
+ if (!delta.topicsDelta().deletedTopicIds().isEmpty ||
!delta.topicsDelta().changedTopics().isEmpty) {
Review Comment:
Sorry, this might be a silly question, but is it OK for
`requestBatch.addUpdateMetadataRequestForBrokers` to be called twice in some
cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
