hachikuji commented on code in PR #13138:
URL: https://github.com/apache/kafka/pull/13138#discussion_r1084522285
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##
@@ -149,11 +156,14 @@ private void onSuccessfulResponse(final
hachikuji commented on code in PR #13138:
URL: https://github.com/apache/kafka/pull/13138#discussion_r1084522285
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##
@@ -149,11 +156,14 @@ private void onSuccessfulResponse(final
hachikuji merged PR #13138:
URL: https://github.com/apache/kafka/pull/13138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
C0urante commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1084555816
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -711,9 +742,9 @@ KafkaBasedLog
setupAndCreateKafkaBasedLog(Strin
anshvnm opened a new pull request, #13150:
URL: https://github.com/apache/kafka/pull/13150
This pull request adds new functions to the Producer.java file in the
examples directory to provide more flexibility for clients using Kafka. The
`sendToMultipleTopics` method allows clients to send a
rondagostino merged PR #13118:
URL: https://github.com/apache/kafka/pull/13118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
ahuang98 opened a new pull request, #13151:
URL: https://github.com/apache/kafka/pull/13151
If any authorizer fails to start up, we should also fail to start up the
broker or controller
*More detailed description of your change,
if necessary. The PR title and PR message become
t
rondagostino commented on PR #13116:
URL: https://github.com/apache/kafka/pull/13116#issuecomment-1401088949
Thanks, Colin. That all makes sense. The KIP indicates that `validateOnly`
is not throttled because it does not load the controller
(https://cwiki.apache.org/confluence/display/KAF
kirktrue opened a new pull request, #13152:
URL: https://github.com/apache/kafka/pull/13152
WIP.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
cmccabe opened a new pull request, #13153:
URL: https://github.com/apache/kafka/pull/13153
When running junit tests, it is not good to block forever on
CompletableFuture objects. When there are bugs, this can lead to junit tests
hanging forever. Jenkins does not deal with this well -- it o
jsancio opened a new pull request, #13154:
URL: https://github.com/apache/kafka/pull/13154
Make LeaderState's grantingVoters field explicitly immutable. The set of
voters that granted their voter to the current leader was already immutable.
This change makes that explicit.
### Commit
ableegoldman merged PR #13147:
URL: https://github.com/apache/kafka/pull/13147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
ableegoldman opened a new pull request, #13155:
URL: https://github.com/apache/kafka/pull/13155
Doing the PR to re-enable the test build that I temporarily disabled in
https://github.com/apache/kafka/pull/13147 in order to help with debugging and
to stabilize the 3.4 release branch.
ableegoldman commented on code in PR #13155:
URL: https://github.com/apache/kafka/pull/13155#discussion_r1084678438
##
streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##
@@ -96,9 +96,8 @@ SmokeTestDriver.VerificationResult result()
ableegoldman commented on PR #13155:
URL: https://github.com/apache/kafka/pull/13155#issuecomment-1401152718
cc @lucasbru @mjsax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
philipnee commented on PR #13125:
URL: https://github.com/apache/kafka/pull/13125#issuecomment-1401162257
Thanks @guozhangwang - A comment I have here is, would it be more convenient
to close/remove all the metrics and sensors in the Metrics class upon closing
instead of relying on these su
guozhangwang commented on PR #13125:
URL: https://github.com/apache/kafka/pull/13125#issuecomment-1401212144
The concern I had is that, the same metrics registry object is used across
multiple nested classes, while some of those classes may be closed and
re-created along the lifetime of the
C0urante merged PR #13144:
URL: https://github.com/apache/kafka/pull/13144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mjsax commented on code in PR #13155:
URL: https://github.com/apache/kafka/pull/13155#discussion_r1084789144
##
streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##
@@ -96,9 +96,8 @@ SmokeTestDriver.VerificationResult result() {
mjsax commented on code in PR #13142:
URL: https://github.com/apache/kafka/pull/13142#discussion_r1084826103
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -114,6 +114,7 @@ public class RocksDBStore implements KeyValueStore, BatchWriti
mjsax commented on code in PR #13143:
URL: https://github.com/apache/kafka/pull/13143#discussion_r1084834388
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegment.java:
##
@@ -0,0 +1,297 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
ableegoldman opened a new pull request, #13156:
URL: https://github.com/apache/kafka/pull/13156
I immediately saw a failure with `stateUpdaterEnabled = true` after
disabling the `false` parameter, which suggests the problem actually does lie
in the state updater itself and not the act of pa
ableegoldman commented on PR #13156:
URL: https://github.com/apache/kafka/pull/13156#issuecomment-1401529084
cc @lucasbru @mjsax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
ableegoldman merged PR #13156:
URL: https://github.com/apache/kafka/pull/13156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
ableegoldman commented on PR #13156:
URL: https://github.com/apache/kafka/pull/13156#issuecomment-1401535688
Merged to trunk and cherrypicked back to 3.4 since this is trivial and
rather time-sensitive -- hopefully we can finally narrow down the culprit for
good and have a better shot at ge
fvaleri commented on PR #13136:
URL: https://github.com/apache/kafka/pull/13136#issuecomment-1401539053
@mimaison @clolov @vamossagar12 this is ready for review if you have some
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
yashmayya commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1084960389
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -712,8 +733,16 @@ KafkaBasedLog
setupAndCreateKafkaBasedLog(Str
nizhikov opened a new pull request, #13157:
URL: https://github.com/apache/kafka/pull/13157
Currently, javadoc task disabled for `:connect:mirror` module.
This PR enables it.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] V
vamossagar12 opened a new pull request, #13158:
URL: https://github.com/apache/kafka/pull/13158
Moving TopicFilter to server-common/utils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
divijvaidya commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-1401813587
@sjetha you should probably send an email to the
[d...@kafka.apache.org](mailto:d...@kafka.apache.org) mailing list, explaining
the urgency and asking for someone to take a look at th
vamossagar12 commented on PR #13158:
URL: https://github.com/apache/kafka/pull/13158#issuecomment-1401815286
@fvaleri , plz review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
divijvaidya commented on PR #13111:
URL: https://github.com/apache/kafka/pull/13111#issuecomment-1401824565
@dajac
> Will this code still be around by the time tiered storage is completed?
I don't know but my point is that this code change is simple and safe enough
to add it to the cu
ruslankrivoshein commented on PR #13074:
URL: https://github.com/apache/kafka/pull/13074#issuecomment-1401965227
@hachikuji, what do you think about this tiny edition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
vamossagar12 commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1402008138
@C0urante , thanks for your response. Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
MPeli commented on PR #6329:
URL: https://github.com/apache/kafka/pull/6329#issuecomment-1402091415
Hi, I have created a new pull request. See #12331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mimaison commented on code in PR #13131:
URL: https://github.com/apache/kafka/pull/13131#discussion_r1085116578
##
server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mimaison commented on PR #13157:
URL: https://github.com/apache/kafka/pull/13157#issuecomment-1402188145
@nizhikov Thanks for looking at this issue. I don't think we can simply
enable the javadoc on the `connect:mirror` project as it will also include all
public classes from that module tha
nizhikov commented on PR #13157:
URL: https://github.com/apache/kafka/pull/13157#issuecomment-1402195231
@mimaison Thanks for the review.
What about *Config classes? like `MirrorCheckpointConfig` or
`MirrorConnectorConfig`.
Are the part of public API?
Should I move them to mirro
viktorsomogyi commented on code in PR #12992:
URL: https://github.com/apache/kafka/pull/12992#discussion_r1085559673
##
clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation
fvaleri commented on code in PR #13131:
URL: https://github.com/apache/kafka/pull/13131#discussion_r1085675650
##
server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1402347644
> we have pushed Exit.exit(1) down into CommandLineUtils.
@clolov it wasn't pushed down, that's the original logic. The code you are
referring to in ZkSecurityMigrator.scala:103 is
fvaleri commented on code in PR #13131:
URL: https://github.com/apache/kafka/pull/13131#discussion_r1085675650
##
server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
fvaleri commented on code in PR #13131:
URL: https://github.com/apache/kafka/pull/13131#discussion_r1085675650
##
server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
mimaison commented on code in PR #13136:
URL: https://github.com/apache/kafka/pull/13136#discussion_r1085565198
##
checkstyle/import-control.xml:
##
@@ -347,7 +347,7 @@
-
Review Comment:
We seem to have the trailing space everywhere else, so maybe keep it her
mimaison commented on PR #13157:
URL: https://github.com/apache/kafka/pull/13157#issuecomment-1402375492
The Config classes are not part of the public API. I suggested moving the
interfaces without thinking too much about it, have you considered if this
could break anything?
--
This is a
nizhikov commented on PR #13157:
URL: https://github.com/apache/kafka/pull/13157#issuecomment-1402420416
I can only imagine users who excluded mirror-client dependency for whatever
reason :)
Don't think we should consider such case as a blocker.
--
This is an automated message from the
rajinisivaram commented on PR #13119:
URL: https://github.com/apache/kafka/pull/13119#issuecomment-1402448121
Test failures not related, merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
rajinisivaram merged PR #13119:
URL: https://github.com/apache/kafka/pull/13119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
lucasbru opened a new pull request, #13160:
URL: https://github.com/apache/kafka/pull/13160
Mockito should not make named topologies paused by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Cerchie opened a new pull request, #13161:
URL: https://github.com/apache/kafka/pull/13161
In response to [14128](https://issues.apache.org/jira/browse/KAFKA-14128).
Addresses by moving final catch condition into an else block.
Testing strategy: I'm attempting a unit test first. I'v
dpcollins-google opened a new pull request, #13162:
URL: https://github.com/apache/kafka/pull/13162
Instead use Channels.newChannel to write in larger chunks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
vcrfxia commented on code in PR #13142:
URL: https://github.com/apache/kafka/pull/13142#discussion_r1085935187
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java:
##
@@ -383,7 +383,9 @@ public KeyValue makeNext() {
@Override
vcrfxia commented on code in PR #13142:
URL: https://github.com/apache/kafka/pull/13142#discussion_r1085933946
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -351,13 +360,23 @@ public QueryResult query(
@Override
public , P>
cmccabe commented on code in PR #13140:
URL: https://github.com/apache/kafka/pull/13140#discussion_r1085968353
##
core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala:
##
@@ -198,7 +200,8 @@ class RaftManagerTest {
@Test
def testShutdownIoThread(): Unit = {
val r
vcrfxia commented on code in PR #13143:
URL: https://github.com/apache/kafka/pull/13143#discussion_r1085990051
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegment.java:
##
@@ -0,0 +1,297 @@
+/*
+ * Licensed to the Apache Software Foundation (
guozhangwang merged PR #13160:
URL: https://github.com/apache/kafka/pull/13160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
guozhangwang commented on PR #13160:
URL: https://github.com/apache/kafka/pull/13160#issuecomment-1402827998
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
cmccabe merged PR #13151:
URL: https://github.com/apache/kafka/pull/13151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
blueberrysugarhigh commented on PR #12126:
URL: https://github.com/apache/kafka/pull/12126#issuecomment-1402996186
> @rayokota sorry for bothering you. I'm trying to maintain my own version
of `JsonConverter`. I just copied the code and pasted it to a new class
`JsonConverter`. and I replac
rayokota commented on PR #12126:
URL: https://github.com/apache/kafka/pull/12126#issuecomment-1403014501
@blueberrysugarhigh , sorry I'm not the author of this PR and I haven't
tried it myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Playerharperb commented on PR #13162:
URL: https://github.com/apache/kafka/pull/13162#issuecomment-1403125466
Hello my name is playerharp...@gmail.com and I am interested in this job
posting on the website
--
This is an automated message from the Apache Git Service.
To respond to the mes
Schm1tz1 commented on code in PR #12992:
URL: https://github.com/apache/kafka/pull/12992#discussion_r1086368344
##
clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
urbandan commented on code in PR #13137:
URL: https://github.com/apache/kafka/pull/13137#discussion_r1086404484
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -0,0 +1,228 @@
+/*
+ * Licensed to the Apache So
urbandan opened a new pull request, #13163:
URL: https://github.com/apache/kafka/pull/13163
…esolution properties.
MirrorMakerConfig extends AbstractConfig, which resolves config provider
based references eagerly, construction time. Because of this, Connector
configurations created b
urbandan commented on PR #13163:
URL: https://github.com/apache/kafka/pull/13163#issuecomment-1403439915
@C0urante @viktorsomogyi Can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1086613346
##
server-common/src/test/java/org/apache/kafka/server/util/TopicFilterTest.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
fvaleri commented on code in PR #13136:
URL: https://github.com/apache/kafka/pull/13136#discussion_r1086675903
##
core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala:
##
@@ -801,21 +801,15 @@ object ConsumerGroupCommand extends Logging {
partitionsToReset.map { t
fvaleri commented on code in PR #13136:
URL: https://github.com/apache/kafka/pull/13136#discussion_r1086694567
##
tools/src/main/java/org/apache/kafka/tools/JmxCommand.java:
##
@@ -0,0 +1,441 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
fvaleri commented on PR #13136:
URL: https://github.com/apache/kafka/pull/13136#issuecomment-1403712199
Thanks @mimaison.
I addressed all your comments and now working on the test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
hachikuji merged PR #13140:
URL: https://github.com/apache/kafka/pull/13140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
jolshan commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1086981346
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -300,9 +301,13 @@ void runOnce() {
try {
transacti
jolshan commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1086981869
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -300,9 +301,13 @@ void runOnce() {
try {
transacti
lucasbru opened a new pull request, #13164:
URL: https://github.com/apache/kafka/pull/13164
Make sure no scaladoc warnings are emitted from the streams-scala project
build. We cannot fully fix all scaladoc warnings due to limitations of the
scaladoc tool, so this is a best-effort attempt at
gharris1727 opened a new pull request, #13165:
URL: https://github.com/apache/kafka/pull/13165
The scanPluginPath -> getPluginDesc -> versionFor code path instantiates
connectors in order to evaluate their version() method. This is the first call
to initialize these classes, and so performs
jolshan commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1086992753
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -155,7 +155,7 @@ private enum State {
private boolean isTra
mjsax commented on code in PR #13164:
URL: https://github.com/apache/kafka/pull/13164#discussion_r1087040518
##
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Consumed.scala:
##
@@ -43,7 +43,7 @@ object Consumed {
ConsumedJ.`with`(keySerde, valu
cmccabe commented on PR #13098:
URL: https://github.com/apache/kafka/pull/13098#issuecomment-1404230760
Looks like something exited the Jenkins process. Rerunning.
```
[2023-01-24T22ː55ː33.723Z] Execution failed for task 'ːcoreːintegrationTest'.
[2023-01-24T22ː55ː33.723Z] > Process '
kirktrue opened a new pull request, #13166:
URL: https://github.com/apache/kafka/pull/13166
Removes logging of the HTTP response directly in all known cases to prevent
potentially logging access tokens.
Reviewers: Sushant Mahajan , Rajini Sivaram
(cherry picked from commit bc1ce
jsancio commented on PR #13154:
URL: https://github.com/apache/kafka/pull/13154#issuecomment-1404366998
Merging. Unrelated test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
jsancio merged PR #13154:
URL: https://github.com/apache/kafka/pull/13154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
guozhangwang opened a new pull request, #13167:
URL: https://github.com/apache/kafka/pull/13167
1) The major fix: synchronize access to tasks inside task manager.
2) Clarify on func names of StreamThread that maybe triggered outside the
StreamThread.
3) Minor cleanups.
### Commi
guozhangwang commented on PR #13167:
URL: https://github.com/apache/kafka/pull/13167#issuecomment-1404437326
ping @cadonna for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1404639472
hi @mimaison would you plz review this PR whenever you get the chance? It's
already approved by @fvaleri . Thanks
--
This is an automated message from the Apache Git Service.
To re
vamossagar12 commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087508896
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
vamossagar12 commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087521073
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
vamossagar12 commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087521793
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
vamossagar12 commented on PR #13158:
URL: https://github.com/apache/kafka/pull/13158#issuecomment-1404671786
> TopicPartitionFilter
@fvaleri , sorry about the build failures. I hadn't run the checkstyle for
core on my local before pushing. I will work on the TopicPartitionFilter class
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087550310
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087550486
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087550486
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087551664
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mjsax commented on PR #13142:
URL: https://github.com/apache/kafka/pull/13142#issuecomment-1404744058
There is a test failure -- seems you need to update `shouldCloseIterator()`
test and set a callback via `onClose()`?
--
This is an automated message from the Apache Git Service.
To respon
mjsax commented on PR #13143:
URL: https://github.com/apache/kafka/pull/13143#issuecomment-1404747240
Seems some of you newly added tests fail. Can you have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
rajinisivaram merged PR #13166:
URL: https://github.com/apache/kafka/pull/13166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
lucasbru commented on code in PR #13164:
URL: https://github.com/apache/kafka/pull/13164#discussion_r1087656183
##
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Consumed.scala:
##
@@ -43,7 +43,7 @@ object Consumed {
ConsumedJ.`with`(keySerde, v
vamossagar12 commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087826981
##
server-common/src/test/java/org/apache/kafka/server/util/TopicFilterTest.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
vamossagar12 commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087838897
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
viktorsomogyi commented on code in PR #13137:
URL: https://github.com/apache/kafka/pull/13137#discussion_r1087986328
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java:
##
@@ -119,7 +126,16 @@ public class MirrorMaker {
public MirrorMaker(Mirro
rondagostino commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1088113461
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -392,14 +394,36 @@ class ControllerApis(val requestChannel: RequestChannel,
val describableTop
mimaison commented on code in PR #13095:
URL: https://github.com/apache/kafka/pull/13095#discussion_r1088121137
##
tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
101 - 200 of 71546 matches
Mail list logo
