cmccabe commented on code in PR #13140:
URL: https://github.com/apache/kafka/pull/13140#discussion_r1085968353


##########
core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala:
##########
@@ -198,7 +200,8 @@ class RaftManagerTest {
   @Test
   def testShutdownIoThread(): Unit = {
     val raftClient = mock(classOf[KafkaRaftClient[String]])
-    val ioThread = new RaftIoThread(raftClient, threadNamePrefix = "test-raft")
+    val faultHandler = mock(classOf[FaultHandler])

Review Comment:
   use `MockFaultHandler` here
   
   then, lalter in the test, do `maybeRethrowFirstException` to ensure no 
faults happened



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to