[GitHub] [kafka] huxihx opened a new pull request #9225: KAFKA-10431: Sequential selection of payload in ProducerPerformance

huxihx opened a new pull request #9225: URL: https://github.com/apache/kafka/pull/9225 https://issues.apache.org/jira/browse/KAFKA-10431 Currently, ProducerPerformance randomly selects a payload from the payload file when sending message. This might cause the some payloads being sele

[GitHub] [kafka] huxihx commented on pull request #9225: KAFKA-10431: Sequential selection of payload in ProducerPerformance

huxihx commented on pull request #9225: URL: https://github.com/apache/kafka/pull/9225#issuecomment-681778195 @ijuma Please review this patch. Thanks. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] kkonstantine commented on a change in pull request #9211: KAFKA-10426: Deadlock on session key update.

kkonstantine commented on a change in pull request #9211: URL: https://github.com/apache/kafka/pull/9211#discussion_r478275661 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java ## @@ -733,10 +734,11 @@ public void onCompl

[GitHub] [kafka] kkonstantine commented on pull request #9211: KAFKA-10426: Deadlock on session key update.

kkonstantine commented on pull request #9211: URL: https://github.com/apache/kafka/pull/9211#issuecomment-681830490 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] xakassi commented on a change in pull request #9211: KAFKA-10426: Deadlock on session key update.

xakassi commented on a change in pull request #9211: URL: https://github.com/apache/kafka/pull/9211#discussion_r478325832 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java ## @@ -733,10 +734,11 @@ public void onCompletion

[GitHub] [kafka] xakassi commented on a change in pull request #9211: KAFKA-10426: Deadlock on session key update.

xakassi commented on a change in pull request #9211: URL: https://github.com/apache/kafka/pull/9211#discussion_r478325832 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java ## @@ -733,10 +734,11 @@ public void onCompletion

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r478340031 ## File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java ## @@ -119,15 +118,16 @@ * * This iterator must be closed afte

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r478349804 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java ## @@ -287,17 +308,43 @@ public void shouldFetc

[GitHub] [kafka] mimaison commented on a change in pull request #9215: KAFKA-10133: MM2 readme update on config

mimaison commented on a change in pull request #9215: URL: https://github.com/apache/kafka/pull/9215#discussion_r478425022 ## File path: connect/mirror/README.md ## @@ -141,7 +141,38 @@ nearby clusters. N.B. that the `--clusters` parameter is not technically required here. MM2

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478435832 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478437596 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,380 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478442739 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -174,12 +181,11 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478445137 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478454716 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,380 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478459405 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -189,8 +195,8 @@ public void processI

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478462394 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -232,40 +239,54 @@ private void proce

[GitHub] [kafka] mimaison commented on pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…

mimaison commented on pull request #9122: URL: https://github.com/apache/kafka/pull/9122#issuecomment-682006762 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478489438 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -232,40 +239,54 @@ private void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478490860 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -232,40 +239,54 @@ private void proce

[GitHub] [kafka] mimaison commented on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…

mimaison commented on pull request #9057: URL: https://github.com/apache/kafka/pull/9057#issuecomment-682013531 Thanks for the contribution. As this is adding new public classes, this change requires a KIP: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals

[GitHub] [kafka] cadonna commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

cadonna commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r478504532 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -396,34 +398,65 @@ private String ca

[GitHub] [kafka] mimaison commented on pull request #9023: KAFKA-10272: Add IBM i support to "stop" scripts

mimaison commented on pull request #9023: URL: https://github.com/apache/kafka/pull/9023#issuecomment-682027790 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mimaison commented on pull request #8798: KAFKA-10098: Remove unnecessary escaping in regular expression.

mimaison commented on pull request #8798: URL: https://github.com/apache/kafka/pull/8798#issuecomment-682051575 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] brbrown25 commented on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…

brbrown25 commented on pull request #9057: URL: https://github.com/apache/kafka/pull/9057#issuecomment-682058178 @mimaison Thank You, I'll review and submit a KIP this afternoon! This is an automated message from the Apache G

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9215: KAFKA-10133: MM2 readme update on config

ning2008wisc commented on a change in pull request #9215: URL: https://github.com/apache/kafka/pull/9215#discussion_r478583076 ## File path: connect/mirror/README.md ## @@ -141,7 +141,38 @@ nearby clusters. N.B. that the `--clusters` parameter is not technically required here.

[GitHub] [kafka] ning2008wisc commented on pull request #9215: KAFKA-10133: MM2 readme update on config

ning2008wisc commented on pull request #9215: URL: https://github.com/apache/kafka/pull/9215#issuecomment-682090080 @mimaison thanks for your review. Regarding to your general comment about moving MM2 Readme to the Kafka documentation, I think it is a good idea to promote MM2 in the commun

[GitHub] [kafka] vvcephei commented on a change in pull request #9222: KAFKA-10437: Implement test-utils and StateStore changes for KIP-478

vvcephei commented on a change in pull request #9222: URL: https://github.com/apache/kafka/pull/9222#discussion_r478586348 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/StateStoreContext.java ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mumrah opened a new pull request #9226: [DO NOT MERGE] Jenkinsfile testing

mumrah opened a new pull request #9226: URL: https://github.com/apache/kafka/pull/9226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

guozhangwang commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r478605835 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFil

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r478604292 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -100,7 +100,8 @@ case class LogAppendInfo(var firstOffset: Option[Long],

[GitHub] [kafka] guozhangwang commented on pull request #8988: KAFKA-10199: Separate restore threads [WIP]

guozhangwang commented on pull request #8988: URL: https://github.com/apache/kafka/pull/8988#issuecomment-68204 > Is this planned for a follow-up PR or were you just waiting to get a review of the basics before diving deeper into this work? Yes that's the plan. More concreted I'm

[GitHub] [kafka] guozhangwang commented on a change in pull request #8988: KAFKA-10199: Separate restore threads [WIP]

guozhangwang commented on a change in pull request #8988: URL: https://github.com/apache/kafka/pull/8988#discussion_r478608933 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -411,7 +411,10 @@ boolean tryToCompleteRestora

[GitHub] [kafka] lbradstreet commented on a change in pull request #9129: MINOR: Update jmh to 1.25 for async profiler support

lbradstreet commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r478635770 ## File path: jmh-benchmarks/README.md ## @@ -34,7 +34,18 @@ the jmh.sh script from the jmh-benchmarks module. * By default all JMH output goes to stdo

[GitHub] [kafka] lbradstreet commented on a change in pull request #9129: MINOR: Update jmh to 1.25 for async profiler support

lbradstreet commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r478636719 ## File path: jmh-benchmarks/README.md ## @@ -34,7 +34,18 @@ the jmh.sh script from the jmh-benchmarks module. * By default all JMH output goes to stdo

[GitHub] [kafka] lbradstreet commented on a change in pull request #9129: MINOR: Update jmh to 1.25 for async profiler support

lbradstreet commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r478637097 ## File path: README.md ## @@ -199,6 +199,27 @@ You can run spotbugs using: The spotbugs warnings will be found in `reports/spotbugs/main.html` and `r

[GitHub] [kafka] ijuma commented on a change in pull request #9129: MINOR: Update jmh to 1.25 for async profiler support

ijuma commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r478639377 ## File path: README.md ## @@ -199,6 +199,27 @@ You can run spotbugs using: The spotbugs warnings will be found in `reports/spotbugs/main.html` and `reports

[GitHub] [kafka] ijuma commented on a change in pull request #9129: MINOR: Update jmh to 1.25 for async profiler support

ijuma commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r478639981 ## File path: jmh-benchmarks/README.md ## @@ -34,7 +34,18 @@ the jmh.sh script from the jmh-benchmarks module. * By default all JMH output goes to stdout. T

[GitHub] [kafka] ijuma commented on a change in pull request #9129: MINOR: Update jmh to 1.25 for async profiler support

ijuma commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r478640519 ## File path: jmh-benchmarks/README.md ## @@ -34,7 +34,18 @@ the jmh.sh script from the jmh-benchmarks module. * By default all JMH output goes to stdout. T

[GitHub] [kafka] avocader opened a new pull request #9227: KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale.

avocader opened a new pull request #9227: URL: https://github.com/apache/kafka/pull/9227 The `org.apache.kafka.connect.data.Values#parse` method parses integers, which are larger than `Long.MAX_VALUE` as `double` with `Schema.FLOAT64_SCHEMA`. That means we are losing precision for th

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r478646271 ## File path: tests/kafkatest/services/security/security_config.py ## @@ -276,18 +287,19 @@ def setup_node(self, node): if java_version(node) <= 11

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r478646950 ## File path: tests/kafkatest/services/security/security_config.py ## @@ -350,6 +362,14 @@ def kafka_opts(self): else: return "" +

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r478652254 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -575,10 +577,21 @@ def set_unclean_leader_election(self, topic, value=True, node=None):

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r478652254 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -575,10 +577,21 @@ def set_unclean_leader_election(self, topic, value=True, node=None):

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r478653535 ## File path: tests/kafkatest/services/security/security_config.py ## @@ -350,6 +362,14 @@ def kafka_opts(self): else: return ""

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r478656313 ## File path: tests/kafkatest/version.py ## @@ -63,8 +63,13 @@ def reassign_partitions_command_supports_bootstrap_server(self): return self >= V_2

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r478657275 ## File path: core/src/test/scala/unit/kafka/utils/JaasTestUtils.scala ## @@ -169,6 +169,18 @@ object JaasTestUtils { jaasFile } + // Returns a S

[GitHub] [kafka] vvcephei commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

vvcephei commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478588602 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/SlidingWindows.java ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] vvcephei commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

vvcephei commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r478709525 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -396,34 +398,65 @@ private String c

[GitHub] [kafka] vvcephei commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

vvcephei commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-682208742 Since the PR builds aren't running, I'm merging with trunk on my machine and running the tests. This is an a

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478715664 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,391 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478716769 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,391 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478717127 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -0,0 +1,466 @@ +/* + * Lic

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478726427 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,303 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478728829 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,303 @@ +/* + * Licensed to th

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478730258 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478730258 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478730765 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478730796 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,303 @@ +/* + * Licensed to th

[GitHub] [kafka] vvcephei merged pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

vvcephei merged pull request #9177: URL: https://github.com/apache/kafka/pull/9177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

vvcephei commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-682235389 Hey @cadonna , after checking out your branch and merging with trunk, I discovered some minor conflicts with 22bcd9fac3c988c15862d0b6c01930814b676253, so I pushed a quick fix bef

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478743528 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478744162 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void proces

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478751787 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,303 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478751787 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,303 @@ +/* + * License

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478753568 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,303 @@ +/* + * Licensed to th

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r478756346 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,303 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478758482 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478758779 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478759996 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478759996 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478761540 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,380 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478762151 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,386 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478762667 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -174,12 +181,11 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478763071 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -189,8 +195,8 @@ public void p

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478766196 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -232,40 +239,54 @@ private voi

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478768335 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,386 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478768625 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,386 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478769004 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,386 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r478769493 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java ## @@ -287,17 +308,43 @@ public void sh

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r478770009 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java ## @@ -416,26 +552,43 @@ private long currentSegm

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r478774195 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryWindowStore.java ## @@ -419,13 +504,13 @@ Long minTime() {

[GitHub] [kafka] khaireddine120 commented on pull request #9207: Minor remove semicolon

khaireddine120 commented on pull request #9207: URL: https://github.com/apache/kafka/pull/9207#issuecomment-682442638 Hi @bbejeck Thanks for the approval Why the check is taking so long ? This is an automated message f

[GitHub] [kafka] vvcephei commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

vvcephei commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r479344784 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,303 @@ +/* + * Licensed to

[GitHub] [kafka] vvcephei commented on a change in pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

vvcephei commented on a change in pull request #8955: URL: https://github.com/apache/kafka/pull/8955#discussion_r479356312 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/serialization/Serdes.scala ## @@ -0,0 +1,93 @@ +/* + * Copyright (C) 201

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r479362665 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,303 @@ +/* + * Licensed to th

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r479383807 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -85,6 +85,8 @@ object LogAppendInfo { * @param validBytes The number of valid bytes * @param

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r479411830 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void proces

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-682879578 @junrao Thanks for all suggestions! Is Jenkins on vacation? Could you trigger a system test? This is an au

[GitHub] [kafka] ijuma commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

ijuma commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-682991870 @chia7712 See KAFKA-10444 with regards to Jenkins. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r479467548 ## File path: core/src/main/scala/kafka/server/DelayedOperation.scala ## @@ -100,41 +99,21 @@ abstract class DelayedOperation(override val delayMs: Long,

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-683052000 @ijuma @hachikuji @rajinisivaram : Do you want to take another look at the latest solution from Chia-Ping? It (1) solves the known issues completely; (2) doesn't require new thread

[GitHub] [kafka] ijuma commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

ijuma commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r479474904 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -100,7 +102,8 @@ case class LogAppendInfo(var firstOffset: Option[Long],

[GitHub] [kafka] ijuma commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

ijuma commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r479475681 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -184,6 +184,7 @@ class KafkaApis(val requestChannel: RequestChannel, case e: Fatal

[GitHub] [kafka] dielhennr closed pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr closed pull request #9101: URL: https://github.com/apache/kafka/pull/9101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

ijuma commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-683075891 This looks promising. One question, do we want every request to drain this ReplicaManager queue or only the callers of `appendRecords`? I think this answer affects the design a bit.

[GitHub] [kafka] dielhennr commented on pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 Hi @jsancio I hope you're doing well. I added some work in progress to this branch that includes new APIs and basic functionality for this feature using the APIs. Fitting user a

[GitHub] [kafka] dielhennr edited a comment on pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr edited a comment on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 Hi @jsancio I hope you're doing well. I added some work in progress to this branch that includes new APIs and basic functionality for this feature using the new APIs. Fit

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r479545936 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r479546505 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r479546505 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apa

<    13   14   15   16   17   18   19   20   21   22   >