cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r478657275
##########
File path: core/src/test/scala/unit/kafka/utils/JaasTestUtils.scala
##########
@@ -169,6 +169,18 @@ object JaasTestUtils {
jaasFile
}
+ // Returns a SASL/SCRAM configuration using credentials for the given user
and password
+ def scramClientLoginModule(mechanism: String, scramUser: String,
scramPassword: String): String = {
+ mechanism match {
+ case "SCRAM-SHA-256" | "SCRAM-SHA-512" =>
Review comment:
Can we not have these be naked constants? Maybe we could iterate over
an enum or something? If we add another mechanism, it would be nice not to
have to manually edit this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
