ijuma commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r478640519
########## File path: jmh-benchmarks/README.md ########## @@ -34,7 +34,18 @@ the jmh.sh script from the jmh-benchmarks module. * By default all JMH output goes to stdout. To run a benchmark and capture the results in a file: `./jmh.sh -f 2 -o benchmarkResults.txt LRUCacheBenchmark` NOTE: For now this script needs to be run from the jmh-benchmarks directory. + +### Using JMH with async-profiler + +It's good practice to check profiler output for microbenchmarks in order to verify that they are valid. +JMH includes [async-profiler](https://github.com/jvm-profiling-tools/async-profiler) integration that makes this easy: + LD_LIBRARY_PATH=/path/to/async-profiler ./jmh-benchmarks/jmh.sh -prof async Review comment: Agreed, I tested this variant on Mac, but not Linux yet. Will do before changing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org