Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-24 Thread via GitHub
k-apol commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2163606157 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -425,7 +431,7 @@ public void shouldCloseStartupTasksAfterFirstRebalance() throws Exceptio

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-06-24 Thread via GitHub
chia7712 commented on code in PR #19820: URL: https://github.com/apache/kafka/pull/19820#discussion_r2164565204 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3772,7 +3772,19 @@ class KafkaApis(val requestChannel: RequestChannel, case Some(error) =>

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-06-24 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2164588158 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -155,9 +155,10 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

[jira] [Commented] (KAFKA-19427) Kafka 4.0 may have a memory leak, causing an OOM exception

2025-06-24 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985812#comment-17985812 ] David Jacot commented on KAFKA-19427: - [~RivenSun] Thanks for the Jira. Could you pl

Re: [PR] MINOR: Fix response for consumer group describe with empty group id [kafka]

2025-06-24 Thread via GitHub
chia7712 commented on PR #20030: URL: https://github.com/apache/kafka/pull/20030#issuecomment-3001444520 It seems `describeGroups`, `share`, and `stream` have similar issues: https://github.com/apache/kafka/blob/023833fe1f067779e55931f28eacc9cb5c54c776/group-coordinator/src/main/java/

Re: [PR] KAFKA-19395 - Updated Junit and mockito version and license information in NOTICE-binary for Jakarta RESTful Web Services Project [kafka]

2025-06-24 Thread via GitHub
chia7712 commented on code in PR #19943: URL: https://github.com/apache/kafka/pull/19943#discussion_r2164780692 ## NOTICE-binary: ## @@ -248,14 +248,14 @@ javaee-api (7.0) * License: Apache-2.0 AND W3C -JUnit (4.11) +JUnit (5.10.2) -* License: Common Public License 1.0 +*

Re: [PR] MINOR: Remove unused DescribeTopicPartitionResponse.prepareResponse function [kafka]

2025-06-24 Thread via GitHub
Yunyung commented on PR #20032: URL: https://github.com/apache/kafka/pull/20032#issuecomment-3001828890 Thanks for the PR. Please fix the "Unused import" errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-06-24 Thread via GitHub
kevin-wu24 commented on code in PR #20021: URL: https://github.com/apache/kafka/pull/20021#discussion_r2164212375 ## metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java: ## @@ -345,7 +346,18 @@ private void maybePublishMetadata(MetadataDelta delta, Metadata

Re: [PR] MINOR: Revert initial transactional state store semantics commit [kafka]

2025-06-24 Thread via GitHub
bbejeck commented on PR #19956: URL: https://github.com/apache/kafka/pull/19956#issuecomment-3001952169 merged #19956 into 4.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-19294: Fix BrokerLifecycleManager RPC timeouts [kafka]

2025-06-24 Thread via GitHub
cmccabe commented on code in PR #19745: URL: https://github.com/apache/kafka/pull/19745#discussion_r2160104761 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -411,7 +411,7 @@ class BrokerServer( config, "heartbeat", s"broker-${config.nod

Re: [PR] MINOR: Revert initial transactional state store semantics commit [kafka]

2025-06-24 Thread via GitHub
bbejeck merged PR #19956: URL: https://github.com/apache/kafka/pull/19956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-19433) Unify broker heartbeat RPC timeout and periodic resend timeout

2025-06-24 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-19433: Summary: Unify broker heartbeat RPC timeout and periodic resend timeout Key: KAFKA-19433 URL: https://issues.apache.org/jira/browse/KAFKA-19433 Project: Kafka

Re: [PR] KAFKA-19425: Stop the server when fail to initialize to avoid local segment never got deleted. [kafka]

2025-06-24 Thread via GitHub
FrankYang0529 commented on PR #20007: URL: https://github.com/apache/kafka/pull/20007#issuecomment-279648 @jiafu1115 Could you share the exception you got? I would like to check whether the exception is retriable. If it's, we may not use `Exception` to handle all cases. -- This is an

Re: [PR] KAFKA-18486: Migrate tests to use applyDelta instead of becomeLeaderOrFollower [kafka]

2025-06-24 Thread via GitHub
jingjia88 commented on code in PR #20014: URL: https://github.com/apache/kafka/pull/20014#discussion_r2164054705 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -1225,65 +1196,55 @@ class ReplicaManagerTest { } } - @Test - def testBecomeFollo

Re: [PR] KAFKA-18486: Migrate tests to use applyDelta instead of becomeLeaderOrFollower [kafka]

2025-06-24 Thread via GitHub
jingjia88 commented on code in PR #20014: URL: https://github.com/apache/kafka/pull/20014#discussion_r2164055749 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -3881,41 +3825,35 @@ class ReplicaManagerTest { def testInconsistentIdReturnsError(): Unit

[jira] [Resolved] (KAFKA-18778) Fix the inconsistent lastest supported version in StorageTool.scala and FutureCommand

2025-06-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18778. Fix Version/s: 4.2.0 Resolution: Fixed > Fix the inconsistent lastest supported ver

Re: [PR] MINOR: Cleanup Connect Module (1/n) [kafka]

2025-06-24 Thread via GitHub
chia7712 commented on code in PR #19869: URL: https://github.com/apache/kafka/pull/19869#discussion_r2164607256 ## connect/api/src/main/java/org/apache/kafka/connect/data/SchemaBuilder.java: ## @@ -419,7 +419,7 @@ public Schema valueSchema() { */ public Schema build()

Re: [PR] MINOR: Reject requests using unsupported features in KIP-1071 [kafka]

2025-06-24 Thread via GitHub
chia7712 commented on code in PR #20031: URL: https://github.com/apache/kafka/pull/20031#discussion_r2164850095 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -540,6 +541,26 @@ private static void throwIfStreamsGroupHea

[PR] MINOR: Remove unused DescribeTopicPartitionResponse.prepareResponse function [kafka]

2025-06-24 Thread via GitHub
yuxian0908 opened a new pull request, #20032: URL: https://github.com/apache/kafka/pull/20032 The prepareResponse function is no longer used anywhere in the codebase. Removing unused code improves maintainability and readability. -- This is an automated message from the Apache Git Servi

[PR] MINOR: Fix response for consumer group describe with empty group id [kafka]

2025-06-24 Thread via GitHub
rajinisivaram opened a new pull request, #20030: URL: https://github.com/apache/kafka/pull/20030 ConsumerGroupDescribe with an empty group id returns a response containing `null` groupId in a non-nullable field. Since the response cannot be serialized, this results in UNKNOWN_SERVER_ERROR b

[PR] KAFKA-19383: Handle the deleted topics when applying ClearElrRecord (… [kafka]

2025-06-24 Thread via GitHub
CalvinConfluent opened a new pull request, #20033: URL: https://github.com/apache/kafka/pull/20033 …#19916) https://issues.apache.org/jira/browse/KAFKA-19383 When applying the ClearElrRecord, it may pick up the topicId in the image without checking if the topic has been deleted. Thi

Re: [PR] MINOR: Remove unused DescribeTopicPartitionResponse.prepareResponse function [kafka]

2025-06-24 Thread via GitHub
yuxian0908 commented on PR #20032: URL: https://github.com/apache/kafka/pull/20032#issuecomment-3001949514 > Thanks for the PR. Please fix the "Unused import" errors. Thanks for the review! I've removed the unused imports in the latest commit. PTAL -- This is an automated message

[jira] [Updated] (KAFKA-19434) Move logic for for state store initiation to StreamThread handover

2025-06-24 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-19434: Description: When starting a Kafka Streams instance, if it has pre-existing state, the state stor

Re: [PR] KAFKA-18486: Migrate tests to use applyDelta instead of becomeLeaderOrFollower [kafka]

2025-06-24 Thread via GitHub
m1a2st commented on code in PR #20014: URL: https://github.com/apache/kafka/pull/20014#discussion_r2163780455 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -312,38 +311,26 @@ class ReplicaManagerTest { alterPartitionManager = alterPartitionManag

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-06-24 Thread via GitHub
Yunyung commented on code in PR #20021: URL: https://github.com/apache/kafka/pull/20021#discussion_r2163855467 ## server/src/main/java/org/apache/kafka/server/metrics/NodeMetrics.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19244: Fix flaky streams offsets reset integration test [kafka]

2025-06-24 Thread via GitHub
lucasbru merged PR #20027: URL: https://github.com/apache/kafka/pull/20027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-19380) Update streams/developer-guide/app-reset-tool.html

2025-06-24 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19380: -- Assignee: Alieh Saeedi > Update streams/developer-guide/app-reset-tool.html > ---

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-06-24 Thread via GitHub
kevin-wu24 commented on code in PR #20021: URL: https://github.com/apache/kafka/pull/20021#discussion_r2164687071 ## metadata/src/main/java/org/apache/kafka/image/loader/metrics/MetadataLoaderMetrics.java: ## @@ -142,16 +185,44 @@ public long handleLoadSnapshotCount() {

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-06-24 Thread via GitHub
JimmyWang6 commented on code in PR #19820: URL: https://github.com/apache/kafka/pull/19820#discussion_r2164713759 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3772,7 +3772,19 @@ class KafkaApis(val requestChannel: RequestChannel, case Some(error) =>

[jira] [Created] (KAFKA-19431) Stronger assignment consistency with subscription for consumer groups

2025-06-24 Thread Sean Quah (Jira)
Sean Quah created KAFKA-19431: - Summary: Stronger assignment consistency with subscription for consumer groups Key: KAFKA-19431 URL: https://issues.apache.org/jira/browse/KAFKA-19431 Project: Kafka

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-06-24 Thread via GitHub
kevin-wu24 commented on code in PR #20021: URL: https://github.com/apache/kafka/pull/20021#discussion_r2164179856 ## server/src/main/java/org/apache/kafka/server/metrics/NodeMetrics.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] KAFKA-18486: Migrate tests to use applyDelta instead of becomeLeaderOrFollower [kafka]

2025-06-24 Thread via GitHub
chia7712 commented on code in PR #20014: URL: https://github.com/apache/kafka/pull/20014#discussion_r2164306783 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -1225,65 +1196,55 @@ class ReplicaManagerTest { } } - @Test - def testBecomeFollow

Re: [PR] KAFKA-19294: Fix BrokerLifecycleManager RPC timeouts [kafka]

2025-06-24 Thread via GitHub
cmccabe commented on code in PR #19745: URL: https://github.com/apache/kafka/pull/19745#discussion_r2164629367 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -411,7 +411,7 @@ class BrokerServer( config, "heartbeat", s"broker-${config.nod

[jira] [Created] (KAFKA-19432) Add an ERROR log message if broker.heartbeat.interval.ms is too large

2025-06-24 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-19432: Summary: Add an ERROR log message if broker.heartbeat.interval.ms is too large Key: KAFKA-19432 URL: https://issues.apache.org/jira/browse/KAFKA-19432 Project: Kafka

[jira] [Resolved] (KAFKA-19411) Delete ACLs records can exceed max records per user op

2025-06-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-19411. -- Fix Version/s: 4.1.0 Resolution: Fixed > Delete ACLs records can exceed max records per

Re: [PR] KAFKA-18834: Fix LoggingResourceTest#testSetLevelDefaultScope [kafka]

2025-06-24 Thread via GitHub
apalan60 commented on code in PR #19920: URL: https://github.com/apache/kafka/pull/19920#discussion_r2164583324 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/LoggersTest.java: ## @@ -47,6 +49,11 @@ public void setup() { time = new MockTime(0, INITIAL

[jira] [Assigned] (KAFKA-19433) Unify broker heartbeat RPC timeout and periodic resend timeout

2025-06-24 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Wang reassigned KAFKA-19433: -- Assignee: Jimmy Wang > Unify broker heartbeat RPC timeout and periodic resend timeout > -

Re: [PR] MINOR: fix reassign command bug [kafka]

2025-06-24 Thread via GitHub
chia7712 merged PR #20003: URL: https://github.com/apache/kafka/pull/20003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19411: Fix deleteAcls bug which allows more deletions than max records per user op [kafka]

2025-06-24 Thread via GitHub
cmccabe merged PR #19974: URL: https://github.com/apache/kafka/pull/19974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-24 Thread via GitHub
k-apol commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2163656554 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -461,15 +469,22 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-06-24 Thread via GitHub
m1a2st commented on code in PR #20021: URL: https://github.com/apache/kafka/pull/20021#discussion_r2163726851 ## server/src/main/java/org/apache/kafka/server/metrics/NodeMetrics.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19425: Stop the server when fail to initialize to avoid local segment never got deleted. [kafka]

2025-06-24 Thread via GitHub
jiafu1115 commented on PR #20007: URL: https://github.com/apache/kafka/pull/20007#issuecomment-380251 > @jiafu1115 Could you share the exception you got? I would like to check whether the exception is retriable. If it's, we may not use `Exception` to handle all cases. [2025-06-03

[jira] [Commented] (KAFKA-13077) Replication failing after unclean shutdown of ZK and all brokers

2025-06-24 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985958#comment-17985958 ] Jun Rao commented on KAFKA-13077: - [~gmcrobert] : Thanks for the reply. If the broker is

Re: [PR] KAFKA-18778 Fix the inconsistent lastest supported version in StorageTool.scala and FutureCommand [kafka]

2025-06-24 Thread via GitHub
chia7712 merged PR #19157: URL: https://github.com/apache/kafka/pull/19157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-06-24 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2164104393 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -451,6 +450,41 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

Re: [PR] MINOR: Refactor createResponseConfig to avoid collection copy and conversion [kafka]

2025-06-24 Thread via GitHub
chia7712 commented on code in PR #19867: URL: https://github.com/apache/kafka/pull/19867#discussion_r2164533751 ## core/src/main/scala/kafka/server/ConfigHelper.scala: ## @@ -82,25 +77,43 @@ class ConfigHelper(metadataCache: MetadataCache, config: KafkaConfig, configRepo n

Re: [PR] KAFKA-19420:Don't export SocketServer from ClusterInstance [kafka]

2025-06-24 Thread via GitHub
chia7712 commented on code in PR #20002: URL: https://github.com/apache/kafka/pull/20002#discussion_r2164544423 ## core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala: ## @@ -38,9 +38,9 @@ abstract class AbstractApiVersionsRequestTest(cluster: ClusterInst

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-06-24 Thread via GitHub
kevin-wu24 commented on code in PR #20021: URL: https://github.com/apache/kafka/pull/20021#discussion_r2164212375 ## metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java: ## @@ -345,7 +346,18 @@ private void maybePublishMetadata(MetadataDelta delta, Metadata

Re: [PR] KAFKA-19425: Stop the server when fail to initialize to avoid local segment never got deleted. [kafka]

2025-06-24 Thread via GitHub
jiafu1115 commented on PR #20007: URL: https://github.com/apache/kafka/pull/20007#issuecomment-390886 @FrankYang0529 in fact. I check the code and from the throw exception "FatalExitError" within multiple method's ensureInitializedAndNotClosed. The original goal should shutdown the se

[PR] MINOR: Reject requests using unsupported features in KIP-1071 [kafka]

2025-06-24 Thread via GitHub
lucasbru opened a new pull request, #20031: URL: https://github.com/apache/kafka/pull/20031 KIP-1071 does not currently support all features planned in the KIP. We should reject any requests that are using features that are currently not implemented. -- This is an automated message from

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-06-24 Thread via GitHub
kevin-wu24 commented on code in PR #20021: URL: https://github.com/apache/kafka/pull/20021#discussion_r2164259100 ## metadata/src/test/java/org/apache/kafka/image/loader/metrics/MetadataLoaderMetricsTest.java: ## @@ -153,8 +161,43 @@ public void testSetValueOfCurrentControllerId

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-06-24 Thread via GitHub
JimmyWang6 commented on code in PR #19820: URL: https://github.com/apache/kafka/pull/19820#discussion_r2163756146 ## tools/src/main/java/org/apache/kafka/tools/consumer/group/ShareGroupCommand.java: ## @@ -366,6 +428,70 @@ Entry> sendDeleteShareGroupOffsetsRequest(Stri

Re: [PR] MINOR: Cleanup Connect Module (2/n) [kafka]

2025-06-24 Thread via GitHub
github-actions[bot] commented on PR #19871: URL: https://github.com/apache/kafka/pull/19871#issuecomment-2998675714 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-06-24 Thread via GitHub
chia7712 commented on code in PR #19820: URL: https://github.com/apache/kafka/pull/19820#discussion_r2164775512 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3772,7 +3772,19 @@ class KafkaApis(val requestChannel: RequestChannel, case Some(error) =>

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-06-24 Thread via GitHub
JimmyWang6 commented on code in PR #19820: URL: https://github.com/apache/kafka/pull/19820#discussion_r2160238278 ## tools/src/main/java/org/apache/kafka/tools/consumer/group/ShareGroupCommand.java: ## @@ -366,6 +428,70 @@ Entry> sendDeleteShareGroupOffsetsRequest(Stri

[jira] [Commented] (KAFKA-18786) Enable returnning supported features from a specific broker

2025-06-24 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986013#comment-17986013 ] PoAn Yang commented on KAFKA-18786: --- Vote thread: [https://lists.apache.org/thread/czm

[jira] [Commented] (KAFKA-19427) Kafka 4.0 may have a memory leak, causing an OOM exception

2025-06-24 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986016#comment-17986016 ] RivenSun commented on KAFKA-19427: -- [~showuon] thanks for your apply! After your reply,

[jira] [Updated] (KAFKA-19411) Delete ACLs records can exceed max records per user op

2025-06-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-19411: - Affects Version/s: 4.0.0 3.9.0 3.8.1

[jira] [Updated] (KAFKA-19294) Fix BrokerLifecycleManager RPC timeouts

2025-06-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-19294: - Affects Version/s: 4.0.0 3.9.0 3.8.1

[jira] [Updated] (KAFKA-19411) Delete ACLs records can exceed max records per user op

2025-06-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-19411: - Fix Version/s: 3.8.2 3.9.1 4.0.1 > Delete ACLs records can

Re: [PR] KAFKA-19398: (De)Register oldest-iterator-open-since-ms metric dynamically [kafka]

2025-06-24 Thread via GitHub
bbejeck commented on code in PR #20022: URL: https://github.com/apache/kafka/pull/20022#discussion_r2165155288 ## streams/src/main/java/org/apache/kafka/streams/internals/metrics/OpenIterators.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] [Resolved] (KAFKA-19294) Fix BrokerLifecycleManager RPC timeouts

2025-06-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-19294. -- Resolution: Fixed > Fix BrokerLifecycleManager RPC timeouts >

[jira] [Updated] (KAFKA-19294) Fix BrokerLifecycleManager RPC timeouts

2025-06-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-19294: - Fix Version/s: 3.8.2 3.9.1 4.0.1 4.1.0

Re: [PR] KAFKA-19383: Handle the deleted topics when applying ClearElrRecord (… [kafka]

2025-06-24 Thread via GitHub
cmccabe merged PR #20033: URL: https://github.com/apache/kafka/pull/20033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[PR] MINOR: Clean up in ReassignPartitionsCommandTest [kafka]

2025-06-24 Thread via GitHub
DL1231 opened a new pull request, #20035: URL: https://github.com/apache/kafka/pull/20035 see https://github.com/apache/kafka/pull/20003#discussion_r2164659673 Replace `SimpleImmutableEntry` by `Map.entry`. -- This is an automated message from the Apache Git Service. To respond to the m

[jira] [Resolved] (KAFKA-19383) A duplicate topic record can be created when applying ClearElrRecord.

2025-06-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-19383. -- Resolution: Fixed > A duplicate topic record can be created when applying ClearElrRecord. > --

[jira] [Updated] (KAFKA-19383) A duplicate topic record can be created when applying ClearElrRecord.

2025-06-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-19383: - Fix Version/s: 4.0.1 Affects Version/s: (was: 4.1.0) > A duplicate topic record can

Re: [PR] KAFKA-19398: (De)Register oldest-iterator-open-since-ms metric dynamically [kafka]

2025-06-24 Thread via GitHub
mjsax commented on PR #20022: URL: https://github.com/apache/kafka/pull/20022#issuecomment-3002209280 Merged to `trunk` and cherry-picked to `4.1` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-19390: Call AbstractIndex.safeForceUnmap() in AbstractIndex.resize() on Linux to prevent stale index file memory mappings [kafka]

2025-06-24 Thread via GitHub
junrao commented on code in PR #19961: URL: https://github.com/apache/kafka/pull/19961#discussion_r2164504535 ## storage/src/main/java/org/apache/kafka/storage/internals/log/OffsetIndex.java: ## @@ -95,7 +99,7 @@ public void sanityCheck() { * the pair (baseOffset,

Re: [PR] KAFKA-19306: Migrate LogCompactionTester to tools module [kafka]

2025-06-24 Thread via GitHub
yunchipang commented on PR #19905: URL: https://github.com/apache/kafka/pull/19905#issuecomment-3002238303 @chia7712 can you have a look? thanks! https://github.com/user-attachments/assets/4a61b5bd-d9b6-4c9c-8db2-326b8d03c512"; /> -- This is an automated message from the Apache Git

Re: [PR] KAFKA-19390: Call AbstractIndex.safeForceUnmap() in AbstractIndex.resize() on Linux to prevent stale index file memory mappings [kafka]

2025-06-24 Thread via GitHub
Forest0923 commented on code in PR #19961: URL: https://github.com/apache/kafka/pull/19961#discussion_r2165275363 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java: ## @@ -67,19 +70,23 @@ public TimeIndex(File file, long baseOffset, int maxIndexSize

Re: [PR] KAFKA-19294: Fix BrokerLifecycleManager RPC timeouts [kafka]

2025-06-24 Thread via GitHub
cmccabe merged PR #19745: URL: https://github.com/apache/kafka/pull/19745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-24 Thread via GitHub
k-apol commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2163585695 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -293,6 +302,168 @@ public boolean isValidTransition(final State newState) { private final

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-06-24 Thread via GitHub
JimmyWang6 commented on PR #19820: URL: https://github.com/apache/kafka/pull/19820#issuecomment-325791 Hi @AndrewJSchofield @chia7712 I have updated the PR and resolved several bugs. Here are some of my test scenarios: 1. When a single shareConsumer subscribes to a single t

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-06-24 Thread via GitHub
kevin-wu24 commented on code in PR #20021: URL: https://github.com/apache/kafka/pull/20021#discussion_r2164165881 ## server/src/main/java/org/apache/kafka/server/metrics/NodeMetrics.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] KAFKA-19379: Basic upgrade guide for KIP-1071 EA [kafka]

2025-06-24 Thread via GitHub
Copilot commented on code in PR #20029: URL: https://github.com/apache/kafka/pull/20029#discussion_r2163934623 ## docs/streams/upgrade-guide.html: ## @@ -141,6 +141,91 @@ < Streams API changes in 4.1.0 +Early Access of the Streams Rebalance Protocol + + +

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-06-24 Thread via GitHub
JimmyWang6 commented on code in PR #19820: URL: https://github.com/apache/kafka/pull/19820#discussion_r2164757904 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -682,15 +682,43 @@ CompletableFuture persisterInitialize(

Re: [PR] KAFKA-6333 java.awt.headless should not be on commandline [kafka]

2025-06-24 Thread via GitHub
github-actions[bot] commented on PR #19237: URL: https://github.com/apache/kafka/pull/19237#issuecomment-3002890036 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Write log differently according to the size of missingListenerPartitions [kafka]

2025-06-24 Thread via GitHub
HyunSangHan commented on PR #11418: URL: https://github.com/apache/kafka/pull/11418#issuecomment-3002949678 I am still here! ✋ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] MINOR: Improved ConsumerRebalanceListenerInvoker for code reusage [kafka]

2025-06-24 Thread via GitHub
github-actions[bot] commented on PR #18202: URL: https://github.com/apache/kafka/pull/18202#issuecomment-3002811769 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Refactor createResponseConfig to avoid collection copy and conversion [kafka]

2025-06-24 Thread via GitHub
yunchipang commented on code in PR #19867: URL: https://github.com/apache/kafka/pull/19867#discussion_r2165211489 ## core/src/main/scala/kafka/server/ConfigHelper.scala: ## @@ -82,25 +77,43 @@ class ConfigHelper(metadataCache: MetadataCache, config: KafkaConfig, configRepo

[jira] [Commented] (KAFKA-19433) Unify broker heartbeat RPC timeout and periodic resend timeout

2025-06-24 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985929#comment-17985929 ] Jimmy Wang commented on KAFKA-19433: Hi [~cmccabe] , I think I could help with this

Re: [PR] KAFKA-19398: (De)Register oldest-iterator-open-since-ms metric dynamically [kafka]

2025-06-24 Thread via GitHub
mjsax commented on code in PR #20022: URL: https://github.com/apache/kafka/pull/20022#discussion_r2165139265 ## streams/src/main/java/org/apache/kafka/streams/internals/metrics/OpenIterators.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-18486: Migrate tests to use applyDelta instead of becomeLeaderOrFollower [kafka]

2025-06-24 Thread via GitHub
Yunyung commented on code in PR #20014: URL: https://github.com/apache/kafka/pull/20014#discussion_r2164451789 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -1225,65 +1196,55 @@ class ReplicaManagerTest { } } - @Test - def testBecomeFollowe

Re: [PR] KAFKA-19398: (De)Register oldest-iterator-open-since-ms metric dynamically [kafka]

2025-06-24 Thread via GitHub
mjsax commented on code in PR #20022: URL: https://github.com/apache/kafka/pull/20022#discussion_r2165143314 ## streams/src/main/java/org/apache/kafka/streams/internals/metrics/OpenIterators.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-19398: (De)Register oldest-iterator-open-since-ms metric dynamically [kafka]

2025-06-24 Thread via GitHub
mjsax commented on code in PR #20022: URL: https://github.com/apache/kafka/pull/20022#discussion_r2165139265 ## streams/src/main/java/org/apache/kafka/streams/internals/metrics/OpenIterators.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-19398: (De)Register oldest-iterator-open-since-ms metric dynamically [kafka]

2025-06-24 Thread via GitHub
mjsax merged PR #20022: URL: https://github.com/apache/kafka/pull/20022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Assigned] (KAFKA-19432) Add an ERROR log message if broker.heartbeat.interval.ms is too large

2025-06-24 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-19432: - Assignee: PoAn Yang > Add an ERROR log message if broker.heartbeat.interval.ms is too large > -

Re: [PR] KAFKA-18486: Migrate tests to use applyDelta instead of becomeLeaderOrFollower [kafka]

2025-06-24 Thread via GitHub
jingjia88 commented on code in PR #20014: URL: https://github.com/apache/kafka/pull/20014#discussion_r2164615261 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -1225,65 +1196,55 @@ class ReplicaManagerTest { } } - @Test - def testBecomeFollo

Re: [PR] KAFKA-19383: Handle the deleted topics when applying ClearElrRecord (… [kafka]

2025-06-24 Thread via GitHub
cmccabe merged PR #20034: URL: https://github.com/apache/kafka/pull/20034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19398: (De)Register oldest-iterator-open-since-ms metric dynamically [kafka]

2025-06-24 Thread via GitHub
bbejeck commented on code in PR #20022: URL: https://github.com/apache/kafka/pull/20022#discussion_r2165017062 ## streams/src/main/java/org/apache/kafka/streams/internals/metrics/OpenIterators.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-06-24 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2998676220 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-06-24 Thread via GitHub
JimmyWang6 commented on code in PR #19820: URL: https://github.com/apache/kafka/pull/19820#discussion_r2165262658 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3772,7 +3772,19 @@ class KafkaApis(val requestChannel: RequestChannel, case Some(error) =>

[jira] [Assigned] (KAFKA-19379) Update /streams/upgrade-guide for KIP-1071

2025-06-24 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19379: -- Assignee: Lucas Brutschy > Update /streams/upgrade-guide for KIP-1071 > -

[PR] KAFKA-19244: Fix flaky streams offsets reset integration test [kafka]

2025-06-24 Thread via GitHub
aliehsaeedii opened a new pull request, #20027: URL: https://github.com/apache/kafka/pull/20027 This PR deflakes the `testResetOffsetsWithDeleteSpecifiedInternalTopics()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (KAFKA-19427) Kafka 4.0 may have a memory leak, causing an OOM exception

2025-06-24 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985754#comment-17985754 ] RivenSun commented on KAFKA-19427: -- Add additional information. There are only two topi

[jira] [Updated] (KAFKA-19427) Kafka 4.0 may have a memory leak, causing an OOM exception

2025-06-24 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun updated KAFKA-19427: - Attachment: image-2025-06-25-13-46-30-388.png > Kafka 4.0 may have a memory leak, causing an OOM excepti

[jira] [Commented] (KAFKA-19427) Kafka 4.0 may have a memory leak, causing an OOM exception

2025-06-24 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985998#comment-17985998 ] RivenSun commented on KAFKA-19427: -- [~dajac] [~chia7712] thanks for your reply! As for

[jira] [Commented] (KAFKA-19427) Kafka 4.0 may have a memory leak, causing an OOM exception

2025-06-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986007#comment-17986007 ] Luke Chen commented on KAFKA-19427: --- So the root cause should be this config: `message

[jira] [Comment Edited] (KAFKA-19427) Kafka 4.0 may have a memory leak, causing an OOM exception

2025-06-24 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985998#comment-17985998 ] RivenSun edited comment on KAFKA-19427 at 6/25/25 5:49 AM: --- [~

  1   2   >