k-apol commented on code in PR #19913:
URL: https://github.com/apache/kafka/pull/19913#discussion_r2163656554
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##########
@@ -461,15 +469,22 @@ public Set<String> makeReady(final Map<String,
InternalTopicConfig> topics) {
// have existed with the expected number of partitions, or some create
topic returns fatal errors.
log.debug("Starting to validate internal topics {} in partition
assignor.", topics);
- long currentWallClockMs = time.milliseconds();
+ final long currentWallClockMs = time.milliseconds();
final long deadlineMs = currentWallClockMs + retryTimeoutMs;
+ final long initDeadlineMs = currentWallClockMs +
this.initTimeout.toMillis();
Set<String> topicsNotReady = new HashSet<>(topics.keySet());
final Set<String> newlyCreatedTopics = new HashSet<>();
while (!topicsNotReady.isEmpty()) {
final Set<String> tempUnknownTopics = new HashSet<>();
topicsNotReady = validateTopics(topicsNotReady, topics,
tempUnknownTopics);
+
+ if (this.isManualInternalTopicConfig && !this.isInitializing) {
+ throw new MissingInternalTopicsException("Internal topic
configuration set to MANUAL. \n" +
+ "You must call init() to setup internal topics.", new
ArrayList<>(topicsNotReady));
+ }
+
newlyCreatedTopics.addAll(topicsNotReady);
if (!topicsNotReady.isEmpty()) {
Review Comment:
@mjsax I have a small PR open to add just the exceptions, happy to open
another small one to refactor this method and make it easier to work with as
part of this PR. Let me know what you think, can always do this after as well.
Trying to avoid as much refactoring as possible in this PR, despite that there
is a lot needed and still a bit more to come.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
